* Fwd: Request to add bluetooth module identifier to net/rfkill/rfkill-gpio.c [not found] <CALnajPDkZi5tOTcghFCRHg8EiLgXXy1nWo+b7R4DxX8iEd1g0Q@mail.gmail.com> @ 2017-07-08 8:54 ` Sundar Nagarajan 2017-07-08 12:20 ` Marcel Holtmann 0 siblings, 1 reply; 2+ messages in thread From: Sundar Nagarajan @ 2017-07-08 8:54 UTC (permalink / raw) To: Johannes Berg, David S. Miller, linux-wireless, netdev, linux-kernel [-- Attachment #1: Type: text/plain, Size: 796 bytes --] Hi, I have a Cherry Trail laptop with an Atom X5-Z8300. It has a bluetooth chip that needs the r8723bs (coexisting RTL 8723BS wifi and bluetooth). I am using linux-next (20150817) with the r8723bs staging driver and the firmware and utility from https://github.com/lwfinger/rtl8723bs_bt by Larry finger. With linux-next the bluetooth works SOMETIMES, but on reboot, it does not work any more (no bluetooth interfaces are detected and hciconfig shows nothing). I am a kernel novice, but I saw that another kernel that I had tried had the following line added in struct acpi_device_id rfkill_acpi_match: { "OBDA8723",RFKILL_TYPE_BLUETOOTH } With the attached patch applied (one line added), my bluetooth works every time. Does this belong in rfkill-gpio.c, or should I contact someone else? [-- Attachment #2: 0001_linux-next-20170516-rdp_bluetooth.patch --] [-- Type: text/x-patch, Size: 467 bytes --] diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c index 76c01cb..4e32def 100644 --- a/net/rfkill/rfkill-gpio.c +++ b/net/rfkill/rfkill-gpio.c @@ -163,6 +163,7 @@ static int rfkill_gpio_remove(struct platform_device *pdev) static const struct acpi_device_id rfkill_acpi_match[] = { { "BCM4752", RFKILL_TYPE_GPS }, { "LNV4752", RFKILL_TYPE_GPS }, + { "OBDA8723",RFKILL_TYPE_BLUETOOTH }, { }, }; MODULE_DEVICE_TABLE(acpi, rfkill_acpi_match); ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Request to add bluetooth module identifier to net/rfkill/rfkill-gpio.c 2017-07-08 8:54 ` Fwd: Request to add bluetooth module identifier to net/rfkill/rfkill-gpio.c Sundar Nagarajan @ 2017-07-08 12:20 ` Marcel Holtmann 0 siblings, 0 replies; 2+ messages in thread From: Marcel Holtmann @ 2017-07-08 12:20 UTC (permalink / raw) To: Sundar Nagarajan Cc: Johannes Berg, David S. Miller, linux-wireless, Network Development, linux-kernel Hi Sundar, > I have a Cherry Trail laptop with an Atom X5-Z8300. It has a bluetooth > chip that needs the r8723bs (coexisting RTL 8723BS wifi and > bluetooth). > > I am using linux-next (20150817) with the r8723bs staging driver and > the firmware and utility from https://github.com/lwfinger/rtl8723bs_bt > by Larry finger. > > With linux-next the bluetooth works SOMETIMES, but on reboot, it does > not work any more (no bluetooth interfaces are detected and hciconfig > shows nothing). > > I am a kernel novice, but I saw that another kernel that I had tried > had the following line added in struct acpi_device_id > rfkill_acpi_match: > > { "OBDA8723",RFKILL_TYPE_BLUETOOTH } > > With the attached patch applied (one line added), my bluetooth works every time. > > Does this belong in rfkill-gpio.c, or should I contact someone else? it does not belong in rfkill-gpio.c since this controls the power of the Bluetooth device. This belongs in the Bluetooth driver. We already moved all the Intel and Broadcom ones into hci_intel.c and respectively hci_bcm.c. So have the staging driver deal with the power GPIO. Regards Marcel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-08 12:20 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <CALnajPDkZi5tOTcghFCRHg8EiLgXXy1nWo+b7R4DxX8iEd1g0Q@mail.gmail.com> 2017-07-08 8:54 ` Fwd: Request to add bluetooth module identifier to net/rfkill/rfkill-gpio.c Sundar Nagarajan 2017-07-08 12:20 ` Marcel Holtmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).