Fwd: Request to add bluetooth module identifier to net/rfkill/rfkill-gpio.c

Fwd: Request to add bluetooth module identifier to net/rfkill/rfkill-gpio.c

[Sundar Nagarajan]

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

Hi,

I have a Cherry Trail laptop with an Atom X5-Z8300. It has a bluetooth
chip that needs the r8723bs (coexisting RTL 8723BS wifi and
bluetooth).

I am using linux-next (20150817) with the r8723bs staging driver and
the firmware and utility from https://github.com/lwfinger/rtl8723bs_bt
by Larry finger.

With linux-next the bluetooth works SOMETIMES, but on reboot, it does
not work any more (no bluetooth interfaces are detected and hciconfig
shows nothing).

I am a kernel novice, but I saw that another kernel that I had tried
had the following line added in struct acpi_device_id
rfkill_acpi_match:

{ "OBDA8723",RFKILL_TYPE_BLUETOOTH }

With the attached patch applied (one line added), my bluetooth works every time.

Does this belong in rfkill-gpio.c, or should I contact someone else?

[-- Attachment #2: 0001_linux-next-20170516-rdp_bluetooth.patch --]
[-- Type: text/x-patch, Size: 467 bytes --]

diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
index 76c01cb..4e32def 100644
--- a/net/rfkill/rfkill-gpio.c
+++ b/net/rfkill/rfkill-gpio.c
@@ -163,6 +163,7 @@ static int rfkill_gpio_remove(struct platform_device *pdev)
 static const struct acpi_device_id rfkill_acpi_match[] = {
 	{ "BCM4752", RFKILL_TYPE_GPS },
 	{ "LNV4752", RFKILL_TYPE_GPS },
+     { "OBDA8723",RFKILL_TYPE_BLUETOOTH },
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, rfkill_acpi_match);

Re: Request to add bluetooth module identifier to net/rfkill/rfkill-gpio.c

[Marcel Holtmann]

Hi Sundar,

> I have a Cherry Trail laptop with an Atom X5-Z8300. It has a bluetooth
> chip that needs the r8723bs (coexisting RTL 8723BS wifi and
> bluetooth).
> 
> I am using linux-next (20150817) with the r8723bs staging driver and
> the firmware and utility from https://github.com/lwfinger/rtl8723bs_bt
> by Larry finger.
> 
> With linux-next the bluetooth works SOMETIMES, but on reboot, it does
> not work any more (no bluetooth interfaces are detected and hciconfig
> shows nothing).
> 
> I am a kernel novice, but I saw that another kernel that I had tried
> had the following line added in struct acpi_device_id
> rfkill_acpi_match:
> 
> { "OBDA8723",RFKILL_TYPE_BLUETOOTH }
> 
> With the attached patch applied (one line added), my bluetooth works every time.
> 
> Does this belong in rfkill-gpio.c, or should I contact someone else?

it does not belong in rfkill-gpio.c since this controls the power of the Bluetooth device. This belongs in the Bluetooth driver. We already moved all the Intel and Broadcom ones into hci_intel.c and respectively hci_bcm.c. So have the staging driver deal with the power GPIO.

Regards

Marcel