From: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Alexander Lobakin <alobakin@dlink.ru>,
Edward Cree <ecree@solarflare.com>,
David Miller <davem@davemloft.net>,
"jiri@mellanox.com" <jiri@mellanox.com>,
"edumazet@google.com" <edumazet@google.com>,
"idosch@mellanox.com" <idosch@mellanox.com>,
"petrm@mellanox.com" <petrm@mellanox.com>,
"sd@queasysnail.net" <sd@queasysnail.net>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"jaswinder.singh@linaro.org" <jaswinder.singh@linaro.org>,
"ilias.apalodimas@linaro.org" <ilias.apalodimas@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"emmanuel.grumbach@intel.com" <emmanuel.grumbach@intel.com>,
"luciano.coelho@intel.com" <luciano.coelho@intel.com>,
"linuxwifi@intel.com" <linuxwifi@intel.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()
Date: Mon, 25 Nov 2019 13:07:01 +0000 [thread overview]
Message-ID: <PSXP216MB04382C21FF000C9A516324D4804A0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <b4b92c4d066007d9cb77e1645e667715c17834fb.camel@redhat.com>
On Mon, Nov 25, 2019 at 12:42:44PM +0100, Paolo Abeni wrote:
> I think it would be nice moving the iwlwifi driver to full/plain NAPI
> mode. The interrupt handler could keep processing extra work as it does
> now and queue real pkts on some internal queue, and than schedule the
> relevant napi, which in turn could process such queue in the napi poll
> method. Likely I missed tons of details and/or oversimplified it...
It must have something to do with iwlwifi (as if we needed more
evidence). I just booted a different variant of the Dell XPS 9370 which
has Qualcomm Wi-Fi [168c:003e] (ath10k_pci.ko), instead of Intel Wi-Fi,
from the same USB SSD as before, and it has no issues whatsoever.
My regression report quickly blown up to be way over my head in terms of
understanding, but I will keep monitoring the discussions and try to
learn from it. Everybody, please keep me CC'd into any further
communications with driver teams, as I am genuinely interested in the
journey and the outcome.
> Cheers,
>
> Paolo
>
>
Cheers,
Nicholas
next prev parent reply other threads:[~2019-11-25 13:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191014080033.12407-1-alobakin@dlink.ru>
[not found] ` <20191015.181649.949805234862708186.davem@davemloft.net>
[not found] ` <7e68da00d7c129a8ce290229743beb3d@dlink.ru>
[not found] ` <PSXP216MB04388962C411CD0B17A86F47804A0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
[not found] ` <c762f5eee08a8f2d0d6cb927d7fa3848@dlink.ru>
2019-11-25 8:25 ` [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() Alexander Lobakin
2019-11-25 9:09 ` Nicholas Johnson
2019-11-25 10:31 ` Edward Cree
2019-11-25 10:58 ` Alexander Lobakin
2019-11-25 11:05 ` Johannes Berg
2019-11-25 11:42 ` Paolo Abeni
2019-11-25 12:02 ` Alexander Lobakin
2019-11-25 13:21 ` Edward Cree
2019-11-25 13:39 ` Alexander Lobakin
2019-11-26 23:57 ` David Miller
2019-11-27 7:47 ` Alexander Lobakin
2019-11-27 8:30 ` Johannes Berg
2019-11-27 9:47 ` Alexander Lobakin
2019-11-25 12:11 ` Kalle Valo
2019-11-25 13:07 ` Nicholas Johnson [this message]
2019-11-25 13:11 ` Nicholas Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PSXP216MB04382C21FF000C9A516324D4804A0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM \
--to=nicholas.johnson-opensource@outlook.com.au \
--cc=alobakin@dlink.ru \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=edumazet@google.com \
--cc=emmanuel.grumbach@intel.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jaswinder.singh@linaro.org \
--cc=jiri@mellanox.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@mellanox.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).