[PATCH v2] mwifiex: do not support change AP interface to station mode

[PATCH v2] mwifiex: do not support change AP interface to station mode

[Xinming Hu]

Firmware do not support change interface from micro-ap mode to
station mode, forbidden this operation in driver accordingly.

Signed-off-by: Cathy Luo <cluo@marvell.com>
Signed-off-by: Xinming Hu <huxm@marvell.com>
---
v2: remove unnecessary sta/uap combo check(James Cameron)

 drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index 6e0d9a9..4d45df8 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -1180,7 +1180,6 @@ static int mwifiex_deinit_priv_params(struct mwifiex_private *priv)
 	case NL80211_IFTYPE_AP:
 		switch (type) {
 		case NL80211_IFTYPE_ADHOC:
-		case NL80211_IFTYPE_STATION:
 			return mwifiex_change_vif_to_sta_adhoc(dev, curr_iftype,
 							       type, params);
 			break;
-- 
1.9.1

Re: [PATCH v2] mwifiex: do not support change AP interface to station mode

[James Cameron]

On Tue, Nov 21, 2017 at 08:03:35PM +0800, Xinming Hu wrote:
> Firmware do not support change interface from micro-ap mode to
> station mode, forbidden this operation in driver accordingly.

"forbidden" should be "forbid", for correct tense.

"in driver" is redundant and can be removed.

"accordingly" is also redundant.

Perhaps "Firmware do not support change interface from micro-ap mode
to station mode, forbid this operation."

> Signed-off-by: Cathy Luo <cluo@marvell.com>
> Signed-off-by: Xinming Hu <huxm@marvell.com>
> ---
> v2: remove unnecessary sta/uap combo check(James Cameron)
> 
>  drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index 6e0d9a9..4d45df8 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -1180,7 +1180,6 @@ static int mwifiex_deinit_priv_params(struct mwifiex_private *priv)
>  	case NL80211_IFTYPE_AP:
>  		switch (type) {
>  		case NL80211_IFTYPE_ADHOC:

Change interface type from micro-ap to adhoc is supported?

> -		case NL80211_IFTYPE_STATION:
>  			return mwifiex_change_vif_to_sta_adhoc(dev, curr_iftype,
>  							       type, params);
>  			break;
> -- 
> 1.9.1
> 

-- 
James Cameron
http://quozl.netrek.org/

RE: [PATCH v2] mwifiex: do not support change AP interface to station mode

[Xinming Hu]

SGkgSmFtZXMsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogcXVvemxA
bGFwdG9wLm9yZyBbbWFpbHRvOnF1b3psQGxhcHRvcC5vcmddDQo+IFNlbnQ6IDIwMTfE6jEx1MIy
MsjVIDM6MzENCj4gVG86IFhpbm1pbmcgSHUgPGh1eG1AbWFydmVsbC5jb20+DQo+IENjOiBMaW51
eCBXaXJlbGVzcyA8bGludXgtd2lyZWxlc3NAdmdlci5rZXJuZWwub3JnPjsgS2FsbGUgVmFsbw0K
PiA8a3ZhbG9AY29kZWF1cm9yYS5vcmc+OyBCcmlhbiBOb3JyaXMgPGJyaWFubm9ycmlzQGNocm9t
aXVtLm9yZz47IERtaXRyeQ0KPiBUb3Jva2hvdiA8ZHRvckBnb29nbGUuY29tPjsgcmFqYXRqYUBn
b29nbGUuY29tOyBaaGl5dWFuIFlhbmcNCj4gPHlhbmd6eUBtYXJ2ZWxsLmNvbT47IFRpbSBTb25n
IDxzb25ndGFvQG1hcnZlbGwuY29tPjsgQ2F0aHkgTHVvDQo+IDxjbHVvQG1hcnZlbGwuY29tPjsg
SmFtZXMgQ2FvIDxqY2FvQG1hcnZlbGwuY29tPjsgR2FuYXBhdGhpIEJoYXQNCj4gPGdiaGF0QG1h
cnZlbGwuY29tPjsgRWxsaWUgUmVldmVzIDxlbGxpZXJldnZlc0BnbWFpbC5jb20+DQo+IFN1Ympl
Y3Q6IFJlOiBbUEFUQ0ggdjJdIG13aWZpZXg6IGRvIG5vdCBzdXBwb3J0IGNoYW5nZSBBUCBpbnRl
cmZhY2UgdG8gc3RhdGlvbg0KPiBtb2RlDQo+IA0KPiBPbiBUdWUsIE5vdiAyMSwgMjAxNyBhdCAw
ODowMzozNVBNICswODAwLCBYaW5taW5nIEh1IHdyb3RlOg0KPiA+IEZpcm13YXJlIGRvIG5vdCBz
dXBwb3J0IGNoYW5nZSBpbnRlcmZhY2UgZnJvbSBtaWNyby1hcCBtb2RlIHRvIHN0YXRpb24NCj4g
PiBtb2RlLCBmb3JiaWRkZW4gdGhpcyBvcGVyYXRpb24gaW4gZHJpdmVyIGFjY29yZGluZ2x5Lg0K
PiANCj4gImZvcmJpZGRlbiIgc2hvdWxkIGJlICJmb3JiaWQiLCBmb3IgY29ycmVjdCB0ZW5zZS4N
Cj4gDQo+ICJpbiBkcml2ZXIiIGlzIHJlZHVuZGFudCBhbmQgY2FuIGJlIHJlbW92ZWQuDQo+IA0K
PiAiYWNjb3JkaW5nbHkiIGlzIGFsc28gcmVkdW5kYW50Lg0KPiANCj4gUGVyaGFwcyAiRmlybXdh
cmUgZG8gbm90IHN1cHBvcnQgY2hhbmdlIGludGVyZmFjZSBmcm9tIG1pY3JvLWFwIG1vZGUgdG8N
Cj4gc3RhdGlvbiBtb2RlLCBmb3JiaWQgdGhpcyBvcGVyYXRpb24uIg0KPiANCg0KT2ssIGl0IGxv
b2tzIGJldHRlci4NCg0KPiA+IFNpZ25lZC1vZmYtYnk6IENhdGh5IEx1byA8Y2x1b0BtYXJ2ZWxs
LmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBYaW5taW5nIEh1IDxodXhtQG1hcnZlbGwuY29tPg0K
PiA+IC0tLQ0KPiA+IHYyOiByZW1vdmUgdW5uZWNlc3Nhcnkgc3RhL3VhcCBjb21ibyBjaGVjayhK
YW1lcyBDYW1lcm9uKQ0KPiA+DQo+ID4gIGRyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZlbGwvbXdp
ZmlleC9jZmc4MDIxMS5jIHwgMSAtDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGRlbGV0aW9uKC0p
DQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvbWFydmVsbC9td2lm
aWV4L2NmZzgwMjExLmMNCj4gPiBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZlbGwvbXdpZmll
eC9jZmc4MDIxMS5jDQo+ID4gaW5kZXggNmUwZDlhOS4uNGQ0NWRmOCAxMDA2NDQNCj4gPiAtLS0g
YS9kcml2ZXJzL25ldC93aXJlbGVzcy9tYXJ2ZWxsL213aWZpZXgvY2ZnODAyMTEuYw0KPiA+ICsr
KyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZlbGwvbXdpZmlleC9jZmc4MDIxMS5jDQo+ID4g
QEAgLTExODAsNyArMTE4MCw2IEBAIHN0YXRpYyBpbnQgbXdpZmlleF9kZWluaXRfcHJpdl9wYXJh
bXMoc3RydWN0DQo+IG13aWZpZXhfcHJpdmF0ZSAqcHJpdikNCj4gPiAgCWNhc2UgTkw4MDIxMV9J
RlRZUEVfQVA6DQo+ID4gIAkJc3dpdGNoICh0eXBlKSB7DQo+ID4gIAkJY2FzZSBOTDgwMjExX0lG
VFlQRV9BREhPQzoNCj4gDQo+IENoYW5nZSBpbnRlcmZhY2UgdHlwZSBmcm9tIG1pY3JvLWFwIHRv
IGFkaG9jIGlzIHN1cHBvcnRlZD8NCg0KWWVzLCBpdCBpcyBzdXBwb3J0ZWQgaW4gRlcuDQoNCj4g
DQo+ID4gLQkJY2FzZSBOTDgwMjExX0lGVFlQRV9TVEFUSU9OOg0KPiA+ICAJCQlyZXR1cm4gbXdp
ZmlleF9jaGFuZ2VfdmlmX3RvX3N0YV9hZGhvYyhkZXYsIGN1cnJfaWZ0eXBlLA0KPiA+ICAJCQkJ
CQkJICAgICAgIHR5cGUsIHBhcmFtcyk7DQo+ID4gIAkJCWJyZWFrOw0KPiA+IC0tDQo+ID4gMS45
LjENCj4gPg0KPiANCj4gLS0NCj4gSmFtZXMgQ2FtZXJvbg0KPiBodHRwOi8vcXVvemwubmV0cmVr
Lm9yZy8NCg==