[PATCH] ieee802154:: propagate genlmsg_reply return code

[PATCH] ieee802154:: propagate genlmsg_reply return code

[Li RongQing]

genlmsg_reply can fail, so propagate its return code

Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
 drivers/net/ieee802154/mac802154_hwsim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
index b6743f03dce0..3b88846de31b 100644
--- a/drivers/net/ieee802154/mac802154_hwsim.c
+++ b/drivers/net/ieee802154/mac802154_hwsim.c
@@ -324,7 +324,7 @@ static int hwsim_get_radio_nl(struct sk_buff *msg, struct genl_info *info)
 			goto out_err;
 		}
 
-		genlmsg_reply(skb, info);
+		res = genlmsg_reply(skb, info);
 		break;
 	}
 
-- 
2.16.2

Re: [PATCH] ieee802154:: propagate genlmsg_reply return code

[Stefan Schmidt]

Hello Li.

On 19.02.19 06:10, Li RongQing wrote:
> genlmsg_reply can fail, so propagate its return code
> 
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
>  drivers/net/ieee802154/mac802154_hwsim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
> index b6743f03dce0..3b88846de31b 100644
> --- a/drivers/net/ieee802154/mac802154_hwsim.c
> +++ b/drivers/net/ieee802154/mac802154_hwsim.c
> @@ -324,7 +324,7 @@ static int hwsim_get_radio_nl(struct sk_buff *msg, struct genl_info *info)
>  			goto out_err;
>  		}
>  
> -		genlmsg_reply(skb, info);
> +		res = genlmsg_reply(skb, info);
>  		break;
>  	}
>  
> 

I would prefer the subject line to also include the part the patch
applies to, in this case the hwsim driver. In my book that is easier to
grasp. But it is a nitpick really and I fixed it up for you when
applying. New subject line is:

 ieee802154: hwsim: propagate genlmsg_reply return code

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt