From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/6] xfs_scrub: handle totally empty inode chunks
Date: Wed, 28 Nov 2018 18:38:26 -0600 [thread overview]
Message-ID: <2ab342dd-f654-390a-5c36-8eda3d310834@sandeen.net> (raw)
In-Reply-To: <20181129003508.GJ8125@magnolia>
On 11/28/18 6:35 PM, Darrick J. Wong wrote:
> On Wed, Nov 28, 2018 at 06:16:37PM -0600, Eric Sandeen wrote:
>> On 11/9/18 6:45 PM, Darrick J. Wong wrote:
>>> From: Darrick J. Wong <darrick.wong@oracle.com>
>>>
>>> We try to load a single inobt record with each FSINUMBERS call. If the
>>> chunk is totally empty (which can happen when there are more than one
>>> inobt record per block) we should skip to the next INUMBERS call since
>>> there are no inodes to bulkstat.
>>
>> It's not clear to me if this is a bugfix or an optimization, but meh,
>> seems like the right thing to do :)
>
> It's a bug fix for 64k-block filesystems, which can have multiple empty
> inobt records that map to a single 64k block; if we try to BULKSTAT an
> empty inobt group then we get zero inodes and scrub erroneously says the
> fs is broken when in reality it's just stupid.
Ok thanks, didn't dig into whether it did needless no-op calls, or something
worse.
-eric
next prev parent reply other threads:[~2018-11-29 11:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 0:45 [PATCH 0/6] xfsprogs-4.20: various fixes Darrick J. Wong
2018-11-10 0:45 ` [PATCH 1/6] xfs_io.8: rearrange command listings by section Darrick J. Wong
2018-11-28 22:39 ` Eric Sandeen
2018-11-28 23:34 ` Darrick J. Wong
2018-11-28 23:46 ` Eric Sandeen
2018-12-05 3:21 ` [PATCH 1/6 V2] " Eric Sandeen
2018-12-05 17:56 ` Darrick J. Wong
2018-11-10 0:45 ` [PATCH 2/6] xfs_repair: don't error out on dirs with a single leafn block Darrick J. Wong
2018-11-22 18:13 ` [PATCH v2 " Darrick J. Wong
2018-12-05 3:48 ` Eric Sandeen
2018-12-05 4:11 ` Eric Sandeen
2018-12-05 16:48 ` Darrick J. Wong
2018-12-05 16:54 ` Eric Sandeen
2018-11-10 0:45 ` [PATCH 3/6] xfs_repair: skip block reservation when fixing freelist Darrick J. Wong
2018-11-10 7:22 ` Allison Henderson
2018-11-28 23:34 ` Eric Sandeen
2018-11-10 0:45 ` [PATCH 4/6] xfs_scrub: handle totally empty inode chunks Darrick J. Wong
2018-11-10 7:19 ` Allison Henderson
2018-11-29 0:16 ` Eric Sandeen
2018-11-29 0:35 ` Darrick J. Wong
2018-11-29 0:38 ` Eric Sandeen [this message]
2018-11-10 0:45 ` [PATCH 5/6] xfs_scrub: fix fractional reporting of single inodes Darrick J. Wong
2018-11-10 7:15 ` Allison Henderson
2018-11-10 17:52 ` Darrick J. Wong
2018-11-10 0:45 ` [PATCH 6/6] xfs_scrub: move everything to /usr/sbin Darrick J. Wong
2018-11-10 6:45 ` Allison Henderson
2018-11-10 8:43 ` L A Walsh
2018-11-10 18:06 ` Darrick J. Wong
2018-11-27 23:15 ` [PATCH 7/6] xfs_db: add missing string name for DBM_COWDATA Darrick J. Wong
2018-11-29 0:37 ` Eric Sandeen
2018-11-29 0:54 ` [PATCH v2 " Darrick J. Wong
2018-11-29 5:24 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ab342dd-f654-390a-5c36-8eda3d310834@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).