From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 7/6] xfs_db: add missing string name for DBM_COWDATA
Date: Wed, 28 Nov 2018 18:37:40 -0600 [thread overview]
Message-ID: <7730aacc-0b44-bc48-df57-e29aa64eac03@sandeen.net> (raw)
In-Reply-To: <20181127231545.GA8125@magnolia>
On 11/27/18 5:15 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> In db/check.c, typename[] is supposed to have strings for every DBM_
> type, but we forgot one. Add it now.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> db/check.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/db/check.c b/db/check.c
> index 352aab3f..f5b5e845 100644
> --- a/db/check.c
> +++ b/db/check.c
> @@ -164,6 +164,7 @@ static const char *typename[] = {
> "btrmap",
> "btrefcnt",
> "rldata",
> + "cowdata",
> NULL
> };
> static int verbose;
Maybe:
/* Every type plus the NULL at the end */
BUILD_BUG_ON(ARRAY_SIZE(typename) != DBM_NDBM + 1);
in init() to avoid this next time?
-Eric
next prev parent reply other threads:[~2018-11-29 11:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 0:45 [PATCH 0/6] xfsprogs-4.20: various fixes Darrick J. Wong
2018-11-10 0:45 ` [PATCH 1/6] xfs_io.8: rearrange command listings by section Darrick J. Wong
2018-11-28 22:39 ` Eric Sandeen
2018-11-28 23:34 ` Darrick J. Wong
2018-11-28 23:46 ` Eric Sandeen
2018-12-05 3:21 ` [PATCH 1/6 V2] " Eric Sandeen
2018-12-05 17:56 ` Darrick J. Wong
2018-11-10 0:45 ` [PATCH 2/6] xfs_repair: don't error out on dirs with a single leafn block Darrick J. Wong
2018-11-22 18:13 ` [PATCH v2 " Darrick J. Wong
2018-12-05 3:48 ` Eric Sandeen
2018-12-05 4:11 ` Eric Sandeen
2018-12-05 16:48 ` Darrick J. Wong
2018-12-05 16:54 ` Eric Sandeen
2018-11-10 0:45 ` [PATCH 3/6] xfs_repair: skip block reservation when fixing freelist Darrick J. Wong
2018-11-10 7:22 ` Allison Henderson
2018-11-28 23:34 ` Eric Sandeen
2018-11-10 0:45 ` [PATCH 4/6] xfs_scrub: handle totally empty inode chunks Darrick J. Wong
2018-11-10 7:19 ` Allison Henderson
2018-11-29 0:16 ` Eric Sandeen
2018-11-29 0:35 ` Darrick J. Wong
2018-11-29 0:38 ` Eric Sandeen
2018-11-10 0:45 ` [PATCH 5/6] xfs_scrub: fix fractional reporting of single inodes Darrick J. Wong
2018-11-10 7:15 ` Allison Henderson
2018-11-10 17:52 ` Darrick J. Wong
2018-11-10 0:45 ` [PATCH 6/6] xfs_scrub: move everything to /usr/sbin Darrick J. Wong
2018-11-10 6:45 ` Allison Henderson
2018-11-10 8:43 ` L A Walsh
2018-11-10 18:06 ` Darrick J. Wong
2018-11-27 23:15 ` [PATCH 7/6] xfs_db: add missing string name for DBM_COWDATA Darrick J. Wong
2018-11-29 0:37 ` Eric Sandeen [this message]
2018-11-29 0:54 ` [PATCH v2 " Darrick J. Wong
2018-11-29 5:24 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7730aacc-0b44-bc48-df57-e29aa64eac03@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).