From: L A Walsh <xfs@tlinx.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>, linux-xfs@vger.kernel.org
Cc: allison.henderson@oracle.com
Subject: Re: [PATCH 6/6] xfs_scrub: move everything to /usr/sbin
Date: Sat, 10 Nov 2018 00:43:58 -0800 [thread overview]
Message-ID: <5BE69A4E.2050902@tlinx.org> (raw)
In-Reply-To: <154181075273.3727.12563703121689677996.stgit@magnolia>
On 11/9/2018 4:45 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Recently, it was pointed out that xfs_scrub{,_all} depend on components
> and libraries (libicu, python) that live in /usr. /sbin binaries
> shouldn't depend on /usr, so let's move the scrub binaries to /usr/sbin.
----
As stated in the original comment, only "xfs_scrub_all"
depends on /usr, as it depends on /usr/bin/python.
System binaries that might be used to repair problems should, IMO,
reside on /sbin (or /bin) if they don't depend on /usr.
xfs_scrub has no non-root dependencies on my version:
> ldd /sbin/xfs_scrub
linux-vdso.so.1 (0x00007ffe275d1000)
libc.so.6 => /lib64/libc.so.6 (0x00007fd1c3561000)
libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fd1c3342000)
/lib64/ld-linux-x86-64.so.2 (0x00007fd1c3b32000)
Ideally the same should go for xfs_restore (and dump), xfs.mkfs,
xfs_repair, xfs_admin, maybe xfs_db (hopefully rare), and xfs_irecover.
Please don't _unnecessarily_ move binaries that might be needed for fs repair
onto /usr if possible. I've found that using 'xfs' for a root
file system eliminates my need for an indirect boot off of a
ram disk.
xfs has been far more stable and easy to use than indirect methods involving
a separate ramdisk.
Thanks,
-linda
next prev parent reply other threads:[~2018-11-10 18:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 0:45 [PATCH 0/6] xfsprogs-4.20: various fixes Darrick J. Wong
2018-11-10 0:45 ` [PATCH 1/6] xfs_io.8: rearrange command listings by section Darrick J. Wong
2018-11-28 22:39 ` Eric Sandeen
2018-11-28 23:34 ` Darrick J. Wong
2018-11-28 23:46 ` Eric Sandeen
2018-12-05 3:21 ` [PATCH 1/6 V2] " Eric Sandeen
2018-12-05 17:56 ` Darrick J. Wong
2018-11-10 0:45 ` [PATCH 2/6] xfs_repair: don't error out on dirs with a single leafn block Darrick J. Wong
2018-11-22 18:13 ` [PATCH v2 " Darrick J. Wong
2018-12-05 3:48 ` Eric Sandeen
2018-12-05 4:11 ` Eric Sandeen
2018-12-05 16:48 ` Darrick J. Wong
2018-12-05 16:54 ` Eric Sandeen
2018-11-10 0:45 ` [PATCH 3/6] xfs_repair: skip block reservation when fixing freelist Darrick J. Wong
2018-11-10 7:22 ` Allison Henderson
2018-11-28 23:34 ` Eric Sandeen
2018-11-10 0:45 ` [PATCH 4/6] xfs_scrub: handle totally empty inode chunks Darrick J. Wong
2018-11-10 7:19 ` Allison Henderson
2018-11-29 0:16 ` Eric Sandeen
2018-11-29 0:35 ` Darrick J. Wong
2018-11-29 0:38 ` Eric Sandeen
2018-11-10 0:45 ` [PATCH 5/6] xfs_scrub: fix fractional reporting of single inodes Darrick J. Wong
2018-11-10 7:15 ` Allison Henderson
2018-11-10 17:52 ` Darrick J. Wong
2018-11-10 0:45 ` [PATCH 6/6] xfs_scrub: move everything to /usr/sbin Darrick J. Wong
2018-11-10 6:45 ` Allison Henderson
2018-11-10 8:43 ` L A Walsh [this message]
2018-11-10 18:06 ` Darrick J. Wong
2018-11-27 23:15 ` [PATCH 7/6] xfs_db: add missing string name for DBM_COWDATA Darrick J. Wong
2018-11-29 0:37 ` Eric Sandeen
2018-11-29 0:54 ` [PATCH v2 " Darrick J. Wong
2018-11-29 5:24 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BE69A4E.2050902@tlinx.org \
--to=xfs@tlinx.org \
--cc=allison.henderson@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).