* [PATCH 00/58] serial/sysrq: Cleanup ifdeffery
@ 2019-12-13 0:05 Dmitry Safonov
2019-12-13 0:06 ` [PATCH 05/58] tty/serial: Migrate 8250_fsl to use has_sysrq Dmitry Safonov
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Dmitry Safonov @ 2019-12-13 0:05 UTC (permalink / raw)
To: linux-kernel
Cc: Alexandre Belloni, linux-aspeed, Dmitry Safonov, Bjorn Andersson,
Paul Mackerras, Maciej W. Rozycki, sparclinux, Shawn Guo,
Fabio Estevam, linux-stm32, Kees Cook, Vasiliy Khoruzhick,
Alexander Shiyan, Dmitry Safonov, Russell King,
Ludovic Desroches, Andy Gross, bcm-kernel-feedback-list,
Joel Stanley, linux-serial, Jiri Slaby, Orson Zhai, Iurii Zaikin,
Kevin Hilman, NXP Linux Team, Michal Simek, Alexandre Torgue,
linux-arm-msm, Sascha Hauer, Uwe Kleine-König, Johan Hovold,
linux-fsdevel, Florian Fainelli, Chunyan Zhang, linux-amlogic,
linux-arm-kernel, Maxime Coquelin, Timur Tabi, Andrew Jeffery,
Greg Kroah-Hartman, Patrice Chotard, Tony Prisk, Richard Genoud,
Luis Chamberlain, Pengutronix Kernel Team, Vineet Gupta,
Baolin Wang, linuxppc-dev, David S. Miller
The original purpose of the patches set was to add a way to enable
sysrq on a uart where currently it can be constantly either on or off
(CONFIG_MAGIC_SYSRQ_SERIAL), see the last patch:
"serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE"
But to do that, I had to add uart_try_toggle_sysrq() and I didn't want
to bloat serial_core.h even more. So, I did cleanup by removing
SUPPORT_SYSRQ resulting in a nice diff-stat and lesser ifdeffery.
Most patches are one-liners, I decided to keep them separated per-driver
to let reviewers easier follow the purpose.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Vasiliy Khoruzhick <vasilykh@arista.com>
Cc: linux-serial@vger.kernel.org
Dmitry Safonov (58):
sysrq: Remove sysrq_handler_registered
serial: Move sysrq members above
serial_core: Un-ifdef sysrq SUPPORT_SYSRQ
tty/serial: Migrate aspeed_vuart to use has_sysrq
tty/serial: Migrate 8250_fsl to use has_sysrq
tty/serial: Migrate bcm63xx_uart to use has_sysrq
tty/serial: Migrate 8250_omap to use has_sysrq
tty/serial: Migrate 8250_port to use has_sysrq
tty/serial: Migrate amba-pl01* to use has_sysrq
tty/serial: Migrate apbuart to use has_sysrq
tty/serial: Migrate arc_uart to use has_sysrq
tty/serial: Migrate atmel_serial to use has_sysrq
tty/serial: Migrate clps711x to use has_sysrq
tty/serial: Migrate cpm_uart to use has_sysrq
tty/serial: Migrate dz to use has_sysrq
tty/serial: Migrate efm32-uart to use has_sysrq
tty/serial: Migrate fsl_linflexuart to use has_sysrq
tty/serial: Migrate fsl_lpuart to use has_sysrq
tty/serial: Migrate imx to use has_sysrq
tty/serial: Migrate ip22zilog to use has_sysrq
tty/serial: Migrate meson_uart to use has_sysrq
tty/serial: Migrate milbeaut_usio to use has_sysrq
tty/serial: Migrate mpc52xx_uart to use has_sysrq
tty/serial: Don't zero port->sysrq
tty/serial: Migrate msm_serial to use has_sysrq
tty/serial: Migrate mux to use has_sysrq
tty/serial: Migrate mxs-auart to use has_sysrq
tty/serial: Migrate omap-serial to use has_sysrq
tty/serial: Migrate pch_uart to use has_sysrq
tty/serial: Don't check port->sysrq
tty/serial: Migrate pmac_zilog to use has_sysrq
tty/serial: Migrate pnx8xxx_uart to use has_sysrq
serial/f81534: Don't check port->sysrq
tty/serial: Migrate pxa to use has_sysrq
tty/serial: Migrate qcom_geni_serial to use has_sysrq
tty/serial: Migrate sa1100 to use has_sysrq
tty/serial: Migrate samsung_tty to use has_sysrq
tty/serial: Migrate sb1250-duart to use has_sysrq
tty/serial: Migrate sccnxp to use has_sysrq
tty/serial: Migrate serial_txx9 to use has_sysrq
tty/serial: Migrate sh-sci to use has_sysrq
tty/serial: Migrate sprd_serial to use has_sysrq
tty/serial: Migrate st-asc to use has_sysrq
tty/serial: Migrate stm32-usart to use has_sysrq
tty/serial: Migrate sunhv to use has_sysrq
tty/serial: Migrate sunsab to use has_sysrq
tty/serial: Migrate sunsu to use has_sysrq
tty/serial: Migrate sunzilog to use has_sysrq
serial/ucc_uart: Remove ifdef SUPPORT_SYSRQ
tty/serial: Migrate vr41xx_siu to use has_sysrq
tty/serial: Migrate vt8500_serial to use has_sysrq
tty/serial: Migrate xilinx_uartps to use has_sysrq
tty/serial: Migrate zs to use has_sysrq
serial_core: Remove SUPPORT_SYSRQ ifdeffery
usb/serial: Don't handle break when CONFIG_MAGIC_SYSRQ is disabled
serial_core: Move sysrq functions from header file
sysctl/sysrq: Remove __sysrq_enabled copy
serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE
arch/powerpc/kernel/legacy_serial.c | 4 +-
drivers/tty/serial/8250/8250_aspeed_vuart.c | 5 +-
drivers/tty/serial/8250/8250_fsl.c | 4 -
drivers/tty/serial/8250/8250_of.c | 4 +-
drivers/tty/serial/8250/8250_omap.c | 5 +-
drivers/tty/serial/8250/8250_port.c | 5 +-
drivers/tty/serial/amba-pl010.c | 5 +-
drivers/tty/serial/amba-pl011.c | 6 +-
drivers/tty/serial/apbuart.c | 5 +-
drivers/tty/serial/arc_uart.c | 5 +-
drivers/tty/serial/atmel_serial.c | 9 +-
drivers/tty/serial/bcm63xx_uart.c | 5 +-
drivers/tty/serial/clps711x.c | 5 +-
drivers/tty/serial/cpm_uart/cpm_uart_core.c | 9 +-
drivers/tty/serial/dz.c | 5 +-
drivers/tty/serial/efm32-uart.c | 5 +-
drivers/tty/serial/fsl_linflexuart.c | 8 +-
drivers/tty/serial/fsl_lpuart.c | 9 +-
drivers/tty/serial/imx.c | 7 +-
drivers/tty/serial/ip22zilog.c | 7 +-
drivers/tty/serial/meson_uart.c | 5 +-
drivers/tty/serial/milbeaut_usio.c | 5 +-
drivers/tty/serial/mpc52xx_uart.c | 11 +-
drivers/tty/serial/msm_serial.c | 5 +-
drivers/tty/serial/mux.c | 5 +-
drivers/tty/serial/mxs-auart.c | 5 +-
drivers/tty/serial/omap-serial.c | 5 +-
drivers/tty/serial/pch_uart.c | 12 +-
drivers/tty/serial/pmac_zilog.c | 5 +-
drivers/tty/serial/pnx8xxx_uart.c | 7 +-
drivers/tty/serial/pxa.c | 5 +-
drivers/tty/serial/qcom_geni_serial.c | 5 +-
drivers/tty/serial/sa1100.c | 7 +-
drivers/tty/serial/samsung_tty.c | 5 +-
drivers/tty/serial/sb1250-duart.c | 5 +-
drivers/tty/serial/sccnxp.c | 5 +-
drivers/tty/serial/serial_core.c | 123 ++++++++++++++++++++
drivers/tty/serial/serial_txx9.c | 5 +-
drivers/tty/serial/sh-sci.c | 10 +-
drivers/tty/serial/sprd_serial.c | 5 +-
drivers/tty/serial/st-asc.c | 5 +-
drivers/tty/serial/stm32-usart.c | 5 +-
drivers/tty/serial/sunhv.c | 5 +-
drivers/tty/serial/sunsab.c | 5 +-
drivers/tty/serial/sunsu.c | 5 +-
drivers/tty/serial/sunzilog.c | 6 +-
drivers/tty/serial/ucc_uart.c | 2 -
drivers/tty/serial/vr41xx_siu.c | 5 +-
drivers/tty/serial/vt8500_serial.c | 5 +-
drivers/tty/serial/xilinx_uartps.c | 5 +-
drivers/tty/serial/zs.c | 5 +-
drivers/tty/sysrq.c | 16 +--
drivers/usb/serial/f81534.c | 6 +-
drivers/usb/serial/generic.c | 10 +-
include/linux/serial_core.h | 92 ++-------------
include/linux/sysrq.h | 1 +
kernel/sysctl.c | 41 ++++---
lib/Kconfig.debug | 8 ++
58 files changed, 238 insertions(+), 346 deletions(-)
--
2.24.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 05/58] tty/serial: Migrate 8250_fsl to use has_sysrq
2019-12-13 0:05 [PATCH 00/58] serial/sysrq: Cleanup ifdeffery Dmitry Safonov
@ 2019-12-13 0:06 ` Dmitry Safonov
2019-12-13 0:06 ` [PATCH 31/58] tty/serial: Migrate pmac_zilog " Dmitry Safonov
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Dmitry Safonov @ 2019-12-13 0:06 UTC (permalink / raw)
To: linux-kernel
Cc: Vasiliy Khoruzhick, Dmitry Safonov, Greg Kroah-Hartman,
Dmitry Safonov, Paul Mackerras, linux-serial, Jiri Slaby,
linuxppc-dev
The SUPPORT_SYSRQ ifdeffery is not nice as:
- May create misunderstanding about sizeof(struct uart_port) between
different objects
- Prevents moving functions from serial_core.h
- Reduces readability (well, it's ifdeffery - it's hard to follow)
In order to remove SUPPORT_SYSRQ, has_sysrq variable has been added.
Initialise it in driver's probe and remove ifdeffery.
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Dmitry Safonov <dima@arista.com>
---
arch/powerpc/kernel/legacy_serial.c | 4 +++-
drivers/tty/serial/8250/8250_fsl.c | 4 ----
drivers/tty/serial/8250/8250_of.c | 4 +++-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/kernel/legacy_serial.c b/arch/powerpc/kernel/legacy_serial.c
index 7cea5978f21f..f061e06e9f51 100644
--- a/arch/powerpc/kernel/legacy_serial.c
+++ b/arch/powerpc/kernel/legacy_serial.c
@@ -479,8 +479,10 @@ static void __init fixup_port_irq(int index,
port->irq = virq;
#ifdef CONFIG_SERIAL_8250_FSL
- if (of_device_is_compatible(np, "fsl,ns16550"))
+ if (of_device_is_compatible(np, "fsl,ns16550")) {
port->handle_irq = fsl8250_handle_irq;
+ port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);
+ }
#endif
}
diff --git a/drivers/tty/serial/8250/8250_fsl.c b/drivers/tty/serial/8250/8250_fsl.c
index aa0e216d5ead..0d0c80905c58 100644
--- a/drivers/tty/serial/8250/8250_fsl.c
+++ b/drivers/tty/serial/8250/8250_fsl.c
@@ -1,8 +1,4 @@
// SPDX-License-Identifier: GPL-2.0
-#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
-#define SUPPORT_SYSRQ
-#endif
-
#include <linux/serial_reg.h>
#include <linux/serial_8250.h>
diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c
index 92fbf46ce3bd..531ad67395e0 100644
--- a/drivers/tty/serial/8250/8250_of.c
+++ b/drivers/tty/serial/8250/8250_of.c
@@ -222,8 +222,10 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
if (IS_ENABLED(CONFIG_SERIAL_8250_FSL) &&
(of_device_is_compatible(np, "fsl,ns16550") ||
- of_device_is_compatible(np, "fsl,16550-FIFO64")))
+ of_device_is_compatible(np, "fsl,16550-FIFO64"))) {
port->handle_irq = fsl8250_handle_irq;
+ port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);
+ }
return 0;
err_unprepare:
--
2.24.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 31/58] tty/serial: Migrate pmac_zilog to use has_sysrq
2019-12-13 0:05 [PATCH 00/58] serial/sysrq: Cleanup ifdeffery Dmitry Safonov
2019-12-13 0:06 ` [PATCH 05/58] tty/serial: Migrate 8250_fsl to use has_sysrq Dmitry Safonov
@ 2019-12-13 0:06 ` Dmitry Safonov
2019-12-13 0:06 ` [PATCH 49/58] serial/ucc_uart: Remove ifdef SUPPORT_SYSRQ Dmitry Safonov
2019-12-13 5:47 ` [PATCH 00/58] serial/sysrq: Cleanup ifdeffery Christophe Leroy
3 siblings, 0 replies; 6+ messages in thread
From: Dmitry Safonov @ 2019-12-13 0:06 UTC (permalink / raw)
To: linux-kernel
Cc: Vasiliy Khoruzhick, Dmitry Safonov, Greg Kroah-Hartman,
Dmitry Safonov, Paul Mackerras, linux-serial, Jiri Slaby,
linuxppc-dev
The SUPPORT_SYSRQ ifdeffery is not nice as:
- May create misunderstanding about sizeof(struct uart_port) between
different objects
- Prevents moving functions from serial_core.h
- Reduces readability (well, it's ifdeffery - it's hard to follow)
In order to remove SUPPORT_SYSRQ, has_sysrq variable has been added.
Initialise it in driver's probe and remove ifdeffery.
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Dmitry Safonov <dima@arista.com>
---
drivers/tty/serial/pmac_zilog.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c
index bcb5bf70534e..ba65a3bbd72a 100644
--- a/drivers/tty/serial/pmac_zilog.c
+++ b/drivers/tty/serial/pmac_zilog.c
@@ -61,10 +61,6 @@
#define of_machine_is_compatible(x) (0)
#endif
-#if defined (CONFIG_SERIAL_PMACZILOG_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
-#define SUPPORT_SYSRQ
-#endif
-
#include <linux/serial.h>
#include <linux/serial_core.h>
@@ -1721,6 +1717,7 @@ static int __init pmz_init_port(struct uart_pmac_port *uap)
uap->control_reg = uap->port.membase;
uap->data_reg = uap->control_reg + 4;
uap->port_type = 0;
+ uap->port.has_sysrq = IS_ENABLED(CONFIG_SERIAL_PMACZILOG_CONSOLE);
pmz_convert_to_zs(uap, CS8, 0, 9600);
--
2.24.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 49/58] serial/ucc_uart: Remove ifdef SUPPORT_SYSRQ
2019-12-13 0:05 [PATCH 00/58] serial/sysrq: Cleanup ifdeffery Dmitry Safonov
2019-12-13 0:06 ` [PATCH 05/58] tty/serial: Migrate 8250_fsl to use has_sysrq Dmitry Safonov
2019-12-13 0:06 ` [PATCH 31/58] tty/serial: Migrate pmac_zilog " Dmitry Safonov
@ 2019-12-13 0:06 ` Dmitry Safonov
2019-12-13 5:47 ` [PATCH 00/58] serial/sysrq: Cleanup ifdeffery Christophe Leroy
3 siblings, 0 replies; 6+ messages in thread
From: Dmitry Safonov @ 2019-12-13 0:06 UTC (permalink / raw)
To: linux-kernel
Cc: Vasiliy Khoruzhick, Timur Tabi, Dmitry Safonov,
Greg Kroah-Hartman, Dmitry Safonov, linux-serial, Jiri Slaby,
linuxppc-dev
ucc_uart doesn't seem to support console over itself, so maybe it can
be deleted with uart_handle_sysrq_char() from the file.
Cc: Timur Tabi <timur@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Dmitry Safonov <dima@arista.com>
---
drivers/tty/serial/ucc_uart.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index a0555ae2b1ef..ff7784047156 100644
--- a/drivers/tty/serial/ucc_uart.c
+++ b/drivers/tty/serial/ucc_uart.c
@@ -551,9 +551,7 @@ static void qe_uart_int_rx(struct uart_qe_port *qe_port)
/* Overrun does not affect the current character ! */
if (status & BD_SC_OV)
tty_insert_flip_char(tport, 0, TTY_OVERRUN);
-#ifdef SUPPORT_SYSRQ
port->sysrq = 0;
-#endif
goto error_return;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 00/58] serial/sysrq: Cleanup ifdeffery
2019-12-13 0:05 [PATCH 00/58] serial/sysrq: Cleanup ifdeffery Dmitry Safonov
` (2 preceding siblings ...)
2019-12-13 0:06 ` [PATCH 49/58] serial/ucc_uart: Remove ifdef SUPPORT_SYSRQ Dmitry Safonov
@ 2019-12-13 5:47 ` Christophe Leroy
2019-12-13 16:41 ` Dmitry Safonov
3 siblings, 1 reply; 6+ messages in thread
From: Christophe Leroy @ 2019-12-13 5:47 UTC (permalink / raw)
To: Dmitry Safonov, linux-kernel
Cc: Alexandre Belloni, linux-aspeed, Dmitry Safonov, Bjorn Andersson,
Paul Mackerras, Maciej W. Rozycki, sparclinux, Fabio Estevam,
linux-stm32, Alexandre Torgue, Vasiliy Khoruzhick,
Alexander Shiyan, Kevin Hilman, Russell King, Ludovic Desroches,
Andy Gross, bcm-kernel-feedback-list, Joel Stanley, linux-serial,
Jiri Slaby, Orson Zhai, Iurii Zaikin, NXP Linux Team,
Michal Simek, Kees Cook, linux-arm-msm, Sascha Hauer,
Uwe Kleine-König, Johan Hovold, Baolin Wang,
Florian Fainelli, linux-amlogic, Pengutronix Kernel Team,
linux-arm-kernel, Timur Tabi, Andrew Jeffery, Greg Kroah-Hartman,
linuxppc-dev, Patrice Chotard, Tony Prisk, Richard Genoud,
Luis Chamberlain, Vineet Gupta, Maxime Coquelin, Chunyan Zhang,
linux-fsdevel, Shawn Guo, David S. Miller
Le 13/12/2019 à 01:05, Dmitry Safonov a écrit :
> The original purpose of the patches set was to add a way to enable
> sysrq on a uart where currently it can be constantly either on or off
> (CONFIG_MAGIC_SYSRQ_SERIAL), see the last patch:
> "serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE"
>
> But to do that, I had to add uart_try_toggle_sysrq() and I didn't want
> to bloat serial_core.h even more. So, I did cleanup by removing
> SUPPORT_SYSRQ resulting in a nice diff-stat and lesser ifdeffery.
>
> Most patches are one-liners, I decided to keep them separated per-driver
> to let reviewers easier follow the purpose.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: Vasiliy Khoruzhick <vasilykh@arista.com>
> Cc: linux-serial@vger.kernel.org
>
> Dmitry Safonov (58):
> sysrq: Remove sysrq_handler_registered
> serial: Move sysrq members above
> serial_core: Un-ifdef sysrq SUPPORT_SYSRQ
> tty/serial: Migrate aspeed_vuart to use has_sysrq
> tty/serial: Migrate 8250_fsl to use has_sysrq
> tty/serial: Migrate bcm63xx_uart to use has_sysrq
> tty/serial: Migrate 8250_omap to use has_sysrq
> tty/serial: Migrate 8250_port to use has_sysrq
> tty/serial: Migrate amba-pl01* to use has_sysrq
> tty/serial: Migrate apbuart to use has_sysrq
> tty/serial: Migrate arc_uart to use has_sysrq
> tty/serial: Migrate atmel_serial to use has_sysrq
> tty/serial: Migrate clps711x to use has_sysrq
> tty/serial: Migrate cpm_uart to use has_sysrq
> tty/serial: Migrate dz to use has_sysrq
> tty/serial: Migrate efm32-uart to use has_sysrq
> tty/serial: Migrate fsl_linflexuart to use has_sysrq
> tty/serial: Migrate fsl_lpuart to use has_sysrq
> tty/serial: Migrate imx to use has_sysrq
> tty/serial: Migrate ip22zilog to use has_sysrq
> tty/serial: Migrate meson_uart to use has_sysrq
> tty/serial: Migrate milbeaut_usio to use has_sysrq
> tty/serial: Migrate mpc52xx_uart to use has_sysrq
> tty/serial: Don't zero port->sysrq
> tty/serial: Migrate msm_serial to use has_sysrq
> tty/serial: Migrate mux to use has_sysrq
> tty/serial: Migrate mxs-auart to use has_sysrq
> tty/serial: Migrate omap-serial to use has_sysrq
> tty/serial: Migrate pch_uart to use has_sysrq
> tty/serial: Don't check port->sysrq
> tty/serial: Migrate pmac_zilog to use has_sysrq
> tty/serial: Migrate pnx8xxx_uart to use has_sysrq
> serial/f81534: Don't check port->sysrq
> tty/serial: Migrate pxa to use has_sysrq
> tty/serial: Migrate qcom_geni_serial to use has_sysrq
> tty/serial: Migrate sa1100 to use has_sysrq
> tty/serial: Migrate samsung_tty to use has_sysrq
> tty/serial: Migrate sb1250-duart to use has_sysrq
> tty/serial: Migrate sccnxp to use has_sysrq
> tty/serial: Migrate serial_txx9 to use has_sysrq
> tty/serial: Migrate sh-sci to use has_sysrq
> tty/serial: Migrate sprd_serial to use has_sysrq
> tty/serial: Migrate st-asc to use has_sysrq
> tty/serial: Migrate stm32-usart to use has_sysrq
> tty/serial: Migrate sunhv to use has_sysrq
> tty/serial: Migrate sunsab to use has_sysrq
> tty/serial: Migrate sunsu to use has_sysrq
> tty/serial: Migrate sunzilog to use has_sysrq
> serial/ucc_uart: Remove ifdef SUPPORT_SYSRQ
> tty/serial: Migrate vr41xx_siu to use has_sysrq
> tty/serial: Migrate vt8500_serial to use has_sysrq
> tty/serial: Migrate xilinx_uartps to use has_sysrq
> tty/serial: Migrate zs to use has_sysrq
> serial_core: Remove SUPPORT_SYSRQ ifdeffery
> usb/serial: Don't handle break when CONFIG_MAGIC_SYSRQ is disabled
> serial_core: Move sysrq functions from header file
> sysctl/sysrq: Remove __sysrq_enabled copy
> serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE
powerpc patchwork didn't get the full series, see
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=148198
Can't find them on linux-serial patchwork either
(https://patches.linaro.org/project/linux-serial/list/)
It is impossible to review/test powerpc bits without the first patches
of the series, where can the entire series be found ?
Christophe
>
> arch/powerpc/kernel/legacy_serial.c | 4 +-
> drivers/tty/serial/8250/8250_aspeed_vuart.c | 5 +-
> drivers/tty/serial/8250/8250_fsl.c | 4 -
> drivers/tty/serial/8250/8250_of.c | 4 +-
> drivers/tty/serial/8250/8250_omap.c | 5 +-
> drivers/tty/serial/8250/8250_port.c | 5 +-
> drivers/tty/serial/amba-pl010.c | 5 +-
> drivers/tty/serial/amba-pl011.c | 6 +-
> drivers/tty/serial/apbuart.c | 5 +-
> drivers/tty/serial/arc_uart.c | 5 +-
> drivers/tty/serial/atmel_serial.c | 9 +-
> drivers/tty/serial/bcm63xx_uart.c | 5 +-
> drivers/tty/serial/clps711x.c | 5 +-
> drivers/tty/serial/cpm_uart/cpm_uart_core.c | 9 +-
> drivers/tty/serial/dz.c | 5 +-
> drivers/tty/serial/efm32-uart.c | 5 +-
> drivers/tty/serial/fsl_linflexuart.c | 8 +-
> drivers/tty/serial/fsl_lpuart.c | 9 +-
> drivers/tty/serial/imx.c | 7 +-
> drivers/tty/serial/ip22zilog.c | 7 +-
> drivers/tty/serial/meson_uart.c | 5 +-
> drivers/tty/serial/milbeaut_usio.c | 5 +-
> drivers/tty/serial/mpc52xx_uart.c | 11 +-
> drivers/tty/serial/msm_serial.c | 5 +-
> drivers/tty/serial/mux.c | 5 +-
> drivers/tty/serial/mxs-auart.c | 5 +-
> drivers/tty/serial/omap-serial.c | 5 +-
> drivers/tty/serial/pch_uart.c | 12 +-
> drivers/tty/serial/pmac_zilog.c | 5 +-
> drivers/tty/serial/pnx8xxx_uart.c | 7 +-
> drivers/tty/serial/pxa.c | 5 +-
> drivers/tty/serial/qcom_geni_serial.c | 5 +-
> drivers/tty/serial/sa1100.c | 7 +-
> drivers/tty/serial/samsung_tty.c | 5 +-
> drivers/tty/serial/sb1250-duart.c | 5 +-
> drivers/tty/serial/sccnxp.c | 5 +-
> drivers/tty/serial/serial_core.c | 123 ++++++++++++++++++++
> drivers/tty/serial/serial_txx9.c | 5 +-
> drivers/tty/serial/sh-sci.c | 10 +-
> drivers/tty/serial/sprd_serial.c | 5 +-
> drivers/tty/serial/st-asc.c | 5 +-
> drivers/tty/serial/stm32-usart.c | 5 +-
> drivers/tty/serial/sunhv.c | 5 +-
> drivers/tty/serial/sunsab.c | 5 +-
> drivers/tty/serial/sunsu.c | 5 +-
> drivers/tty/serial/sunzilog.c | 6 +-
> drivers/tty/serial/ucc_uart.c | 2 -
> drivers/tty/serial/vr41xx_siu.c | 5 +-
> drivers/tty/serial/vt8500_serial.c | 5 +-
> drivers/tty/serial/xilinx_uartps.c | 5 +-
> drivers/tty/serial/zs.c | 5 +-
> drivers/tty/sysrq.c | 16 +--
> drivers/usb/serial/f81534.c | 6 +-
> drivers/usb/serial/generic.c | 10 +-
> include/linux/serial_core.h | 92 ++-------------
> include/linux/sysrq.h | 1 +
> kernel/sysctl.c | 41 ++++---
> lib/Kconfig.debug | 8 ++
> 58 files changed, 238 insertions(+), 346 deletions(-)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 00/58] serial/sysrq: Cleanup ifdeffery
2019-12-13 5:47 ` [PATCH 00/58] serial/sysrq: Cleanup ifdeffery Christophe Leroy
@ 2019-12-13 16:41 ` Dmitry Safonov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Safonov @ 2019-12-13 16:41 UTC (permalink / raw)
To: Christophe Leroy, linux-kernel
Cc: Alexandre Belloni, linux-aspeed, Dmitry Safonov, Bjorn Andersson,
Paul Mackerras, Maciej W. Rozycki, sparclinux, Fabio Estevam,
linux-stm32, Alexandre Torgue, Vasiliy Khoruzhick,
Alexander Shiyan, Kevin Hilman, Russell King, Ludovic Desroches,
Andy Gross, bcm-kernel-feedback-list, Joel Stanley, linux-serial,
Jiri Slaby, Orson Zhai, Iurii Zaikin, NXP Linux Team,
Michal Simek, Kees Cook, linux-arm-msm, Sascha Hauer,
Uwe Kleine-König, Johan Hovold, Baolin Wang,
Florian Fainelli, linux-amlogic, Pengutronix Kernel Team,
linux-arm-kernel, Timur Tabi, Andrew Jeffery, Greg Kroah-Hartman,
linuxppc-dev, Patrice Chotard, Tony Prisk, Richard Genoud,
Luis Chamberlain, Vineet Gupta, Maxime Coquelin, Chunyan Zhang,
linux-fsdevel, Shawn Guo, David S. Miller
Hi Christophe,
On 12/13/19 5:47 AM, Christophe Leroy wrote:
> Le 13/12/2019 à 01:05, Dmitry Safonov a écrit :
[..]
>
> powerpc patchwork didn't get the full series, see
> https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=148198
Yes, I was under impression that architecture mail-lists want related
patches. But now I see that from the patchwork point of view it's better
to have the whole series in inbox.
> Can't find them on linux-serial patchwork either
> (https://patches.linaro.org/project/linux-serial/list/)
I'm not sure - maybe the frequency of checking is low?
I see all patches in linux-serial ml:
https://marc.info/?l=linux-serial&r=1&b=201912&w=2
> It is impossible to review/test powerpc bits without the first patches
> of the series, where can the entire series be found ?
Sorry for the inconvenience.
I can resend without Cc'ing all people just to ppc mail-list if that
works for you. Or you can clone it directly from my github:
https://github.com/0x7f454c46/linux/tree/sysrq-serial-seq-v1
Thanks,
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-13 21:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 0:05 [PATCH 00/58] serial/sysrq: Cleanup ifdeffery Dmitry Safonov
2019-12-13 0:06 ` [PATCH 05/58] tty/serial: Migrate 8250_fsl to use has_sysrq Dmitry Safonov
2019-12-13 0:06 ` [PATCH 31/58] tty/serial: Migrate pmac_zilog " Dmitry Safonov
2019-12-13 0:06 ` [PATCH 49/58] serial/ucc_uart: Remove ifdef SUPPORT_SYSRQ Dmitry Safonov
2019-12-13 5:47 ` [PATCH 00/58] serial/sysrq: Cleanup ifdeffery Christophe Leroy
2019-12-13 16:41 ` Dmitry Safonov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).