From: Hari Bathini <hbathini@linux.ibm.com>
To: Michal Suchanek <msuchanek@suse.de>, linuxppc-dev@lists.ozlabs.org
Cc: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] powerpc/fadump: when fadump is supported register the fadump sysfs files.
Date: Fri, 8 Nov 2019 17:08:58 +0530 [thread overview]
Message-ID: <119d91aa-57d4-00db-054c-60769b309c8d@linux.ibm.com> (raw)
In-Reply-To: <20191107164757.15140-1-msuchanek@suse.de>
On 07/11/19 10:17 PM, Michal Suchanek wrote:
> Currently it is not possible to distinguish the case when fadump is
> supported by firmware and disabled in kernel and completely unsupported
> using the kernel sysfs interface. User can investigate the devicetree
> but it is more reasonable to provide sysfs files in case we get some
> fadumpv2 in the future.
>
> With this patch sysfs files are available whenever fadump is supported
> by firmware.
>
> There is duplicate message about lack of support by firmware in
> fadump_reserve_mem and setup_fadump. Remove the duplicate message in
> setup_fadump.
Thanks for doing this, Michal.
Exporting the node will be helpful in finding if FADump is supported,
given FADump is now supported on two different platforms...
Reviewed-by: Hari Bathini <hbathini@linux.ibm.com>
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
> v2: move the sysfs initialization earlier to avoid condition nesting
> v3: remove duplicate message
> ---
> arch/powerpc/kernel/fadump.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
> index ed59855430b9..ff0114aeba9b 100644
> --- a/arch/powerpc/kernel/fadump.c
> +++ b/arch/powerpc/kernel/fadump.c
> @@ -1466,16 +1466,15 @@ static void fadump_init_files(void)
> */
> int __init setup_fadump(void)
> {
> - if (!fw_dump.fadump_enabled)
> - return 0;
> -
> - if (!fw_dump.fadump_supported) {
> - printk(KERN_ERR "Firmware-assisted dump is not supported on"
> - " this hardware\n");
> + if (!fw_dump.fadump_supported)
> return 0;
> - }
>
> + fadump_init_files();
> fadump_show_config();
> +
> + if (!fw_dump.fadump_enabled)
> + return 1;
> +
> /*
> * If dump data is available then see if it is valid and prepare for
> * saving it to the disk.
> @@ -1492,8 +1491,6 @@ int __init setup_fadump(void)
> else if (fw_dump.reserve_dump_area_size)
> fw_dump.ops->fadump_init_mem_struct(&fw_dump);
>
> - fadump_init_files();
> -
> return 1;
> }
> subsys_initcall(setup_fadump);
>
--
- Hari
next prev parent reply other threads:[~2019-11-08 11:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 7:54 [PATCH v2 rebased] powerpc/fadump: when fadump is supported register the fadump sysfs files Michal Suchanek
2019-10-23 17:56 ` [PATCH] powerpc/fadump: Remove duplicate message Michal Suchanek
2019-10-24 10:38 ` Hari Bathini
2019-10-24 11:16 ` Michal Suchánek
2019-11-07 16:42 ` Michal Suchánek
2019-11-07 16:47 ` [PATCH v3] powerpc/fadump: when fadump is supported register the fadump sysfs files Michal Suchanek
2019-11-08 11:38 ` Hari Bathini [this message]
2019-11-14 9:08 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=119d91aa-57d4-00db-054c-60769b309c8d@linux.ibm.com \
--to=hbathini@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=msuchanek@suse.de \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).