linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: <b35362@freescale.com>
To: <dwmw2@infradead.org>, <Artem.Bityutskiy@nokia.com>
Cc: Jerry Huang <Chang-Ming.Huang@freescale.com>,
	Liu Shuo <b35362@freescale.com>,
	linux-kernel@vger.kernel.org,
	Tang Yuantian <b29983@freescale.com>,
	linux-mtd@lists.infradead.org, scottwood@freescale.com,
	akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 2/3] mtd/nand : set Nand flash page address to FBAR and FPAR correctly
Date: Tue, 15 Nov 2011 17:29:14 +0800	[thread overview]
Message-ID: <1321349355-1639-2-git-send-email-b35362@freescale.com> (raw)
In-Reply-To: <1321349355-1639-1-git-send-email-b35362@freescale.com>

From: Liu Shuo <b35362@freescale.com>

If we use the Nand flash chip whose number of pages in a block is greater
than 64(for large page), we must treat the low bit of FBAR as being the
high bit of the page address due to the limitation of FCM, it simply uses
the low 6-bits (for large page) of the combined block/page address as the
FPAR component, rather than considering the actual block size.

Signed-off-by: Liu Shuo <b35362@freescale.com>
Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
Signed-off-by: Tang Yuantian <b29983@freescale.com>
Signed-off-by: Li Yang <leoli@freescale.com>
---
 drivers/mtd/nand/fsl_elbc_nand.c |   13 ++++++++++---
 1 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
index 1bfcdef..c2c231b 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -166,15 +166,22 @@ static void set_addr(struct mtd_info *mtd, int column, int page_addr, int oob)
 
 	elbc_fcm_ctrl->page = page_addr;
 
-	out_be32(&lbc->fbar,
-		 page_addr >> (chip->phys_erase_shift - chip->page_shift));
-
 	if (priv->page_size) {
+		/*
+		 * large page size chip : FPAR[PI] save the lowest 6 bits,
+		 *                        FBAR[BLK] save the other bits.
+		 */
+		out_be32(&lbc->fbar, page_addr >> 6);
 		out_be32(&lbc->fpar,
 			 ((page_addr << FPAR_LP_PI_SHIFT) & FPAR_LP_PI) |
 			 (oob ? FPAR_LP_MS : 0) | column);
 		buf_num = (page_addr & 1) << 2;
 	} else {
+		/*
+		 * small page size chip : FPAR[PI] save the lowest 5 bits,
+		 *                        FBAR[BLK] save the other bits.
+		 */
+		out_be32(&lbc->fbar, page_addr >> 5);
 		out_be32(&lbc->fpar,
 			 ((page_addr << FPAR_SP_PI_SHIFT) & FPAR_SP_PI) |
 			 (oob ? FPAR_SP_MS : 0) | column);
-- 
1.7.1

  reply	other threads:[~2011-11-15 10:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15  9:29 [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c b35362
2011-11-15  9:29 ` b35362 [this message]
2011-11-15  9:29   ` [PATCH v3 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip b35362
2011-11-22 21:04     ` Artem Bityutskiy
2011-11-22 23:55     ` Scott Wood
2011-11-23  1:56       ` LiuShuo
2011-11-23 12:14       ` LiuShuo
2011-11-28 21:41         ` Scott Wood
2011-11-17 22:13   ` [PATCH 2/3] mtd/nand : set Nand flash page address to FBAR and FPAR correctly Artem Bityutskiy
2011-11-18  2:08     ` LiuShuo
2011-11-22 21:05       ` Artem Bityutskiy
2011-11-15 11:26 ` [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c Jenkins, Clive
2011-11-15 13:10   ` David Woodhouse
2011-11-15 14:42     ` Jenkins, Clive
2011-11-15 15:05       ` David Woodhouse
2011-11-15 14:51     ` David Laight
2011-11-17 22:08 ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321349355-1639-2-git-send-email-b35362@freescale.com \
    --to=b35362@freescale.com \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=Chang-Ming.Huang@freescale.com \
    --cc=akpm@linux-foundation.org \
    --cc=b29983@freescale.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).