From: Scott Wood <scottwood@freescale.com>
To: LiuShuo <b35362@freescale.com>
Cc: Artem.Bityutskiy@nokia.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Liu Shuo <Shuo.Liu@freescale.com>,
Shengzhou Liu <Shengzhou.Liu@freescale.com>,
linux-mtd@lists.infradead.org, akpm@linux-foundation.org,
dwmw2@infradead.org
Subject: Re: [PATCH v3 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip
Date: Mon, 28 Nov 2011 15:41:16 -0600 [thread overview]
Message-ID: <4ED3FFFC.50807@freescale.com> (raw)
In-Reply-To: <4ECCE393.2030600@freescale.com>
On 11/23/2011 06:14 AM, LiuShuo wrote:
> =E4=BA=8E 2011=E5=B9=B411=E6=9C=8823=E6=97=A5 07:55, Scott Wood =E5=86=99=
=E9=81=93:
>> On 11/15/2011 03:29 AM, b35362@freescale.com wrote:
>>> From: Liu Shuo<b35362@freescale.com>
>>>
>>> - if (elbc_fcm_ctrl->oob || elbc_fcm_ctrl->column !=3D 0 ||
>>> + if (elbc_fcm_ctrl->column>=3D mtd->writesize) {
>>> + /* write oob */
>>> + if (priv->page_size> 1) {
>>> + /* when pagesize of chip is greater than 2048,
>>> + * we have to write full page to write spare
>>> + * region, so we fill '0xff' to main region
>>> + * and some bytes of spare region which we
>>> + * don't want to rewrite.
>>> + * (write '1' won't change the original value)
>>> + */
>>> + memset(elbc_fcm_ctrl->buffer, 0xff,
>>> + elbc_fcm_ctrl->column);
>> I don't like relying on this -- can we use RNDIN instead to do a
>> discontiguous write?
>>
> I have no better way to implement it now.
> Some chips have 'NOP' limitation, so I don't use the FIR_OP_UA to do a
> oob write.
I don't think each RNDIN counts separately against NOP (someone correct
me if I'm wrong). You're writing discontiguous regions of the page in
one operation.
-Scott
next prev parent reply other threads:[~2011-11-28 21:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 9:29 [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c b35362
2011-11-15 9:29 ` [PATCH 2/3] mtd/nand : set Nand flash page address to FBAR and FPAR correctly b35362
2011-11-15 9:29 ` [PATCH v3 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip b35362
2011-11-22 21:04 ` Artem Bityutskiy
2011-11-22 23:55 ` Scott Wood
2011-11-23 1:56 ` LiuShuo
2011-11-23 12:14 ` LiuShuo
2011-11-28 21:41 ` Scott Wood [this message]
2011-11-17 22:13 ` [PATCH 2/3] mtd/nand : set Nand flash page address to FBAR and FPAR correctly Artem Bityutskiy
2011-11-18 2:08 ` LiuShuo
2011-11-22 21:05 ` Artem Bityutskiy
2011-11-15 11:26 ` [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c Jenkins, Clive
2011-11-15 13:10 ` David Woodhouse
2011-11-15 14:42 ` Jenkins, Clive
2011-11-15 15:05 ` David Woodhouse
2011-11-15 14:51 ` David Laight
2011-11-17 22:08 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED3FFFC.50807@freescale.com \
--to=scottwood@freescale.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=Shengzhou.Liu@freescale.com \
--cc=Shuo.Liu@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=b35362@freescale.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).