linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Jenkins, Clive" <Clive.Jenkins@xerox.com>
To: <b35362@freescale.com>, <dwmw2@infradead.org>,
	<Artem.Bityutskiy@nokia.com>
Cc: scottwood@freescale.com, linuxppc-dev@lists.ozlabs.org,
	akpm@linux-foundation.org, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: RE: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c
Date: Tue, 15 Nov 2011 11:26:06 -0000	[thread overview]
Message-ID: <929D3CED81F34E43887A393170D66FB9053A8C82@GBRSUN01MS002.eu.xerox.net> (raw)
In-Reply-To: <1321349355-1639-1-git-send-email-b35362@freescale.com>

> fix whitespaces,tabs coding style issue and ...

In my opinion this code was already correct, and would display correctly
at any TAB setting. This patch changes it so that it displays
incorrectly
at all TAB settings other than 8.

Example:

Correct:
<tabs>function(arg1,
<tabs><9spaces>arg2

Incorrect:
<tabs>function(arg1,
<tabs>< tab  > arg2

For any TAB setting other than 8, arg1 and arg2 no longer line up.

Clive

  parent reply	other threads:[~2011-11-15 11:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15  9:29 [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c b35362
2011-11-15  9:29 ` [PATCH 2/3] mtd/nand : set Nand flash page address to FBAR and FPAR correctly b35362
2011-11-15  9:29   ` [PATCH v3 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip b35362
2011-11-22 21:04     ` Artem Bityutskiy
2011-11-22 23:55     ` Scott Wood
2011-11-23  1:56       ` LiuShuo
2011-11-23 12:14       ` LiuShuo
2011-11-28 21:41         ` Scott Wood
2011-11-17 22:13   ` [PATCH 2/3] mtd/nand : set Nand flash page address to FBAR and FPAR correctly Artem Bityutskiy
2011-11-18  2:08     ` LiuShuo
2011-11-22 21:05       ` Artem Bityutskiy
2011-11-15 11:26 ` Jenkins, Clive [this message]
2011-11-15 13:10   ` [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c David Woodhouse
2011-11-15 14:42     ` Jenkins, Clive
2011-11-15 15:05       ` David Woodhouse
2011-11-15 14:51     ` David Laight
2011-11-17 22:08 ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=929D3CED81F34E43887A393170D66FB9053A8C82@GBRSUN01MS002.eu.xerox.net \
    --to=clive.jenkins@xerox.com \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=b35362@freescale.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).