* [RESEND PATCH v3 2/5] dt/powerpc/powernv: Use of_get_child_by_name to get a named child.
@ 2012-09-17 11:58 Srinivas KANDAGATLA
2012-09-18 1:32 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Srinivas KANDAGATLA @ 2012-09-17 11:58 UTC (permalink / raw)
To: benh
Cc: kgene.kim, srinivas.kandagatla, devicetree-discuss, broonie,
robherring2, ben-linux, linuxppc-dev
From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
As follow-up to "dt: introduce of_get_child_by_name to get child node by
name." patch, This patch removes some of the code duplication in the
driver by replacing it with of_get_child_by_name instead.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
---
arch/powerpc/platforms/powernv/opal.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index aaa0dba..fc7ae70 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -294,9 +294,9 @@ static int __init opal_init(void)
consoles = of_node_get(opal_node);
/* Register serial ports */
- for_each_child_of_node(consoles, np) {
- if (strcmp(np->name, "serial"))
- continue;
+ np = of_get_child_by_name(consoles, "serial");
+ if (np) {
+ of_node_put(np);
of_platform_device_create(np, NULL, NULL);
}
of_node_put(consoles);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH v3 2/5] dt/powerpc/powernv: Use of_get_child_by_name to get a named child.
2012-09-17 11:58 [RESEND PATCH v3 2/5] dt/powerpc/powernv: Use of_get_child_by_name to get a named child Srinivas KANDAGATLA
@ 2012-09-18 1:32 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2012-09-18 1:32 UTC (permalink / raw)
To: Srinivas KANDAGATLA
Cc: kgene.kim, devicetree-discuss, broonie, robherring2, ben-linux,
linuxppc-dev
On Mon, 2012-09-17 at 12:58 +0100, Srinivas KANDAGATLA wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> As follow-up to "dt: introduce of_get_child_by_name to get child node by
> name." patch, This patch removes some of the code duplication in the
> driver by replacing it with of_get_child_by_name instead.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> ---
> arch/powerpc/platforms/powernv/opal.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
> index aaa0dba..fc7ae70 100644
> --- a/arch/powerpc/platforms/powernv/opal.c
> +++ b/arch/powerpc/platforms/powernv/opal.c
> @@ -294,9 +294,9 @@ static int __init opal_init(void)
> consoles = of_node_get(opal_node);
>
> /* Register serial ports */
> - for_each_child_of_node(consoles, np) {
> - if (strcmp(np->name, "serial"))
> - continue;
> + np = of_get_child_by_name(consoles, "serial");
> + if (np) {
> + of_node_put(np);
> of_platform_device_create(np, NULL, NULL);
You mustn't drop the reference until after you've finished with np, as
you have written it the node could be freed before you call
of_platform_device_create().
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-18 1:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-17 11:58 [RESEND PATCH v3 2/5] dt/powerpc/powernv: Use of_get_child_by_name to get a named child Srinivas KANDAGATLA
2012-09-18 1:32 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).