* [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.
@ 2016-03-01 7:09 Zhao Qiang
2016-03-01 7:09 ` [PATCH v3 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
` (6 more replies)
0 siblings, 7 replies; 15+ messages in thread
From: Zhao Qiang @ 2016-03-01 7:09 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, xiaobo.xie, linux-kernel, devicetree,
linuxppc-dev, Zhao Qiang
Add IC, SI and SIRAM document of QE to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- Add interrupt-controller in Required properties
- delete address-cells and size-cells for qe-si and qe-siram
Changes for v3
- Add SoC specific caompatible strings to qe-si and qe-siram
.../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 ++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
index 4f89302..7ab21cb 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
@@ -69,6 +69,56 @@ Example:
};
};
+* Interrupt Controller (IC)
+
+Required properties:
+- compatible : should be "fsl,qe-ic".
+- reg : Address range of IC register set.
+- interrupts : interrupts generated by the device.
+- interrupt-controller : this device is a interrupt controller.
+
+Example:
+
+ qeic: interrupt-controller@80 {
+ interrupt-controller;
+ compatible = "fsl,qe-ic";
+ #address-cells = <0>;
+ #interrupt-cells = <1>;
+ reg = <0x80 0x80>;
+ interrupts = <95 2 0 0 94 2 0 0>; //high:79 low:78
+ };
+
+* Serial Interface Block (SI)
+
+The SI manages the routing of eight TDM lines to the QE block serial drivers
+, the MCC and the UCCs, for receive and transmit.
+
+Required properties:
+- compatible : should be "fsl,t1040-qe-si".
+- reg : Address range of SI register set.
+
+Example:
+
+ si1: si@700 {
+ compatible = "fsl,t1040-qe-si";
+ reg = <0x700 0x80>;
+ };
+
+* Serial Interface Block RAM(SIRAM)
+
+store the routing entries of SI
+
+Required properties:
+- compatible : should be "fsl,t1040-qe-siram".
+- reg : Address range of SI RAM.
+
+Example:
+
+ siram1: siram@1000 {
+ compatible = "fsl,t1040-qe-siram";
+ reg = <0x1000 0x800>;
+ };
+
* QE Firmware Node
This node defines a firmware binary that is embedded in the device tree, for
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 2/7] QE: Add ucc hdlc document to bindings
2016-03-01 7:09 [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
@ 2016-03-01 7:09 ` Zhao Qiang
2016-03-05 4:25 ` Rob Herring
2016-03-01 7:09 ` [PATCH v3 3/7] QE: Add uqe_serial " Zhao Qiang
` (5 subsequent siblings)
6 siblings, 1 reply; 15+ messages in thread
From: Zhao Qiang @ 2016-03-01 7:09 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, xiaobo.xie, linux-kernel, devicetree,
linuxppc-dev, Zhao Qiang
Add ucc hdlc document to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- use ucc-hdlc instead of ucc_hdlc
- add more information to properties.
Changes for v3
- use fsl,tx-timeslot-mask instead of fsl,tx-timeslot
- use fsl,rx-timeslot-mask instead of fsl,rx-timeslot
- add more info
.../bindings/powerpc/fsl/cpm_qe/network.txt | 81 ++++++++++++++++++++++
1 file changed, 81 insertions(+)
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
index 29b28b8..03c7416 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
@@ -41,3 +41,84 @@ Example:
fsl,mdio-pin = <12>;
fsl,mdc-pin = <13>;
};
+
+* HDLC
+
+Currently defined compatibles:
+- fsl,ucc-hdlc
+
+Properties for fsl,ucc-hdlc:
+- rx-clock-name
+- tx-clock-name
+ Usage: required
+ Value type: <string>
+ Definition : Must be "brg1"-"brg16" for internal clock source,
+ Must be "clk1"-"clk24" for external clock source.
+
+- fsl,tdm-interface
+ Usage: optional
+ Value type: <empty>
+ Definition : Specify that hdlc is based on tdm-interface
+
+The property below is dependent on fsl,tdm-interface:
+- fsl,rx-sync-clock
+ Usage: required
+ Value type: <string>
+ Definition : Must be "none", "rsync_pin", "brg9-11" and "brg13-15".
+
+- fsl,tx-sync-clock
+ Usage: required
+ Value type: <string>
+ Definition : Must be "none", "tsync_pin", "brg9-11" and "brg13-15".
+
+- fsl,tdm-framer-type
+ Usage: required for tdm interface
+ Value type: <string>
+ Definition : "e1" or "t1".Now e1 and t1 are used, other framer types
+ are not supported.
+
+- fsl,tdm-id
+ Usage: required for tdm interface
+ Value type: <u32>
+ Definition : number of TDM ID
+
+- fsl,tx-timeslot-mask
+- fsl,rx-timeslot-mask
+ Usage: required for tdm interface
+ Value type: <u32>
+ Definition : time slot mask for TDM operation. Indicates which time
+ slots used for transmitting and receiving.
+
+- fsl,siram-entry-id
+ Usage: required for tdm interface
+ Value type: <u32>
+ Definition : Must be 0,2,4...64. the number of TDM entry.
+
+- fsl,tdm-internal-loopback
+ usage: optional for tdm interface
+ value type: <empty>
+ Definition : Internal loopback connecting on TDM layer.
+
+Example for tdm interface:
+
+ ucc@2000 {
+ compatible = "fsl,ucc-hdlc";
+ rx-clock-name = "clk8";
+ tx-clock-name = "clk9";
+ fsl,rx-sync-clock = "rsync_pin";
+ fsl,tx-sync-clock = "tsync_pin";
+ fsl,tx-timeslot-mask = <0xfffffffe>;
+ fsl,rx-timeslot-mask = <0xfffffffe>;
+ fsl,tdm-framer-type = "e1";
+ fsl,tdm-id = <0>;
+ fsl,siram-entry-id = <0>;
+ fsl,tdm-interface;
+ };
+
+Example for hdlc without tdm interface:
+
+ ucc@2000 {
+ compatible = "fsl,ucc-hdlc";
+ rx-clock-name = "brg1";
+ tx-clock-name = "brg1";
+ };
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 3/7] QE: Add uqe_serial document to bindings
2016-03-01 7:09 [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
2016-03-01 7:09 ` [PATCH v3 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
@ 2016-03-01 7:09 ` Zhao Qiang
2016-03-05 4:25 ` Rob Herring
2016-03-01 7:09 ` [PATCH v3 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl Zhao Qiang
` (4 subsequent siblings)
6 siblings, 1 reply; 15+ messages in thread
From: Zhao Qiang @ 2016-03-01 7:09 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, xiaobo.xie, linux-kernel, devicetree,
linuxppc-dev, Zhao Qiang
Add uqe_serial document to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- modify tx/rx-clock-name specification
Changes for v2
- NA
.../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
new file mode 100644
index 0000000..436c71c
--- /dev/null
+++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
@@ -0,0 +1,19 @@
+* Serial
+
+Currently defined compatibles:
+- ucc_uart
+
+Properties for ucc_uart:
+port-number : port number of UCC-UART
+tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source,
+ should be "clk1"-"clk28" for external clock source.
+
+Example:
+
+ ucc_serial: ucc@2200 {
+ device_type = "serial";
+ compatible = "ucc_uart";
+ port-number = <1>;
+ rx-clock-name = "brg2";
+ tx-clock-name = "brg2";
+ };
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl
2016-03-01 7:09 [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
2016-03-01 7:09 ` [PATCH v3 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
2016-03-01 7:09 ` [PATCH v3 3/7] QE: Add uqe_serial " Zhao Qiang
@ 2016-03-01 7:09 ` Zhao Qiang
2016-03-05 4:25 ` Rob Herring
2016-03-01 7:09 ` [PATCH v3 5/7] T104xD4RDB: Add qe node to t104xd4rdb Zhao Qiang
` (3 subsequent siblings)
6 siblings, 1 reply; 15+ messages in thread
From: Zhao Qiang @ 2016-03-01 7:09 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, xiaobo.xie, linux-kernel, devicetree,
linuxppc-dev, Zhao Qiang
cpm_qe is supported on both powerpc and arm.
and the QE code has been moved from arch/powerpc into
drivers/soc/fsl, so move cpm_qe binding from powerpc/fsl
to soc/fsl
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v3
- NA
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/brg.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/i2c.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/pic.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/usb.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/gpio.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/network.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe.txt | 0
.../devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/firmware.txt | 0
.../devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/par_io.txt | 0
.../devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/pincfg.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/ucc.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/usb.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/serial.txt | 0
.../devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/uqe_serial.txt | 0
15 files changed, 0 insertions(+), 0 deletions(-)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/brg.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/i2c.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/pic.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/usb.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/gpio.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/network.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/firmware.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/par_io.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/pincfg.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/ucc.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/usb.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/serial.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/uqe_serial.txt (100%)
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/brg.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/brg.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/brg.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/brg.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/i2c.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/i2c.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/i2c.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/i2c.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/pic.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/pic.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/pic.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/pic.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/usb.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/usb.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/usb.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/usb.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/gpio.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/gpio.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/gpio.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/gpio.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/network.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/network.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/firmware.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/firmware.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/firmware.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/firmware.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/par_io.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/par_io.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/pincfg.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/pincfg.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/pincfg.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/pincfg.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/ucc.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/ucc.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/ucc.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/ucc.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/usb.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/usb.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/usb.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/usb.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/serial.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/serial.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/serial.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/serial.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/uqe_serial.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/uqe_serial.txt
--
2.1.0.27.g96db324
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v3 5/7] T104xD4RDB: Add qe node to t104xd4rdb
2016-03-01 7:09 [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
` (2 preceding siblings ...)
2016-03-01 7:09 ` [PATCH v3 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl Zhao Qiang
@ 2016-03-01 7:09 ` Zhao Qiang
2016-03-01 7:09 ` [PATCH v3 6/7] T104xRDB: Add qe node to t104xrdb Zhao Qiang
` (2 subsequent siblings)
6 siblings, 0 replies; 15+ messages in thread
From: Zhao Qiang @ 2016-03-01 7:09 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, xiaobo.xie, linux-kernel, devicetree,
linuxppc-dev, Zhao Qiang
add qe node to t104xd4rdb.dtsi and t1040si-post.dtsi.
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- rebase
Changes for v3
- rebase
arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 45 +++++++++++++++++++++++++++++
arch/powerpc/boot/dts/fsl/t104xd4rdb.dtsi | 39 +++++++++++++++++++++++++
2 files changed, 84 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
index e0f4da5..012f813 100644
--- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
@@ -673,3 +673,48 @@
};
};
};
+
+&qe {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ device_type = "qe";
+ compatible = "fsl,qe";
+ fsl,qe-num-riscs = <1>;
+ fsl,qe-num-snums = <28>;
+
+ qeic: interrupt-controller@80 {
+ interrupt-controller;
+ compatible = "fsl,qe-ic";
+ #address-cells = <0>;
+ #interrupt-cells = <1>;
+ reg = <0x80 0x80>;
+ interrupts = <95 2 0 0 94 2 0 0>; //high:79 low:78
+ };
+
+ ucc@2000 {
+ cell-index = <1>;
+ reg = <0x2000 0x200>;
+ interrupts = <32>;
+ interrupt-parent = <&qeic>;
+ };
+
+ ucc@2200 {
+ cell-index = <3>;
+ reg = <0x2200 0x200>;
+ interrupts = <34>;
+ interrupt-parent = <&qeic>;
+ };
+
+ muram@10000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "fsl,qe-muram", "fsl,cpm-muram";
+ ranges = <0x0 0x10000 0x6000>;
+
+ data-only@0 {
+ compatible = "fsl,qe-muram-data",
+ "fsl,cpm-muram-data";
+ reg = <0x0 0x6000>;
+ };
+ };
+};
diff --git a/arch/powerpc/boot/dts/fsl/t104xd4rdb.dtsi b/arch/powerpc/boot/dts/fsl/t104xd4rdb.dtsi
index 3f6d7c6..d9e89d5 100644
--- a/arch/powerpc/boot/dts/fsl/t104xd4rdb.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t104xd4rdb.dtsi
@@ -212,4 +212,43 @@
0 0x00010000>;
};
};
+
+ qe: qe@ffe140000 {
+ ranges = <0x0 0xf 0xfe140000 0x40000>;
+ reg = <0xf 0xfe140000 0 0x480>;
+ brg-frequency = <0>;
+ bus-frequency = <0>;
+
+ si1: si@700 {
+ compatible = "fsl,t1040-qe-si";
+ reg = <0x700 0x80>;
+ };
+
+ siram1: siram@1000 {
+ compatible = "fsl,t1040-qe-siram";
+ reg = <0x1000 0x800>;
+ };
+
+ ucc_hdlc: ucc@2000 {
+ compatible = "fsl,ucc-hdlc";
+ rx-clock-name = "clk8";
+ tx-clock-name = "clk9";
+ fsl,rx-sync-clock = "rsync_pin";
+ fsl,tx-sync-clock = "tsync_pin";
+ fsl,tx-timeslot-mask = <0xfffffffe>;
+ fsl,rx-timeslot-mask = <0xfffffffe>;
+ fsl,tdm-framer-type = "e1";
+ fsl,tdm-id = <0>;
+ fsl,siram-entry-id = <0>;
+ fsl,tdm-interface;
+ };
+
+ ucc_serial: ucc@2200 {
+ device_type = "serial";
+ compatible = "ucc_uart";
+ port-number = <1>;
+ rx-clock-name = "brg2";
+ tx-clock-name = "brg2";
+ };
+ };
};
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 6/7] T104xRDB: Add qe node to t104xrdb
2016-03-01 7:09 [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
` (3 preceding siblings ...)
2016-03-01 7:09 ` [PATCH v3 5/7] T104xD4RDB: Add qe node to t104xd4rdb Zhao Qiang
@ 2016-03-01 7:09 ` Zhao Qiang
2016-03-01 7:09 ` [PATCH v3 7/7] T104xQDS: Add qe node to t104xqds Zhao Qiang
2016-03-05 4:25 ` [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Rob Herring
6 siblings, 0 replies; 15+ messages in thread
From: Zhao Qiang @ 2016-03-01 7:09 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, xiaobo.xie, linux-kernel, devicetree,
linuxppc-dev, Zhao Qiang
add qe node to t104xrdb.dtsi
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- rebase
Changes for v3
- rebase
arch/powerpc/boot/dts/fsl/t104xrdb.dtsi | 39 +++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi b/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
index 830ea48..79d923e 100644
--- a/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
@@ -186,4 +186,43 @@
0 0x00010000>;
};
};
+
+ qe: qe@ffe140000 {
+ ranges = <0x0 0xf 0xfe140000 0x40000>;
+ reg = <0xf 0xfe140000 0 0x480>;
+ brg-frequency = <0>;
+ bus-frequency = <0>;
+
+ si1: si@700 {
+ compatible = "fsl,t1040-qe-si";
+ reg = <0x700 0x80>;
+ };
+
+ siram1: siram@1000 {
+ compatible = "fsl,t1040-qe-siram";
+ reg = <0x1000 0x800>;
+ };
+
+ ucc_hdlc: ucc@2000 {
+ compatible = "fsl,ucc-hdlc";
+ rx-clock-name = "clk8";
+ tx-clock-name = "clk9";
+ fsl,rx-sync-clock = "rsync_pin";
+ fsl,tx-sync-clock = "tsync_pin";
+ fsl,tx-timeslot-mask = <0xfffffffe>;
+ fsl,rx-timeslot-mask = <0xfffffffe>;
+ fsl,tdm-framer-type = "e1";
+ fsl,tdm-id = <0>;
+ fsl,siram-entry-id = <0>;
+ fsl,tdm-interface;
+ };
+
+ ucc_serial: ucc@2200 {
+ device_type = "serial";
+ compatible = "ucc_uart";
+ port-number = <1>;
+ rx-clock-name = "brg2";
+ tx-clock-name = "brg2";
+ };
+ };
};
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 7/7] T104xQDS: Add qe node to t104xqds
2016-03-01 7:09 [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
` (4 preceding siblings ...)
2016-03-01 7:09 ` [PATCH v3 6/7] T104xRDB: Add qe node to t104xrdb Zhao Qiang
@ 2016-03-01 7:09 ` Zhao Qiang
2016-03-05 4:25 ` [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Rob Herring
6 siblings, 0 replies; 15+ messages in thread
From: Zhao Qiang @ 2016-03-01 7:09 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, xiaobo.xie, linux-kernel, devicetree,
linuxppc-dev, Zhao Qiang
add qe node to t104xqds.dtsi
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- rebase
Changes for v3
- rebase
arch/powerpc/boot/dts/fsl/t104xqds.dtsi | 39 +++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/t104xqds.dtsi b/arch/powerpc/boot/dts/fsl/t104xqds.dtsi
index 1498d1e..ab5f081 100644
--- a/arch/powerpc/boot/dts/fsl/t104xqds.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t104xqds.dtsi
@@ -190,4 +190,43 @@
0 0x00010000>;
};
};
+
+ qe: qe@ffe140000 {
+ ranges = <0x0 0xf 0xfe140000 0x40000>;
+ reg = <0xf 0xfe140000 0 0x480>;
+ brg-frequency = <0>;
+ bus-frequency = <0>;
+
+ si1: si@700 {
+ compatible = "fsl,t1040-qe-si";
+ reg = <0x700 0x80>;
+ };
+
+ siram1: siram@1000 {
+ compatible = "fsl,t1040-qe-siram";
+ reg = <0x1000 0x800>;
+ };
+
+ ucc_hdlc: ucc@2000 {
+ compatible = "fsl,ucc-hdlc";
+ rx-clock-name = "clk8";
+ tx-clock-name = "clk9";
+ fsl,rx-sync-clock = "rsync_pin";
+ fsl,tx-sync-clock = "tsync_pin";
+ fsl,tx-timeslot-mask = <0xfffffffe>;
+ fsl,rx-timeslot-mask = <0xfffffffe>;
+ fsl,tdm-framer-type = "e1";
+ fsl,tdm-id = <0>;
+ fsl,siram-entry-id = <0>;
+ fsl,tdm-interface;
+ };
+
+ ucc_serial: ucc@2200 {
+ device_type = "serial";
+ compatible = "ucc_uart";
+ port-number = <1>;
+ rx-clock-name = "brg2";
+ tx-clock-name = "brg2";
+ };
+ };
};
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.
2016-03-01 7:09 [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
` (5 preceding siblings ...)
2016-03-01 7:09 ` [PATCH v3 7/7] T104xQDS: Add qe node to t104xqds Zhao Qiang
@ 2016-03-05 4:25 ` Rob Herring
6 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2016-03-05 4:25 UTC (permalink / raw)
To: Zhao Qiang
Cc: oss, leoyang.li, xiaobo.xie, linux-kernel, devicetree, linuxppc-dev
On Tue, Mar 01, 2016 at 03:09:37PM +0800, Zhao Qiang wrote:
> Add IC, SI and SIRAM document of QE to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2
> - Add interrupt-controller in Required properties
> - delete address-cells and size-cells for qe-si and qe-siram
> Changes for v3
> - Add SoC specific caompatible strings to qe-si and qe-siram
>
> .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 ++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/7] QE: Add ucc hdlc document to bindings
2016-03-01 7:09 ` [PATCH v3 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
@ 2016-03-05 4:25 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2016-03-05 4:25 UTC (permalink / raw)
To: Zhao Qiang
Cc: oss, leoyang.li, xiaobo.xie, linux-kernel, devicetree, linuxppc-dev
On Tue, Mar 01, 2016 at 03:09:38PM +0800, Zhao Qiang wrote:
> Add ucc hdlc document to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2
> - use ucc-hdlc instead of ucc_hdlc
> - add more information to properties.
> Changes for v3
> - use fsl,tx-timeslot-mask instead of fsl,tx-timeslot
> - use fsl,rx-timeslot-mask instead of fsl,rx-timeslot
> - add more info
>
> .../bindings/powerpc/fsl/cpm_qe/network.txt | 81 ++++++++++++++++++++++
> 1 file changed, 81 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
2016-03-01 7:09 ` [PATCH v3 3/7] QE: Add uqe_serial " Zhao Qiang
@ 2016-03-05 4:25 ` Rob Herring
2016-03-07 2:35 ` Qiang Zhao
0 siblings, 1 reply; 15+ messages in thread
From: Rob Herring @ 2016-03-05 4:25 UTC (permalink / raw)
To: Zhao Qiang
Cc: oss, leoyang.li, xiaobo.xie, linux-kernel, devicetree, linuxppc-dev
On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote:
> Add uqe_serial document to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2
> - modify tx/rx-clock-name specification
> Changes for v2
> - NA
>
> .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
>
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> new file mode 100644
> index 0000000..436c71c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> @@ -0,0 +1,19 @@
> +* Serial
> +
> +Currently defined compatibles:
> +- ucc_uart
I guess this is in use already and okay. However, looking at the driver
there really should be SoC specific compatible strings here since the
driver is looking up the SoC compatible string and composing the
firmware filename from that.
> +
> +Properties for ucc_uart:
> +port-number : port number of UCC-UART
> +tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source,
> + should be "clk1"-"clk28" for external clock source.
> +
> +Example:
> +
> + ucc_serial: ucc@2200 {
> + device_type = "serial";
Drop device_type. It should only be used in a few legacy cases.
Looks like the driver is matching on this. Please drop it from the
driver too. I'd leave dts files for now, but they should be updated too
later.
> + compatible = "ucc_uart";
> + port-number = <1>;
> + rx-clock-name = "brg2";
> + tx-clock-name = "brg2";
> + };
> --
> 2.1.0.27.g96db324
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl
2016-03-01 7:09 ` [PATCH v3 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl Zhao Qiang
@ 2016-03-05 4:25 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2016-03-05 4:25 UTC (permalink / raw)
To: Zhao Qiang
Cc: oss, leoyang.li, xiaobo.xie, linux-kernel, devicetree, linuxppc-dev
On Tue, Mar 01, 2016 at 03:09:40PM +0800, Zhao Qiang wrote:
> cpm_qe is supported on both powerpc and arm.
> and the QE code has been moved from arch/powerpc into
> drivers/soc/fsl, so move cpm_qe binding from powerpc/fsl
> to soc/fsl
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
I already acked this. In the future, please add acks on subsequent revs.
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
2016-03-05 4:25 ` Rob Herring
@ 2016-03-07 2:35 ` Qiang Zhao
2016-03-07 17:28 ` Scott Wood
0 siblings, 1 reply; 15+ messages in thread
From: Qiang Zhao @ 2016-03-07 2:35 UTC (permalink / raw)
To: Rob Herring
Cc: oss, Yang-Leo Li, Xiaobo Xie, linux-kernel, devicetree, linuxppc-dev
On Tue, Mar 05, 2016 at 12:26PM, Rob Herring wrote:
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Saturday, March 05, 2016 12:26 PM
> To: Qiang Zhao <qiang.zhao@nxp.com>
> Cc: oss@buserror.net; Yang-Leo Li <leoyang.li@nxp.com>; Xiaobo Xie
> <xiaobo.xie@nxp.com>; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
>=20
> On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote:
> > Add uqe_serial document to
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> >
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> > Changes for v2
> > - modify tx/rx-clock-name specification Changes for v2
> > - NA
> >
> > .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19
> +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > new file mode 100644
> > index 0000000..436c71c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > +++ txt
> > @@ -0,0 +1,19 @@
> > +* Serial
> > +
> > +Currently defined compatibles:
> > +- ucc_uart
>=20
> I guess this is in use already and okay. However, looking at the driver t=
here
> really should be SoC specific compatible strings here since the driver is=
looking
> up the SoC compatible string and composing the firmware filename from tha=
t.
Ok, I will changed both driver and this compatible.
>=20
> > +
> > +Properties for ucc_uart:
> > +port-number : port number of UCC-UART tx/rx-clock-name : should be
> > +"brg1"-"brg16" for internal clock source,
> > + should be "clk1"-"clk28" for external clock source.
> > +
> > +Example:
> > +
> > + ucc_serial: ucc@2200 {
> > + device_type =3D "serial";
>=20
> Drop device_type. It should only be used in a few legacy cases.
>=20
> Looks like the driver is matching on this. Please drop it from the driver=
too. I'd
> leave dts files for now, but they should be updated too later.
Ok, Thank you for your Reviewing, I will drop it
>=20
> > + compatible =3D "ucc_uart";
> > + port-number =3D <1>;
> > + rx-clock-name =3D "brg2";
> > + tx-clock-name =3D "brg2";
> > + };
> > --
> > 2.1.0.27.g96db324
> >
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
2016-03-07 2:35 ` Qiang Zhao
@ 2016-03-07 17:28 ` Scott Wood
2016-03-08 1:16 ` Qiang Zhao
0 siblings, 1 reply; 15+ messages in thread
From: Scott Wood @ 2016-03-07 17:28 UTC (permalink / raw)
To: Qiang Zhao, Rob Herring
Cc: Yang-Leo Li, Xiaobo Xie, linux-kernel, devicetree, linuxppc-dev
On Mon, 2016-03-07 at 02:35 +0000, Qiang Zhao wrote:
> On Tue, Mar 05, 2016 at 12:26PM, Rob Herring wrote:
> > -----Original Message-----
> > From: Rob Herring [mailto:robh@kernel.org]
> > Sent: Saturday, March 05, 2016 12:26 PM
> > To: Qiang Zhao <qiang.zhao@nxp.com>
> > Cc: oss@buserror.net; Yang-Leo Li <leoyang.li@nxp.com>; Xiaobo Xie
> > <xiaobo.xie@nxp.com>; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
> >
> > On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote:
> > > Add uqe_serial document to
> > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > >
> > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > ---
> > > Changes for v2
> > > - modify tx/rx-clock-name specification Changes for v2
> > > - NA
> > >
> > > .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19
> > +++++++++++++++++++
> > > 1 file changed, 19 insertions(+)
> > > create mode 100644
> > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > > new file mode 100644
> > > index 0000000..436c71c
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > +++ txt
> > > @@ -0,0 +1,19 @@
> > > +* Serial
> > > +
> > > +Currently defined compatibles:
> > > +- ucc_uart
> >
> > I guess this is in use already and okay. However, looking at the driver
> > there
> > really should be SoC specific compatible strings here since the driver is
> > looking
> > up the SoC compatible string and composing the firmware filename from
> > that.
>
> Ok, I will changed both driver and this compatible.
But don't break existing device trees while doing so.
-Scott
^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
2016-03-07 17:28 ` Scott Wood
@ 2016-03-08 1:16 ` Qiang Zhao
2016-03-09 0:13 ` Scott Wood
0 siblings, 1 reply; 15+ messages in thread
From: Qiang Zhao @ 2016-03-08 1:16 UTC (permalink / raw)
To: Scott Wood, Rob Herring
Cc: Yang-Leo Li, Xiaobo Xie, linux-kernel, devicetree, linuxppc-dev
T24gVHVlLCBNYXIgMDgsIDIwMTYgYXQgMToyOEFNLCBTY290dCBXb29kIHdyb3RlOg0KPiAtLS0t
LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTY290dCBXb29kIFttYWlsdG86b3NzQGJ1
c2Vycm9yLm5ldF0NCj4gU2VudDogVHVlc2RheSwgTWFyY2ggMDgsIDIwMTYgMToyOCBBTQ0KPiBU
bzogUWlhbmcgWmhhbyA8cWlhbmcuemhhb0BueHAuY29tPjsgUm9iIEhlcnJpbmcgPHJvYmhAa2Vy
bmVsLm9yZz4NCj4gQ2M6IFlhbmctTGVvIExpIDxsZW95YW5nLmxpQG54cC5jb20+OyBYaWFvYm8g
WGllIDx4aWFvYm8ueGllQG54cC5jb20+Ow0KPiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3Jn
OyBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMtDQo+IGRldkBsaXN0cy5vemxh
YnMub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgMy83XSBRRTogQWRkIHVxZV9zZXJpYWwg
ZG9jdW1lbnQgdG8gYmluZGluZ3MNCj4gDQo+IE9uIE1vbiwgMjAxNi0wMy0wNyBhdCAwMjozNSAr
MDAwMCwgUWlhbmcgWmhhbyB3cm90ZToNCj4gPiBPbiBUdWUsIE1hciAwNSwgMjAxNiBhdCAxMjoy
NlBNLCBSb2IgSGVycmluZyB3cm90ZToNCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0t
DQo+ID4gPiBGcm9tOiBSb2IgSGVycmluZyBbbWFpbHRvOnJvYmhAa2VybmVsLm9yZ10NCj4gPiA+
IFNlbnQ6IFNhdHVyZGF5LCBNYXJjaCAwNSwgMjAxNiAxMjoyNiBQTQ0KPiA+ID4gVG86IFFpYW5n
IFpoYW8gPHFpYW5nLnpoYW9AbnhwLmNvbT4NCj4gPiA+IENjOiBvc3NAYnVzZXJyb3IubmV0OyBZ
YW5nLUxlbyBMaSA8bGVveWFuZy5saUBueHAuY29tPjsgWGlhb2JvIFhpZQ0KPiA+ID4gPHhpYW9i
by54aWVAbnhwLmNvbT47IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7DQo+ID4gPiBkZXZp
Y2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmcNCj4g
PiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgMy83XSBRRTogQWRkIHVxZV9zZXJpYWwgZG9jdW1l
bnQgdG8gYmluZGluZ3MNCj4gPiA+DQo+ID4gPiBPbiBUdWUsIE1hciAwMSwgMjAxNiBhdCAwMzow
OTozOVBNICswODAwLCBaaGFvIFFpYW5nIHdyb3RlOg0KPiA+ID4gPiBBZGQgdXFlX3NlcmlhbCBk
b2N1bWVudCB0bw0KPiA+ID4gPiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcG93
ZXJwYy9mc2wvY3BtX3FlL3VxZV9zZXJpYWwudHgNCj4gPiA+ID4gdA0KPiA+ID4gPg0KPiA+ID4g
PiBTaWduZWQtb2ZmLWJ5OiBaaGFvIFFpYW5nIDxxaWFuZy56aGFvQG54cC5jb20+DQo+ID4gPiA+
IC0tLQ0KPiA+ID4gPiBDaGFuZ2VzIGZvciB2Mg0KPiA+ID4gPiAJLSBtb2RpZnkgdHgvcngtY2xv
Y2stbmFtZSBzcGVjaWZpY2F0aW9uIENoYW5nZXMgZm9yIHYyDQo+ID4gPiA+IAktIE5BDQo+ID4g
PiA+DQo+ID4gPiA+ICAuLi4vYmluZGluZ3MvcG93ZXJwYy9mc2wvY3BtX3FlL3VxZV9zZXJpYWwu
dHh0ICAgICAgICB8IDE5DQo+ID4gPiArKysrKysrKysrKysrKysrKysrDQo+ID4gPiA+ICAxIGZp
bGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKQ0KPiA+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0
DQo+ID4gPiA+IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wb3dlcnBjL2ZzbC9j
cG1fcWUvdXFlX3NlcmlhbC50eA0KPiA+ID4gPiB0DQo+ID4gPiA+DQo+ID4gPiA+IGRpZmYgLS1n
aXQNCj4gPiA+ID4gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcG93ZXJwYy9m
c2wvY3BtX3FlL3VxZV9zZXJpYWwuDQo+ID4gPiA+IHR4dA0KPiA+ID4gPiBiL0RvY3VtZW50YXRp
b24vZGV2aWNldHJlZS9iaW5kaW5ncy9wb3dlcnBjL2ZzbC9jcG1fcWUvdXFlX3NlcmlhbC4NCj4g
PiA+ID4gdHh0DQo+ID4gPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+ID4gPiA+IGluZGV4IDAw
MDAwMDAuLjQzNmM3MWMNCj4gPiA+ID4gLS0tIC9kZXYvbnVsbA0KPiA+ID4gPiArKysNCj4gYi9E
b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcG93ZXJwYy9mc2wvY3BtX3FlL3VxZV9z
ZXJpYWwuDQo+ID4gPiA+ICsrKyB0eHQNCj4gPiA+ID4gQEAgLTAsMCArMSwxOSBAQA0KPiA+ID4g
PiArKiBTZXJpYWwNCj4gPiA+ID4gKw0KPiA+ID4gPiArQ3VycmVudGx5IGRlZmluZWQgY29tcGF0
aWJsZXM6DQo+ID4gPiA+ICstIHVjY191YXJ0DQo+ID4gPg0KPiA+ID4gSSBndWVzcyB0aGlzIGlz
IGluIHVzZSBhbHJlYWR5IGFuZCBva2F5LiBIb3dldmVyLCBsb29raW5nIGF0IHRoZQ0KPiA+ID4g
ZHJpdmVyIHRoZXJlIHJlYWxseSBzaG91bGQgYmUgU29DIHNwZWNpZmljIGNvbXBhdGlibGUgc3Ry
aW5ncyBoZXJlDQo+ID4gPiBzaW5jZSB0aGUgZHJpdmVyIGlzIGxvb2tpbmcgdXAgdGhlIFNvQyBj
b21wYXRpYmxlIHN0cmluZyBhbmQNCj4gPiA+IGNvbXBvc2luZyB0aGUgZmlybXdhcmUgZmlsZW5h
bWUgZnJvbSB0aGF0Lg0KPiA+DQo+ID4gT2ssIEkgd2lsbCBjaGFuZ2VkIGJvdGggZHJpdmVyIGFu
ZCB0aGlzIGNvbXBhdGlibGUuDQo+IA0KPiBCdXQgZG9uJ3QgYnJlYWsgZXhpc3RpbmcgZGV2aWNl
IHRyZWVzIHdoaWxlIGRvaW5nIHNvLg0KDQpEbyBJIG5lZWQgdG8gc2VuZCBkcml2ZXIgcGF0Y2gg
aW4gdGhpcyBwYXRjaHNldCBvciBhIGluZGl2aWR1YWwgcGF0Y2g/DQoNCkJSDQotWmhhbyBRaWFu
Zw0KDQo=
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
2016-03-08 1:16 ` Qiang Zhao
@ 2016-03-09 0:13 ` Scott Wood
0 siblings, 0 replies; 15+ messages in thread
From: Scott Wood @ 2016-03-09 0:13 UTC (permalink / raw)
To: Qiang Zhao, Rob Herring
Cc: linux-kernel, devicetree, linuxppc-dev, Xiaobo Xie, Yang-Leo Li
On Tue, 2016-03-08 at 01:16 +0000, Qiang Zhao wrote:
> On Tue, Mar 08, 2016 at 1:28AM, Scott Wood wrote:
> > -----Original Message-----
> > From: Scott Wood [mailto:oss@buserror.net]
> > Sent: Tuesday, March 08, 2016 1:28 AM
> > To: Qiang Zhao <qiang.zhao@nxp.com>; Rob Herring <robh@kernel.org>
> > Cc: Yang-Leo Li <leoyang.li@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>;
> > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linuxppc-
> > dev@lists.ozlabs.org
> > Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
> >
> > On Mon, 2016-03-07 at 02:35 +0000, Qiang Zhao wrote:
> > > On Tue, Mar 05, 2016 at 12:26PM, Rob Herring wrote:
> > > > -----Original Message-----
> > > > From: Rob Herring [mailto:robh@kernel.org]
> > > > Sent: Saturday, March 05, 2016 12:26 PM
> > > > To: Qiang Zhao <qiang.zhao@nxp.com>
> > > > Cc: oss@buserror.net; Yang-Leo Li <leoyang.li@nxp.com>; Xiaobo Xie
> > > > <xiaobo.xie@nxp.com>; linux-kernel@vger.kernel.org;
> > > > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings
> > > >
> > > > On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote:
> > > > > Add uqe_serial document to
> > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx
> > > > > t
> > > > >
> > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > > > ---
> > > > > Changes for v2
> > > > > - modify tx/rx-clock-name specification Changes for v2
> > > > > - NA
> > > > >
> > > > > .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19
> > > > +++++++++++++++++++
> > > > > 1 file changed, 19 insertions(+)
> > > > > create mode 100644
> > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx
> > > > > t
> > > > >
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > > > txt
> > > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > > > txt
> > > > > new file mode 100644
> > > > > index 0000000..436c71c
> > > > > --- /dev/null
> > > > > +++
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > > > > +++ txt
> > > > > @@ -0,0 +1,19 @@
> > > > > +* Serial
> > > > > +
> > > > > +Currently defined compatibles:
> > > > > +- ucc_uart
> > > >
> > > > I guess this is in use already and okay. However, looking at the
> > > > driver there really should be SoC specific compatible strings here
> > > > since the driver is looking up the SoC compatible string and
> > > > composing the firmware filename from that.
> > >
> > > Ok, I will changed both driver and this compatible.
> >
> > But don't break existing device trees while doing so.
>
> Do I need to send driver patch in this patchset or a individual patch?
Doesn't matter.
-Scott
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2016-03-09 0:13 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-01 7:09 [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
2016-03-01 7:09 ` [PATCH v3 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
2016-03-05 4:25 ` Rob Herring
2016-03-01 7:09 ` [PATCH v3 3/7] QE: Add uqe_serial " Zhao Qiang
2016-03-05 4:25 ` Rob Herring
2016-03-07 2:35 ` Qiang Zhao
2016-03-07 17:28 ` Scott Wood
2016-03-08 1:16 ` Qiang Zhao
2016-03-09 0:13 ` Scott Wood
2016-03-01 7:09 ` [PATCH v3 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl Zhao Qiang
2016-03-05 4:25 ` Rob Herring
2016-03-01 7:09 ` [PATCH v3 5/7] T104xD4RDB: Add qe node to t104xd4rdb Zhao Qiang
2016-03-01 7:09 ` [PATCH v3 6/7] T104xRDB: Add qe node to t104xrdb Zhao Qiang
2016-03-01 7:09 ` [PATCH v3 7/7] T104xQDS: Add qe node to t104xqds Zhao Qiang
2016-03-05 4:25 ` [PATCH v3 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).