From: Wolfram Sang <w.sang@pengutronix.de>
To: Heiko Schocher <hs@denx.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101
Date: Mon, 5 Oct 2009 11:53:40 +0200 [thread overview]
Message-ID: <20091005095340.GA3890@pengutronix.de> (raw)
In-Reply-To: <4AC9A463.1080903@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]
On Mon, Oct 05, 2009 at 09:46:43AM +0200, Heiko Schocher wrote:
> - serial Console on PSC1
> - 64MB SDRAM
> - MTD CFI Flash
> - Ethernet FEC
> - IDE support
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> - based on:
> git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
>
> - checked with:
> $ ./scripts/checkpatch.pl 0001-mpc5200-support-for-the-MAN-mpc5200-based-board-uc1.patch
> total: 0 errors, 0 warnings, 324 lines checked
>
> 0001-mpc5200-support-for-the-MAN-mpc5200-based-board-uc1.patch has no obvious style problems and is ready for submission.
> $
>
> changes since v1:
>
> - add comments from Grant Likely <grant.likely@secretlab.ca>
> use mpc5200_defconfig as default configuration
> - add comments from Wolfram Sang <w.sang@pengutronix.de>
> - rebase against current next
>
> arch/powerpc/boot/dts/uc101.dts | 317 ++++++++++++++++++++++++++
> arch/powerpc/platforms/52xx/mpc5200_simple.c | 1 +
> 2 files changed, 318 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/boot/dts/uc101.dts
>
[...]
> + wdt {
> + compatible = "generic,gpio-wdt";
> + reg = <0x600 0x10>;
> + gpios = <&gpt0 0 0>;
> + period = <500>; // WDT trigger period in msec
> + };
Is this an official binding? I also did an gpio-watchdog a while ago and there
were some issues with the binding, IIRC. Would be nice if this has been solved
meanwhile.
Other than that, it looks okay to me.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-10-05 9:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 8:05 [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52 Heiko Schocher
2009-09-14 8:03 ` Wolfram Sang
2009-09-14 14:09 ` Heiko Schocher
2009-09-14 14:45 ` Grant Likely
2009-10-05 7:46 ` [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101 Heiko Schocher
2009-10-05 9:53 ` Wolfram Sang [this message]
2009-10-05 10:12 ` Heiko Schocher
2009-10-05 13:46 ` Grant Likely
2009-10-06 5:19 ` Heiko Schocher
2009-10-06 8:06 ` Wolfram Sang
2009-10-07 6:40 ` [PATCH v3] " Heiko Schocher
2009-10-07 6:40 ` [PATCH v3] mpc5200: support for the MAN mpc5200 based board mucmc52 Heiko Schocher
2009-10-07 9:49 ` Wolfram Sang
2009-10-07 13:57 ` Grant Likely
2009-10-08 5:54 ` [PATCH v4] mpc5200: support for the MAN mpc5200 based board uc101 Heiko Schocher
2009-10-08 5:54 ` [PATCH v4] mpc5200: support for the MAN mpc5200 based board mucmc52 Heiko Schocher
2009-10-08 5:49 ` [PATCH v3] " Heiko Schocher
2009-10-05 7:46 ` [PATCH v2] " Heiko Schocher
2009-09-14 13:43 ` [PATCH] " Grant Likely
2009-09-14 14:32 ` Heiko Schocher
2009-09-14 14:47 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091005095340.GA3890@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=hs@denx.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).