From: Grant Likely <grant.likely@secretlab.ca>
To: hs@denx.de
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52
Date: Mon, 14 Sep 2009 07:43:16 -0600 [thread overview]
Message-ID: <fa686aa40909140643j3183e181x49be002941ae5c36@mail.gmail.com> (raw)
In-Reply-To: <4AADF93C.3030604@denx.de>
Hi Heiko.
Comments below.
On Mon, Sep 14, 2009 at 2:05 AM, Heiko Schocher <hs@denx.de> wrote:
> - serial Console on PSC1
> - 64MB SDRAM
> - MTD CFI Flash
> - Ethernet FEC
> - I2C with PCF8563 and Temp. Sensor ADM9240
> - IDE support
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
>
> =A0arch/powerpc/boot/dts/mucmc52.dts =A0 =A0 =A0 =A0 =A0 =A0| =A0231 ++++
> =A0arch/powerpc/configs/52xx/mucmc52_defconfig =A0| 1476 ++++++++++++++++=
++++++++++
Same comment as on your other patch. Drop the defconfig and add the
needed bits to mpc5200_defconfig (in a separate patch, and add drivers
as modules).
> diff --git a/arch/powerpc/boot/dts/mucmc52.dts b/arch/powerpc/boot/dts/mu=
cmc52.dts
> new file mode 100644
> index 0000000..a4a7a20
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/mucmc52.dts
> @@ -0,0 +1,231 @@
> +/*
> + * mucmc52 board Device Tree Source
> + *
> + * Copyright (C) 2009 DENX Software Engineering GmbH
> + * Heiko Schocher <hs@denx.de>
> + *
> + * This program is free software; you can redistribute =A0it and/or modi=
fy it
> + * under =A0the terms of =A0the GNU General =A0Public License as publish=
ed by the
> + * Free Software Foundation; =A0either version 2 of the =A0License, or (=
at your
> + * option) any later version.
> + */
> +
> +/dts-v1/;
> +
> +/ {
> + =A0 =A0 =A0 model =3D "man,mucmc52";
> + =A0 =A0 =A0 compatible =3D "man,mucmc52";
> + =A0 =A0 =A0 #address-cells =3D <1>;
> + =A0 =A0 =A0 #size-cells =3D <1>;
> + =A0 =A0 =A0 interrupt-parent =3D <&mpc5200_pic>;
> +
> + =A0 =A0 =A0 cpus {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 #address-cells =3D <1>;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 #size-cells =3D <0>;
> +
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 PowerPC,5200@0 {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 device_type =3D "cpu";
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0>;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 d-cache-line-size =3D <32>;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 i-cache-line-size =3D <32>;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 d-cache-size =3D <0x4000>; =
=A0 =A0 =A0 =A0// L1, 16K
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 i-cache-size =3D <0x4000>; =
=A0 =A0 =A0 =A0// L1, 16K
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 timebase-frequency =3D <0>;=
=A0 =A0 =A0 // from bootloader
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 bus-frequency =3D <0>; =A0 =
=A0 =A0 =A0 =A0 =A0// from bootloader
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 clock-frequency =3D <0>; =
=A0 =A0 =A0 =A0 =A0// from bootloader
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 };
> + =A0 =A0 =A0 };
> +
> + =A0 =A0 =A0 memory {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 device_type =3D "memory";
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x00000000 0x04000000>; =A0// 64MB
> + =A0 =A0 =A0 };
> +
> + =A0 =A0 =A0 soc5200@f0000000 {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 #address-cells =3D <1>;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 #size-cells =3D <1>;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "fsl,mpc5200-immr";
Does this board use the older and rarer non-'B' mpc5200 part? If not,
then fsl,mpc5200b-immr also needs to be in this list.
Cheers,
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-09-14 13:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 8:05 [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52 Heiko Schocher
2009-09-14 8:03 ` Wolfram Sang
2009-09-14 14:09 ` Heiko Schocher
2009-09-14 14:45 ` Grant Likely
2009-10-05 7:46 ` [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101 Heiko Schocher
2009-10-05 9:53 ` Wolfram Sang
2009-10-05 10:12 ` Heiko Schocher
2009-10-05 13:46 ` Grant Likely
2009-10-06 5:19 ` Heiko Schocher
2009-10-06 8:06 ` Wolfram Sang
2009-10-07 6:40 ` [PATCH v3] " Heiko Schocher
2009-10-07 6:40 ` [PATCH v3] mpc5200: support for the MAN mpc5200 based board mucmc52 Heiko Schocher
2009-10-07 9:49 ` Wolfram Sang
2009-10-07 13:57 ` Grant Likely
2009-10-08 5:54 ` [PATCH v4] mpc5200: support for the MAN mpc5200 based board uc101 Heiko Schocher
2009-10-08 5:54 ` [PATCH v4] mpc5200: support for the MAN mpc5200 based board mucmc52 Heiko Schocher
2009-10-08 5:49 ` [PATCH v3] " Heiko Schocher
2009-10-05 7:46 ` [PATCH v2] " Heiko Schocher
2009-09-14 13:43 ` Grant Likely [this message]
2009-09-14 14:32 ` [PATCH] " Heiko Schocher
2009-09-14 14:47 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40909140643j3183e181x49be002941ae5c36@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=hs@denx.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).