From: Grant Likely <grant.likely@secretlab.ca>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linuxppc-dev@ozlabs.org, Heiko Schocher <hs@denx.de>
Subject: Re: [PATCH v3] mpc5200: support for the MAN mpc5200 based board mucmc52
Date: Wed, 7 Oct 2009 07:57:09 -0600 [thread overview]
Message-ID: <fa686aa40910070657o2b68156dq25cb44d6d6509abc@mail.gmail.com> (raw)
In-Reply-To: <20091007094936.GE3177@pengutronix.de>
On Wed, Oct 7, 2009 at 3:49 AM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> On Wed, Oct 07, 2009 at 08:40:37AM +0200, Heiko Schocher wrote:
>> - serial Console on PSC1
>> - 64MB SDRAM
>> - MTD CFI Flash
>> - Ethernet FEC
>> - IDE support
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>
> Sorry for finding things incrementally, but I think there is still one is=
sue
> left. Once this is sorted out, you could add my:
>
> Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>
>
[...]
>> + =A0 =A0 soc5200@f0000000 {
>> + =A0 =A0 =A0 =A0 =A0 =A0 #address-cells =3D <1>;
>> + =A0 =A0 =A0 =A0 =A0 =A0 #size-cells =3D <1>;
>> + =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "fsl,mpc5200-immr",
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "fsl,mpc5200b-=
immr";
>
> You should decide on the latter one only here.
Besides, the order is wrong. The exact version (mpc5200b) always
appears before the list of backward compatible values (the non-'b'
version). But Wolfram is right. The IMMR node of the mpc5200b is
*not* wholly backwards compatible with fsl,mpc5200-immr, so
'fsl,mpc5200-immr' should not be in the list. fsl,mpc5200-<blah> only
appears in the child nodes when the specific device truly is backwards
compatible. Compare your .dts file line-for-line with one of the
in-tree mpc5200b .dts files.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-10-07 13:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 8:05 [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52 Heiko Schocher
2009-09-14 8:03 ` Wolfram Sang
2009-09-14 14:09 ` Heiko Schocher
2009-09-14 14:45 ` Grant Likely
2009-10-05 7:46 ` [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101 Heiko Schocher
2009-10-05 9:53 ` Wolfram Sang
2009-10-05 10:12 ` Heiko Schocher
2009-10-05 13:46 ` Grant Likely
2009-10-06 5:19 ` Heiko Schocher
2009-10-06 8:06 ` Wolfram Sang
2009-10-07 6:40 ` [PATCH v3] " Heiko Schocher
2009-10-07 6:40 ` [PATCH v3] mpc5200: support for the MAN mpc5200 based board mucmc52 Heiko Schocher
2009-10-07 9:49 ` Wolfram Sang
2009-10-07 13:57 ` Grant Likely [this message]
2009-10-08 5:54 ` [PATCH v4] mpc5200: support for the MAN mpc5200 based board uc101 Heiko Schocher
2009-10-08 5:54 ` [PATCH v4] mpc5200: support for the MAN mpc5200 based board mucmc52 Heiko Schocher
2009-10-08 5:49 ` [PATCH v3] " Heiko Schocher
2009-10-05 7:46 ` [PATCH v2] " Heiko Schocher
2009-09-14 13:43 ` [PATCH] " Grant Likely
2009-09-14 14:32 ` Heiko Schocher
2009-09-14 14:47 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40910070657o2b68156dq25cb44d6d6509abc@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=hs@denx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).