LinuxPPC-Dev Archive on lore.kernel.org
 help / Atom feed
* [PATCH] powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default
@ 2019-02-11 11:37 Thomas Huth
  2019-02-11 23:31 ` David Gibson
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Thomas Huth @ 2019-02-11 11:37 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Laurent Vivier, Paul Mackerras, David Gibson

Recent versions of QEMU provide a XHCI device by default these
days instead of an old-fashioned OHCI device:

 https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27

So to get the keyboard working in the graphical console there again,
we should now include XHCI support in the kernel by default, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 arch/powerpc/configs/pseries_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
index ea79c51..62e12f6 100644
--- a/arch/powerpc/configs/pseries_defconfig
+++ b/arch/powerpc/configs/pseries_defconfig
@@ -217,6 +217,7 @@ CONFIG_USB_MON=m
 CONFIG_USB_EHCI_HCD=y
 # CONFIG_USB_EHCI_HCD_PPC_OF is not set
 CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_STORAGE=m
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=m
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default
  2019-02-11 11:37 [PATCH] powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default Thomas Huth
@ 2019-02-11 23:31 ` David Gibson
  2019-04-07 12:51   ` Thomas Huth
  2019-02-12  1:36 ` Joel Stanley
  2019-04-21 14:18 ` Michael Ellerman
  2 siblings, 1 reply; 6+ messages in thread
From: David Gibson @ 2019-02-11 23:31 UTC (permalink / raw)
  To: Thomas Huth; +Cc: Laurent Vivier, linuxppc-dev, Paul Mackerras

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

On Mon, 11 Feb 2019 12:37:12 +0100
Thomas Huth <thuth@redhat.com> wrote:

> Recent versions of QEMU provide a XHCI device by default these
> days instead of an old-fashioned OHCI device:
> 
>  https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27
> 
> So to get the keyboard working in the graphical console there again,
> we should now include XHCI support in the kernel by default, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Wow, we didn't before?  That's bonkers.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  arch/powerpc/configs/pseries_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
> index ea79c51..62e12f6 100644
> --- a/arch/powerpc/configs/pseries_defconfig
> +++ b/arch/powerpc/configs/pseries_defconfig
> @@ -217,6 +217,7 @@ CONFIG_USB_MON=m
>  CONFIG_USB_EHCI_HCD=y
>  # CONFIG_USB_EHCI_HCD_PPC_OF is not set
>  CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_XHCI_HCD=y
>  CONFIG_USB_STORAGE=m
>  CONFIG_NEW_LEDS=y
>  CONFIG_LEDS_CLASS=m
> -- 
> 1.8.3.1
> 


-- 
David Gibson <dgibson@redhat.com>
Principal Software Engineer, Virtualization, Red Hat

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default
  2019-02-11 11:37 [PATCH] powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default Thomas Huth
  2019-02-11 23:31 ` David Gibson
@ 2019-02-12  1:36 ` Joel Stanley
  2019-04-21 14:18 ` Michael Ellerman
  2 siblings, 0 replies; 6+ messages in thread
From: Joel Stanley @ 2019-02-12  1:36 UTC (permalink / raw)
  To: Thomas Huth; +Cc: Laurent Vivier, Paul Mackerras, linuxppc-dev, David Gibson

On Mon, 11 Feb 2019 at 22:07, Thomas Huth <thuth@redhat.com> wrote:
>
> Recent versions of QEMU provide a XHCI device by default these
> days instead of an old-fashioned OHCI device:
>
>  https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27

"recent" :D

> So to get the keyboard working in the graphical console there again,
> we should now include XHCI support in the kernel by default, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Acked-by: Joel Stanley <joel@jms.id.au>

> ---
>  arch/powerpc/configs/pseries_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
> index ea79c51..62e12f6 100644
> --- a/arch/powerpc/configs/pseries_defconfig
> +++ b/arch/powerpc/configs/pseries_defconfig
> @@ -217,6 +217,7 @@ CONFIG_USB_MON=m
>  CONFIG_USB_EHCI_HCD=y
>  # CONFIG_USB_EHCI_HCD_PPC_OF is not set
>  CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_XHCI_HCD=y
>  CONFIG_USB_STORAGE=m
>  CONFIG_NEW_LEDS=y
>  CONFIG_LEDS_CLASS=m
> --
> 1.8.3.1
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default
  2019-02-11 23:31 ` David Gibson
@ 2019-04-07 12:51   ` Thomas Huth
  2019-04-08 11:48     ` Michael Ellerman
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2019-04-07 12:51 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
  Cc: Laurent Vivier, David Gibson, linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

On 12/02/2019 00.31, David Gibson wrote:
> On Mon, 11 Feb 2019 12:37:12 +0100
> Thomas Huth <thuth@redhat.com> wrote:
> 
>> Recent versions of QEMU provide a XHCI device by default these
>> days instead of an old-fashioned OHCI device:
>>
>>  https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27
>>
>> So to get the keyboard working in the graphical console there again,
>> we should now include XHCI support in the kernel by default, too.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> 
> Wow, we didn't before?  That's bonkers.
> 
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> 
>> ---
>>  arch/powerpc/configs/pseries_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
>> index ea79c51..62e12f6 100644
>> --- a/arch/powerpc/configs/pseries_defconfig
>> +++ b/arch/powerpc/configs/pseries_defconfig
>> @@ -217,6 +217,7 @@ CONFIG_USB_MON=m
>>  CONFIG_USB_EHCI_HCD=y
>>  # CONFIG_USB_EHCI_HCD_PPC_OF is not set
>>  CONFIG_USB_OHCI_HCD=y
>> +CONFIG_USB_XHCI_HCD=y
>>  CONFIG_USB_STORAGE=m
>>  CONFIG_NEW_LEDS=y
>>  CONFIG_LEDS_CLASS=m
>> -- 
>> 1.8.3.1

Ping?

 Thomas


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default
  2019-04-07 12:51   ` Thomas Huth
@ 2019-04-08 11:48     ` Michael Ellerman
  0 siblings, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2019-04-08 11:48 UTC (permalink / raw)
  To: Thomas Huth, Benjamin Herrenschmidt, Paul Mackerras
  Cc: Laurent Vivier, David Gibson, linuxppc-dev

Thomas Huth <thuth@redhat.com> writes:
> On 12/02/2019 00.31, David Gibson wrote:
>> On Mon, 11 Feb 2019 12:37:12 +0100
>> Thomas Huth <thuth@redhat.com> wrote:
>> 
>>> Recent versions of QEMU provide a XHCI device by default these
>>> days instead of an old-fashioned OHCI device:
>>>
>>>  https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27
>>>
>>> So to get the keyboard working in the graphical console there again,
>>> we should now include XHCI support in the kernel by default, too.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> 
>> Wow, we didn't before?  That's bonkers.
>> 
>> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>> 
>>> ---
>>>  arch/powerpc/configs/pseries_defconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
>>> index ea79c51..62e12f6 100644
>>> --- a/arch/powerpc/configs/pseries_defconfig
>>> +++ b/arch/powerpc/configs/pseries_defconfig
>>> @@ -217,6 +217,7 @@ CONFIG_USB_MON=m
>>>  CONFIG_USB_EHCI_HCD=y
>>>  # CONFIG_USB_EHCI_HCD_PPC_OF is not set
>>>  CONFIG_USB_OHCI_HCD=y
>>> +CONFIG_USB_XHCI_HCD=y
>>>  CONFIG_USB_STORAGE=m
>>>  CONFIG_NEW_LEDS=y
>>>  CONFIG_LEDS_CLASS=m
>>> -- 
>>> 1.8.3.1
>
> Ping?

Sorry, will pick it up.

cheers

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default
  2019-02-11 11:37 [PATCH] powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default Thomas Huth
  2019-02-11 23:31 ` David Gibson
  2019-02-12  1:36 ` Joel Stanley
@ 2019-04-21 14:18 ` Michael Ellerman
  2 siblings, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2019-04-21 14:18 UTC (permalink / raw)
  To: Thomas Huth, linuxppc-dev; +Cc: Laurent Vivier, David Gibson, Paul Mackerras

On Mon, 2019-02-11 at 11:37:12 UTC, Thomas Huth wrote:
> Recent versions of QEMU provide a XHCI device by default these
> days instead of an old-fashioned OHCI device:
> 
>  https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27
> 
> So to get the keyboard working in the graphical console there again,
> we should now include XHCI support in the kernel by default, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Acked-by: Joel Stanley <joel@jms.id.au>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/24c174bb23ebcbe4c3979855b220513f

cheers

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 11:37 [PATCH] powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default Thomas Huth
2019-02-11 23:31 ` David Gibson
2019-04-07 12:51   ` Thomas Huth
2019-04-08 11:48     ` Michael Ellerman
2019-02-12  1:36 ` Joel Stanley
2019-04-21 14:18 ` Michael Ellerman

LinuxPPC-Dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linuxppc-dev/0 linuxppc-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linuxppc-dev linuxppc-dev/ https://lore.kernel.org/linuxppc-dev \
		linuxppc-dev@lists.ozlabs.org linuxppc-dev@ozlabs.org linuxppc-dev@archiver.kernel.org
	public-inbox-index linuxppc-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linuxppc-dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox