[PATCH] powerpc: Add missing include <asm/stacktrace.h>

[PATCH] powerpc: Add missing include <asm/stacktrace.h>

[Mathieu Malaterre]

In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the
function show_user_instructions was added.

This commit adds an include of header file <asm/stacktrace.h> to provide
the missing function prototype. Silence the following gcc warning
(treated as error with W=1):

  arch/powerpc/kernel/process.c:1302:6: error: no previous prototype for ‘show_user_instructions’ [-Werror=missing-prototypes]

Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 arch/powerpc/kernel/process.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index bb6ac471a784..1c64491e9702 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -65,6 +65,7 @@
 #include <asm/livepatch.h>
 #include <asm/cpu_has_feature.h>
 #include <asm/asm-prototypes.h>
+#include <asm/stacktrace.h>
 
 #include <linux/kprobes.h>
 #include <linux/kdebug.h>
-- 
2.11.0

Re: [PATCH] powerpc: Add missing include <asm/stacktrace.h>

[Christophe LEROY]

Le 17/10/2018 à 21:25, Mathieu Malaterre a écrit :
> In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the
> function show_user_instructions was added.
> 
> This commit adds an include of header file <asm/stacktrace.h> to provide
> the missing function prototype. Silence the following gcc warning
> (treated as error with W=1):
> 
>    arch/powerpc/kernel/process.c:1302:6: error: no previous prototype for ‘show_user_instructions’ [-Werror=missing-prototypes]
> 
> Signed-off-by: Mathieu Malaterre <malat@debian.org>

This is already fixed, see 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c9386bfd37d37f29588de9ea9add455510049c33

Christophe

> ---
>   arch/powerpc/kernel/process.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index bb6ac471a784..1c64491e9702 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -65,6 +65,7 @@
>   #include <asm/livepatch.h>
>   #include <asm/cpu_has_feature.h>
>   #include <asm/asm-prototypes.h>
> +#include <asm/stacktrace.h>
>   
>   #include <linux/kprobes.h>
>   #include <linux/kdebug.h>
> 

Re: [PATCH] powerpc: Add missing include <asm/stacktrace.h>

[Mathieu Malaterre]

On Thu, Oct 18, 2018 at 6:37 AM Christophe LEROY
<christophe.leroy@c-s.fr> wrote:
>
>
>
> Le 17/10/2018 à 21:25, Mathieu Malaterre a écrit :
> > In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the
> > function show_user_instructions was added.
> >
> > This commit adds an include of header file <asm/stacktrace.h> to provide
> > the missing function prototype. Silence the following gcc warning
> > (treated as error with W=1):
> >
> >    arch/powerpc/kernel/process.c:1302:6: error: no previous prototype for ‘show_user_instructions’ [-Werror=missing-prototypes]
> >
> > Signed-off-by: Mathieu Malaterre <malat@debian.org>
>
> This is already fixed, see
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c9386bfd37d37f29588de9ea9add455510049c33

Excellent !

Sorry for the noise :(

> Christophe
>
> > ---
> >   arch/powerpc/kernel/process.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> > index bb6ac471a784..1c64491e9702 100644
> > --- a/arch/powerpc/kernel/process.c
> > +++ b/arch/powerpc/kernel/process.c
> > @@ -65,6 +65,7 @@
> >   #include <asm/livepatch.h>
> >   #include <asm/cpu_has_feature.h>
> >   #include <asm/asm-prototypes.h>
> > +#include <asm/stacktrace.h>
> >
> >   #include <linux/kprobes.h>
> >   #include <linux/kdebug.h>
> >