From: Zang Roy-R61911 <r61911@freescale.com>
To: "Michał Mirosław" <mirqus@gmail.com>
Cc: linuxppc-dev@ozlabs.org, akpm@linux-foundation.org,
linux-mmc@vger.kernel.org
Subject: RE: [PATCH 1/3 v2] sdhci: Add auto CMD12 support for eSDHC driver
Date: Tue, 10 Aug 2010 18:07:20 +0800 [thread overview]
Message-ID: <3850A844E6A3854C827AC5C0BEC7B60A0562B0@zch01exm23.fsl.freescale.net> (raw)
In-Reply-To: <AANLkTikUypKobPAHsE+tz-Py-XvvJhbcj7Syj3rX_ej0@mail.gmail.com>
=20
> -----Original Message-----
> From: Micha=B3 Miros=B3aw [mailto:mirqus@gmail.com]=20
> Sent: Tuesday, August 10, 2010 2:25 AM
> To: Zang Roy-R61911
> Cc: linux-mmc@vger.kernel.org; linuxppc-dev@ozlabs.org;=20
> akpm@linux-foundation.org
> Subject: Re: [PATCH 1/3 v2] sdhci: Add auto CMD12 support for=20
> eSDHC driver
>=20
> 2010/8/3 Roy Zang <tie-fei.zang@freescale.com>:
> [...]
> > @@ -240,6 +240,8 @@ struct sdhci_host {
> > =A0#define SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN =A0 =A0 =A0 =A0 =A0 =A0 =
=A0(1<<25)
> > =A0/* Controller cannot support End Attribute in NOP ADMA=20
> descriptor */
> > =A0#define SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC =A0 =A0 =A0 =A0 =A0 =A0 =
=A0(1<<26)
> > +/* Controller uses Auto CMD12 command to stop the transfer */
> > +#define SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 =A0 =A0 =A0 =A0 =A0 =A0 =
(1<<27)
> >
> > =A0 =A0 =A0 =A0int =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 irq; =A0 =
=A0 =A0 =A0 =A0 =A0/* Device IRQ */
> > =A0 =A0 =A0 =A0void __iomem * =A0 =A0 =A0 =A0 =A0ioaddr; =A0 =A0 =A0 =
=A0 /* Mapped address */
>=20
> Just a cosmetic hint: I suggest SDHCI_QUIRK_MULTIBLOCK_READ_AUTO_CMD12
> or something for the quirk name, because ACMD12 part might be confused
> with MMC/SD App CMD 12 (CMD55+CMD12 combo) if/whenever that gets used.
Thanks for the suggestion.
There are several ACMD12 needed to be updated.
Send a new patch to update it.
Roy
prev parent reply other threads:[~2010-08-10 10:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 3:11 [PATCH 1/3 v2] sdhci: Add auto CMD12 support for eSDHC driver Roy Zang
2010-08-03 3:11 ` [PATCH 2/3 v2] dts: Add sdhci,auto-cmd12 field for p4080 device tree Roy Zang
2010-08-03 3:11 ` [PATCH 3/3 v2] dts: Add ESDHC weird voltage bits workaround Roy Zang
2010-08-09 17:33 ` Anton Vorontsov
2010-08-05 0:08 ` [PATCH 2/3 v2] dts: Add sdhci, auto-cmd12 field for p4080 device tree Grant Likely
2010-08-09 17:36 ` [PATCH 2/3 v2] dts: Add sdhci,auto-cmd12 " Anton Vorontsov
2010-08-03 23:43 ` [PATCH 1/3 v2] sdhci: Add auto CMD12 support for eSDHC driver Andrew Morton
2010-08-04 2:57 ` Zang Roy-R61911
2010-08-05 1:02 ` Grant Likely
2010-08-05 2:14 ` Zang Roy-R61911
2010-08-09 5:50 ` Grant Likely
2010-08-09 17:43 ` Anton Vorontsov
2010-08-10 10:04 ` Zang Roy-R61911
2010-08-10 9:47 ` Zang Roy-R61911
2010-08-09 18:24 ` Michał Mirosław
2010-08-10 10:07 ` Zang Roy-R61911 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3850A844E6A3854C827AC5C0BEC7B60A0562B0@zch01exm23.fsl.freescale.net \
--to=r61911@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mirqus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).