linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Roy Zang <tie-fei.zang@freescale.com>
Cc: linuxppc-dev@ozlabs.org, akpm@linux-foundation.org,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH 2/3 v2] dts: Add sdhci, auto-cmd12 field for p4080 device tree
Date: Wed, 4 Aug 2010 18:08:13 -0600	[thread overview]
Message-ID: <AANLkTinUj=wUhk9qns8X2aUHHv3UpYhoE1yMMr2eMLD+@mail.gmail.com> (raw)
In-Reply-To: <1280805072-26112-2-git-send-email-tie-fei.zang@freescale.com>

On Mon, Aug 2, 2010 at 9:11 PM, Roy Zang <tie-fei.zang@freescale.com> wrote=
:
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> ---
> =A0Documentation/powerpc/dts-bindings/fsl/esdhc.txt | =A0 =A02 ++
> =A0arch/powerpc/boot/dts/p4080ds.dts =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0=
 =A01 +
> =A02 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/powerpc/dts-bindings/fsl/esdhc.txt b/Documenta=
tion/powerpc/dts-bindings/fsl/esdhc.txt
> index 8a00407..64bcb8b 100644
> --- a/Documentation/powerpc/dts-bindings/fsl/esdhc.txt
> +++ b/Documentation/powerpc/dts-bindings/fsl/esdhc.txt
> @@ -14,6 +14,8 @@ Required properties:
> =A0 =A0 reports inverted write-protect state;
> =A0 - sdhci,1-bit-only : (optional) specifies that a controller can
> =A0 =A0 only handle 1-bit data transfers.
> + =A0- sdhci,auto-cmd12: (optional) specifies that a controller can
> + =A0 =A0only handle auto CMD12.

I read this, but I still don't understand what it means.  What does
"auto CMD12" mean?  Are there other kinds of CMD12?  Part of this
might be my ignorance about how eSDHC works, but it could be clearer.

Also, you can feel free to merge this patch with patch 1 in your
series.  I makes sense to update the documentation and the driver at
the same time.

g.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

  parent reply	other threads:[~2010-08-05  0:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03  3:11 [PATCH 1/3 v2] sdhci: Add auto CMD12 support for eSDHC driver Roy Zang
2010-08-03  3:11 ` [PATCH 2/3 v2] dts: Add sdhci,auto-cmd12 field for p4080 device tree Roy Zang
2010-08-03  3:11   ` [PATCH 3/3 v2] dts: Add ESDHC weird voltage bits workaround Roy Zang
2010-08-09 17:33     ` Anton Vorontsov
2010-08-05  0:08   ` Grant Likely [this message]
2010-08-09 17:36   ` [PATCH 2/3 v2] dts: Add sdhci,auto-cmd12 field for p4080 device tree Anton Vorontsov
2010-08-03 23:43 ` [PATCH 1/3 v2] sdhci: Add auto CMD12 support for eSDHC driver Andrew Morton
2010-08-04  2:57   ` Zang Roy-R61911
2010-08-05  1:02 ` Grant Likely
2010-08-05  2:14   ` Zang Roy-R61911
2010-08-09  5:50     ` Grant Likely
2010-08-09 17:43   ` Anton Vorontsov
2010-08-10 10:04     ` Zang Roy-R61911
2010-08-10  9:47   ` Zang Roy-R61911
2010-08-09 18:24 ` Michał Mirosław
2010-08-10 10:07   ` Zang Roy-R61911

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTinUj=wUhk9qns8X2aUHHv3UpYhoE1yMMr2eMLD+@mail.gmail.com' \
    --to=grant.likely@secretlab.ca \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=tie-fei.zang@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).