From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest
Date: Fri, 8 Feb 2019 15:45:24 +0100 [thread overview]
Message-ID: <41b02fb0-cdc6-6de0-d8fc-44d3d0a8ad70@c-s.fr> (raw)
In-Reply-To: <20190208143319.11980-1-mark.cave-ayland@ilande.co.uk>
Le 08/02/2019 à 15:33, Mark Cave-Ayland a écrit :
> Commit 8792468da5e1 "powerpc: Add the ability to save FPU without giving it up"
Expected format for the above is:
Commit 123456789abc ("text")
> unexpectedly removed the MSR_FE0 and MSR_FE1 bits from the bitmask used to
> update the MSR of the previous thread in __giveup_fpu() causing a KVM-PR MacOS
> guest to lockup and panic the kernel.
>
> Reinstate these bits to the MSR bitmask to enable MacOS guests to run under
> 32-bit KVM-PR once again without issue.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Should include a Fixes: and a Cc to stable ?
Fixes: 8792468da5e1 ("powerpc: Add the ability to save FPU without
giving it up")
Cc: stable@vger.kernel.org
Christophe
> ---
> arch/powerpc/kernel/process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index ce393df243aa..71bad4b6f80d 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -176,7 +176,7 @@ static void __giveup_fpu(struct task_struct *tsk)
>
> save_fpu(tsk);
> msr = tsk->thread.regs->msr;
> - msr &= ~MSR_FP;
> + msr &= ~(MSR_FP|MSR_FE0|MSR_FE1);
> #ifdef CONFIG_VSX
> if (cpu_has_feature(CPU_FTR_VSX))
> msr &= ~MSR_VSX;
>
next prev parent reply other threads:[~2019-02-08 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 14:33 [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest Mark Cave-Ayland
2019-02-08 14:45 ` Christophe Leroy [this message]
2019-02-08 14:51 ` Mark Cave-Ayland
2019-02-11 0:30 ` Benjamin Herrenschmidt
2019-02-11 21:39 ` Mark Cave-Ayland
2019-02-19 4:55 ` Michael Ellerman
2019-02-19 8:15 ` Mark Cave-Ayland
2019-02-19 4:20 ` Michael Ellerman
2019-02-19 7:55 ` Mark Cave-Ayland
2019-02-20 12:41 ` Michael Ellerman
2019-02-22 9:47 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41b02fb0-cdc6-6de0-d8fc-44d3d0a8ad70@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).