From: Mark Cave-Ayland <email@example.com> To: Benjamin Herrenschmidt <firstname.lastname@example.org>, Christophe Leroy <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest Date: Mon, 11 Feb 2019 21:39:26 +0000 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On 11/02/2019 00:30, Benjamin Herrenschmidt wrote: > On Fri, 2019-02-08 at 14:51 +0000, Mark Cave-Ayland wrote: >> >> Indeed, but there are still some questions to be asked here: >> >> 1) Why were these bits removed from the original bitmask in the first place without >> it being documented in the commit message? >> >> 2) Is this the right fix? I'm told that MacOS guests already run without this patch >> on a G5 under 64-bit KVM-PR which may suggest that this is a workaround for another >> bug elsewhere in the 32-bit powerpc code. >> >> >> If you think that these points don't matter, then I'm happy to resubmit the patch >> as-is based upon your comments above. > > We should write a test case to verify that FE0/FE1 are properly > preserved/context-switched etc... I bet if we accidentally wiped them, > we wouldn't notice 99.9% of the time. Right I guess it's more likely to cause in issue in the KVM PR case because the guest can alter the flags in a way that doesn't go through the normal process switch mechanism. The original patchset at https://firstname.lastname@example.org/msg98326.html does include some tests in the first few patches, but AFAICT they are concerned with the contents of the FP registers rather than the related MSRs. Who is the right person to ask about fixing issues related to context switching with KVM PR? I did add the original author's email address to my first few emails but have had no response back :/ ATB, Mark.
next prev parent reply index Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-08 14:33 Mark Cave-Ayland 2019-02-08 14:45 ` Christophe Leroy 2019-02-08 14:51 ` Mark Cave-Ayland 2019-02-11 0:30 ` Benjamin Herrenschmidt 2019-02-11 21:39 ` Mark Cave-Ayland [this message] 2019-02-19 4:55 ` Michael Ellerman 2019-02-19 8:15 ` Mark Cave-Ayland 2019-02-19 4:20 ` Michael Ellerman 2019-02-19 7:55 ` Mark Cave-Ayland 2019-02-20 12:41 ` Michael Ellerman 2019-02-22 9:47 ` Michael Ellerman
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LinuxPPC-Dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linuxppc-dev/0 linuxppc-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linuxppc-dev linuxppc-dev/ https://lore.kernel.org/linuxppc-dev \ email@example.com firstname.lastname@example.org email@example.com public-inbox-index linuxppc-dev Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.ozlabs.lists.linuxppc-dev AGPL code for this site: git clone https://public-inbox.org/ public-inbox