From: Sean Anderson <sean.anderson@seco.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Madalin Bucur <madalin.bucur@nxp.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Eric Dumazet <edumazet@google.com>,
Camelia Alexandra Groza <camelia.groza@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"linuxppc-dev @ lists . ozlabs . org"
<linuxppc-dev@lists.ozlabs.org>,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v5 1/9] dt-bindings: net: Expand pcs-handle to an array
Date: Tue, 27 Sep 2022 12:27:35 -0400 [thread overview]
Message-ID: <44db6758-2f81-0374-809f-9db0cf2f2e33@seco.com> (raw)
In-Reply-To: <20220927153331.GA4057163-robh@kernel.org>
On 9/27/22 11:33 AM, Rob Herring wrote:
> On Mon, Sep 26, 2022 at 03:03:13PM -0400, Sean Anderson wrote:
>> This allows multiple phandles to be specified for pcs-handle, such as
>> when multiple PCSs are present for a single MAC. To differentiate
>> between them, also add a pcs-handle-names property.
>>
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> ---
>> This was previously submitted as [1]. I expect to update this series
>> more, so I have moved it here. Changes from that version include:
>> - Add maxItems to existing bindings
>> - Add a dependency from pcs-names to pcs-handle.
>>
>> [1] https://lore.kernel.org/netdev/20220711160519.741990-3-sean.anderson@seco.com/
>>
>> (no changes since v4)
>>
>> Changes in v4:
>> - Use pcs-handle-names instead of pcs-names, as discussed
>>
>> Changes in v3:
>> - New
>>
>> .../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 1 +
>> .../devicetree/bindings/net/ethernet-controller.yaml | 10 +++++++++-
>> .../devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 2 +-
>> 3 files changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
>> index 7ca9c19a157c..a53552ee1d0e 100644
>> --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
>> +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
>> @@ -74,6 +74,7 @@ properties:
>>
>> properties:
>> pcs-handle:
>> + maxItems: 1
>
> Forgot to remove the $ref here.
>
>> description:
>> phandle pointing to a PCS sub-node compatible with
>> renesas,rzn1-miic.yaml#
>> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
>> index 4b3c590fcebf..5bb2ec2963cf 100644
>> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
>> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
>> @@ -108,11 +108,16 @@ properties:
>> $ref: "#/properties/phy-connection-type"
>>
>> pcs-handle:
>> - $ref: /schemas/types.yaml#/definitions/phandle
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>
> 'phandle-array' is really a matrix, so this needs a bit more:
>
> items:
> maxItems: 1
>
> Which basically says this is phandles with no arg cells.
>
>> description:
>> Specifies a reference to a node representing a PCS PHY device on a MDIO
>> bus to link with an external PHY (phy-handle) if exists.
>>
>> + pcs-handle-names:
>> + $ref: /schemas/types.yaml#/definitions/string-array
>
> No need for a type as *-names already has a type.
>
>> + description:
>> + The name of each PCS in pcs-handle.
>> +
>> phy-handle:
>> $ref: /schemas/types.yaml#/definitions/phandle
>> description:
>> @@ -216,6 +221,9 @@ properties:
>> required:
>> - speed
>>
>> +dependencies:
>> + pcs-handle-names: [pcs-handle]
>> +
>> allOf:
>> - if:
>> properties:
>> diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
>> index 7f620a71a972..600240281e8c 100644
>> --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
>> @@ -31,7 +31,7 @@ properties:
>> phy-mode: true
>>
>> pcs-handle:
>> - $ref: /schemas/types.yaml#/definitions/phandle
>> + maxItems: 1
>> description:
>> A reference to a node representing a PCS PHY device found on
>> the internal MDIO bus.
>> --
>> 2.35.1.1320.gc452695387.dirty
>>
>>
>
OK, I've added these changes for v6.
--Sean
next prev parent reply other threads:[~2022-09-27 16:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 19:03 [PATCH net-next v5 0/9] [RFT] net: dpaa: Convert to phylink Sean Anderson
2022-09-26 19:03 ` [PATCH net-next v5 1/9] dt-bindings: net: Expand pcs-handle to an array Sean Anderson
2022-09-27 14:39 ` Rob Herring
2022-09-27 15:33 ` Rob Herring
2022-09-27 16:27 ` Sean Anderson [this message]
2022-09-26 19:03 ` [PATCH net-next v5 2/9] dt-bindings: net: Add Lynx PCS binding Sean Anderson
2022-09-30 14:37 ` Rob Herring
2022-09-26 19:03 ` [PATCH net-next v5 3/9] dt-bindings: net: fman: Add additional interface properties Sean Anderson
2022-09-26 19:03 ` [PATCH net-next v5 4/9] net: fman: memac: Add serdes support Sean Anderson
2022-09-26 19:03 ` [PATCH net-next v5 5/9] net: fman: memac: Use lynx pcs driver Sean Anderson
2022-09-26 19:03 ` [PATCH net-next v5 6/9] net: dpaa: Convert to phylink Sean Anderson
2022-09-26 19:03 ` [PATCH net-next v5 7/9] powerpc: dts: t208x: Mark MAC1 and MAC2 as 10G Sean Anderson
2022-09-26 19:03 ` [PATCH net-next v5 8/9] powerpc: dts: qoriq: Add nodes for QSGMII PCSs Sean Anderson
2022-09-26 19:03 ` [PATCH net-next v5 9/9] arm64: dts: layerscape: " Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44db6758-2f81-0374-809f-9db0cf2f2e33@seco.com \
--to=sean.anderson@seco.com \
--cc=camelia.groza@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).