From: Michael Lawnick <ml.lawnick@gmx.de>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linuxppc-dev@ozlabs.org, Esben Haabendal <eha@doredevelopment.dk>,
Esben Haabendal <esbenhaabendal@gmail.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg
Date: Fri, 04 Dec 2009 07:58:19 +0100 [thread overview]
Message-ID: <4B18B30B.1080904@gmx.de> (raw)
In-Reply-To: <20091203152916.GC23152@trinity.fluff.org>
Ben Dooks said the following:
> On Thu, Dec 03, 2009 at 04:09:57PM +0100, Michael Lawnick wrote:
>> Ben Dooks said the following:
>> > On Tue, May 26, 2009 at 01:30:21PM +0200, Esben Haabendal wrote:
>> >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal <eha@doredevelopment.dk> wrote:
>> >> > This fixes MAL (arbitration lost) bug caused by illegal use of
>> >> > RSTA (repeated START) after STOP condition generated after last byte
>> >> > of reads. With this patch, it is possible to do an i2c_transfer() with
>> >> > additional i2c_msg's following the I2C_M_RD messages.
>> >> >
>> >> > It still needs to be resolved if it is possible to fix this issue
>> >> > by removing the STOP condition after reads in a robust way.
>> >> >
>> >> > Signed-off-by: Esben Haabendal <eha@doredevelopment.dk>
>> >> > ---
>> >> > ?drivers/i2c/busses/i2c-mpc.c | ? ?9 +++++++--
>> >> > ?1 files changed, 7 insertions(+), 2 deletions(-)
>> >>
>> >> Any blockers to get this accepted?
>> >
>> > It would be nice to get an ack from someone who can actually test
>> > the driver before getting this merged.
>> >
>> What is the state of this patch?
>> Shouldn't we attack the problem on a more general way by inventing a
>> Flag I2C_M_RESTART (or better I2C_M_NO_RESTART for backward compatibility)?
>> This way the client driver is able to decide what it needs. If we do the
>> choice within adapter, chance is about 50% to be wrong.
>
> The documentation for 'struct i2c_msg' already says the STOP should only
> be generated for the last message of the transfer. If STOP is being
> generated for a message that isn't the last in the transfer than this
> is incorrect behaviour.
Ah, now I see, this is a mpc-only problem of implementation
(automatically generating stop in read function).
I couldn't find the above mentioned specification of STOP/RESTART (seems
I need new glasses) and was worried about whether my own implementation
for OCTEON is correct.
Thank you.
--
Michael
next prev parent reply other threads:[~2009-12-04 6:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 5:22 [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg Esben Haabendal
2009-05-26 11:30 ` Esben Haabendal
2009-05-26 21:33 ` Ben Dooks
2009-05-28 17:17 ` Wolfram Sang
2009-05-28 18:43 ` Joakim Tjernlund
2009-05-28 20:10 ` Esben Haabendal
2009-05-28 20:34 ` Peter Korsgaard
2009-05-28 20:41 ` Esben Haabendal
2009-05-28 21:08 ` Peter Korsgaard
2009-05-28 21:22 ` Esben Haabendal
2009-12-03 15:09 ` Michael Lawnick
2009-12-03 15:29 ` Ben Dooks
2009-12-03 15:49 ` Joakim Tjernlund
2009-12-04 6:58 ` Michael Lawnick [this message]
2009-12-03 15:42 ` Joakim Tjernlund
2009-05-28 19:31 ` Grant Likely
2009-05-28 20:15 ` Esben Haabendal
2009-06-02 22:25 ` Ben Dooks
2009-06-02 23:12 ` Grant Likely
2009-06-03 6:01 ` Grant Likely
2009-06-14 13:16 ` Ben Dooks
2009-06-14 14:04 ` Esben Haabendal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B18B30B.1080904@gmx.de \
--to=ml.lawnick@gmx.de \
--cc=ben-linux@fluff.org \
--cc=eha@doredevelopment.dk \
--cc=esbenhaabendal@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).