From: Grant Likely <grant.likely@secretlab.ca>
To: Esben Haabendal <esbenhaabendal@gmail.com>
Cc: linuxppc-dev@ozlabs.org, linux-i2c@vger.kernel.org,
Esben Haabendal <eha@doredevelopment.dk>
Subject: Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg
Date: Thu, 28 May 2009 13:31:20 -0600 [thread overview]
Message-ID: <fa686aa40905281231o26c74a13v250bcedbd066e77b@mail.gmail.com> (raw)
In-Reply-To: <d2b9ea600905260430i72290901p9266de4cade049c1@mail.gmail.com>
On Tue, May 26, 2009 at 5:30 AM, Esben Haabendal
<esbenhaabendal@gmail.com> wrote:
> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal <eha@doredevelopment.dk>=
wrote:
>> This fixes MAL (arbitration lost) bug caused by illegal use of
>> RSTA (repeated START) after STOP condition generated after last byte
>> of reads. With this patch, it is possible to do an i2c_transfer() with
>> additional i2c_msg's following the I2C_M_RD messages.
>>
>> It still needs to be resolved if it is possible to fix this issue
>> by removing the STOP condition after reads in a robust way.
>>
>> Signed-off-by: Esben Haabendal <eha@doredevelopment.dk>
>> ---
>> =A0drivers/i2c/busses/i2c-mpc.c | =A0 =A09 +++++++--
>> =A01 files changed, 7 insertions(+), 2 deletions(-)
>
> Any blockers to get this accepted?
It helps if you cc: developers/maintainers of the device. ie. Kumar
for mpc8xxx, me for 52xx.
This is the first time I noticed your posting. It will take me a few
days before I get a chance to review it.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2009-05-28 19:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 5:22 [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg Esben Haabendal
2009-05-26 11:30 ` Esben Haabendal
2009-05-26 21:33 ` Ben Dooks
2009-05-28 17:17 ` Wolfram Sang
2009-05-28 18:43 ` Joakim Tjernlund
2009-05-28 20:10 ` Esben Haabendal
2009-05-28 20:34 ` Peter Korsgaard
2009-05-28 20:41 ` Esben Haabendal
2009-05-28 21:08 ` Peter Korsgaard
2009-05-28 21:22 ` Esben Haabendal
2009-12-03 15:09 ` Michael Lawnick
2009-12-03 15:29 ` Ben Dooks
2009-12-03 15:49 ` Joakim Tjernlund
2009-12-04 6:58 ` Michael Lawnick
2009-12-03 15:42 ` Joakim Tjernlund
2009-05-28 19:31 ` Grant Likely [this message]
2009-05-28 20:15 ` Esben Haabendal
2009-06-02 22:25 ` Ben Dooks
2009-06-02 23:12 ` Grant Likely
2009-06-03 6:01 ` Grant Likely
2009-06-14 13:16 ` Ben Dooks
2009-06-14 14:04 ` Esben Haabendal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40905281231o26c74a13v250bcedbd066e77b@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=eha@doredevelopment.dk \
--cc=esbenhaabendal@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).