linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite.dk>
To: Esben Haabendal <esbenhaabendal@gmail.com>
Cc: Esben Haabendal <eha@doredevelopment.dk>,
	linuxppc-dev@ozlabs.org, linux-i2c@vger.kernel.org,
	Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg
Date: Thu, 28 May 2009 22:34:18 +0200	[thread overview]
Message-ID: <87ws8155md.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <d2b9ea600905281310p16f47ed0i454e25bf256d3010@mail.gmail.com> (Esben Haabendal's message of "Thu\, 28 May 2009 22\:10\:56 +0200")

>>>>> "Esben" == Esben Haabendal <esbenhaabendal@gmail.com> writes:

Hi,

 >> I wanted to test it, but it does not apply due to line breaks (check
 >> @@-line). Also, I don't really have the time to dig into the topic, so I
 >> would only test it and give a tested-by-tag if it doesn't break anything
 >> here. I think Joakim would be a good candidate for an acked-by .

 Esben> I've checked both my copy in my "Sent" folder and the copy
 Esben> received from the list, and I cannot see any "line break"
 Esben> breakage of the patch.

I guess Wolfram referred to the context line which was clearly word wrapped:

@@ -456,17 +456,22 @@ static int mpc_xfer(struct i2c_adapter *adap,
struct i2c_msg *msgs, int num)

The other lines look fine.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-05-28 20:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-19  5:22 [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg Esben Haabendal
2009-05-26 11:30 ` Esben Haabendal
2009-05-26 21:33   ` Ben Dooks
2009-05-28 17:17     ` Wolfram Sang
2009-05-28 18:43       ` Joakim Tjernlund
2009-05-28 20:10       ` Esben Haabendal
2009-05-28 20:34         ` Peter Korsgaard [this message]
2009-05-28 20:41           ` Esben Haabendal
2009-05-28 21:08             ` Peter Korsgaard
2009-05-28 21:22               ` Esben Haabendal
2009-12-03 15:09     ` Michael Lawnick
2009-12-03 15:29       ` Ben Dooks
2009-12-03 15:49         ` Joakim Tjernlund
2009-12-04  6:58         ` Michael Lawnick
2009-12-03 15:42       ` Joakim Tjernlund
2009-05-28 19:31   ` Grant Likely
2009-05-28 20:15     ` Esben Haabendal
2009-06-02 22:25       ` Ben Dooks
2009-06-02 23:12 ` Grant Likely
2009-06-03  6:01   ` Grant Likely
2009-06-14 13:16 ` Ben Dooks
2009-06-14 14:04   ` Esben Haabendal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ws8155md.fsf@macbook.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=ben-linux@fluff.org \
    --cc=eha@doredevelopment.dk \
    --cc=esbenhaabendal@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).