From: Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Michal Suchanek <msuchanek@suse.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Ananth Narayan <ananth@in.ibm.com>,
Laurent Dufour <ldufour@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH v7 5/9] powerpc/pseries: flush SLB contents on SLB MCE errors.
Date: Fri, 10 Aug 2018 16:00:46 +0530 [thread overview]
Message-ID: <63bf4cc1-d595-5af6-1e5f-e9047461f3a2@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180808190456.59c03b8b@roar.ozlabs.ibm.com>
On 08/08/2018 02:34 PM, Nicholas Piggin wrote:
> On Tue, 07 Aug 2018 19:47:14 +0530
> Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com> wrote:
>
>> From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>>
>> On pseries, as of today system crashes if we get a machine check
>> exceptions due to SLB errors. These are soft errors and can be fixed by
>> flushing the SLBs so the kernel can continue to function instead of
>> system crash. We do this in real mode before turning on MMU. Otherwise
>> we would run into nested machine checks. This patch now fetches the
>> rtas error log in real mode and flushes the SLBs on SLB errors.
>>
>> Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>> Signed-off-by: Michal Suchanek <msuchanek@suse.com>
>> ---
>>
>> Changes in V7:
>> - Fold Michal's patch into this patch.
>> - Handle MSR_RI=0 and evil context case in MC handler.
>> ---
>
>
>> diff --git a/arch/powerpc/mm/slb.c b/arch/powerpc/mm/slb.c
>> index cb796724a6fc..e89f675f1b5e 100644
>> --- a/arch/powerpc/mm/slb.c
>> +++ b/arch/powerpc/mm/slb.c
>> @@ -145,6 +145,12 @@ void slb_flush_and_rebolt(void)
>> get_paca()->slb_cache_ptr = 0;
>> }
>>
>> +void slb_flush_and_rebolt_realmode(void)
>> +{
>> + __slb_flush_and_rebolt();
>> + get_paca()->slb_cache_ptr = 0;
>> +}
>> +
>> void slb_vmalloc_update(void)
>> {
>> unsigned long vflags;
>
> Can you use this patch for the SLB flush?
>
> https://patchwork.ozlabs.org/patch/953034/
Will use your v2.
Thanks,
-Mahesh.
>
> Thanks,
> Nick
>
next prev parent reply other threads:[~2018-08-10 10:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 14:15 [PATCH v7 0/9] powerpc/pseries: Machine check handler improvements Mahesh J Salgaonkar
2018-08-07 14:16 ` [PATCH v7 1/9] powerpc/pseries: Avoid using the size greater than RTAS_ERROR_LOG_MAX Mahesh J Salgaonkar
2018-08-07 14:16 ` [PATCH v7 2/9] powerpc/pseries: Defer the logging of rtas error to irq work queue Mahesh J Salgaonkar
2018-08-07 14:16 ` [PATCH v7 3/9] powerpc/pseries: Fix endainness while restoring of r3 in MCE handler Mahesh J Salgaonkar
2018-08-13 11:23 ` [v7, " Michael Ellerman
2018-08-07 14:16 ` [PATCH v7 4/9] powerpc/pseries: Define MCE error event section Mahesh J Salgaonkar
2018-08-08 14:42 ` Michael Ellerman
2018-08-10 10:29 ` Mahesh Jagannath Salgaonkar
2018-08-16 4:14 ` Michael Ellerman
2018-08-16 14:44 ` Segher Boessenkool
2018-08-17 11:22 ` Mahesh Jagannath Salgaonkar
2018-08-07 14:17 ` [PATCH v7 5/9] powerpc/pseries: flush SLB contents on SLB MCE errors Mahesh J Salgaonkar
2018-08-07 16:54 ` Michal Suchánek
2018-08-10 10:30 ` Mahesh Jagannath Salgaonkar
2018-08-08 9:04 ` Nicholas Piggin
2018-08-10 10:30 ` Mahesh Jagannath Salgaonkar [this message]
2018-08-07 14:17 ` [PATCH v7 6/9] powerpc/pseries: Display machine check error details Mahesh J Salgaonkar
2018-08-07 14:17 ` [PATCH v7 7/9] powerpc/pseries: Dump the SLB contents on SLB MCE errors Mahesh J Salgaonkar
2018-08-09 1:05 ` Michael Ellerman
2018-08-10 10:32 ` Mahesh Jagannath Salgaonkar
2018-08-10 10:49 ` Mahesh Jagannath Salgaonkar
2018-08-11 4:33 ` Nicholas Piggin
2018-08-13 4:17 ` Mahesh Jagannath Salgaonkar
2018-08-13 14:27 ` Nicholas Piggin
2018-08-14 10:57 ` Mahesh Jagannath Salgaonkar
2018-08-14 12:47 ` Aneesh Kumar K.V
2018-08-07 14:17 ` [PATCH v7 8/9] powerpc/mce: Add sysctl control for recovery action on MCE Mahesh J Salgaonkar
2018-08-08 14:56 ` Michael Ellerman
2018-08-08 15:37 ` Aneesh Kumar K.V
2018-08-08 16:09 ` Michal Suchánek
2018-08-10 11:04 ` Michael Ellerman
2018-08-09 6:34 ` Michael Ellerman
2018-08-09 8:02 ` Nicholas Piggin
2018-08-09 8:09 ` Ananth N Mavinakayanahalli
2018-08-09 8:33 ` Nicholas Piggin
2018-08-09 10:26 ` Michal Suchánek
2018-08-10 7:31 ` Nicholas Piggin
2018-08-09 1:43 ` Nicholas Piggin
2018-08-07 14:18 ` [PATCH v7 9/9] powernv/pseries: consolidate code for mce early handling Mahesh J Salgaonkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63bf4cc1-d595-5af6-1e5f-e9047461f3a2@linux.vnet.ibm.com \
--to=mahesh@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).