From: Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev <linuxppc-dev@ozlabs.org>
Cc: Laurent Dufour <ldufour@linux.vnet.ibm.com>,
Michal Suchanek <msuchanek@suse.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Ananth Narayan <ananth@in.ibm.com>
Subject: Re: [PATCH v7 7/9] powerpc/pseries: Dump the SLB contents on SLB MCE errors.
Date: Fri, 10 Aug 2018 16:19:21 +0530 [thread overview]
Message-ID: <ae44bb7a-b713-987e-f9af-bde5d3c3e484@linux.vnet.ibm.com> (raw)
In-Reply-To: <39ebc2b1-0139-2946-2d9b-1b7998bd4560@linux.vnet.ibm.com>
On 08/10/2018 04:02 PM, Mahesh Jagannath Salgaonkar wrote:
> On 08/09/2018 06:35 AM, Michael Ellerman wrote:
>> Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com> writes:
>>
>>> diff --git a/arch/powerpc/include/asm/paca.h b/arch/powerpc/include/asm/paca.h
>>> index 7f22929ce915..233d25ff6f64 100644
>>> --- a/arch/powerpc/include/asm/paca.h
>>> +++ b/arch/powerpc/include/asm/paca.h
>>> @@ -254,6 +254,10 @@ struct paca_struct {
>>> #endif
>>> #ifdef CONFIG_PPC_PSERIES
>>> u8 *mce_data_buf; /* buffer to hold per cpu rtas errlog */
>>> +
>>> + /* Capture SLB related old contents in MCE handler. */
>>> + struct slb_entry *mce_faulty_slbs;
>>> + u16 slb_save_cache_ptr;
>>> #endif /* CONFIG_PPC_PSERIES */
>>
>> ^^^^^^^^^^^^^^^^^
>
> I will pull that out of CONFIG_PPC_PSERIES.
I mean will pull 'mce_faulty_slbs' and 'slb_save_cache_ptr' and put it
under CONFIG_PPC_BOOK3S_64.
-Mahesh.
>
>>
>>> diff --git a/arch/powerpc/mm/slb.c b/arch/powerpc/mm/slb.c
>>> index e89f675f1b5e..16a53689ffd4 100644
>>> --- a/arch/powerpc/mm/slb.c
>>> +++ b/arch/powerpc/mm/slb.c
>>> @@ -151,6 +151,79 @@ void slb_flush_and_rebolt_realmode(void)
>>> get_paca()->slb_cache_ptr = 0;
>>> }
>>>
>>> +void slb_save_contents(struct slb_entry *slb_ptr)
>>> +{
>>> + int i;
>>> + unsigned long e, v;
>>> +
>>> + /* Save slb_cache_ptr value. */
>>> + get_paca()->slb_save_cache_ptr = get_paca()->slb_cache_ptr;
>>
>> This isn't inside CONFIG_PPC_PSERIES which breaks lots of configs, eg
>> powernv.
>>
>> arch/powerpc/mm/slb.c:160:12: error: 'struct paca_struct' has no member named 'slb_save_cache_ptr'
>> arch/powerpc/mm/slb.c:218:27: error: 'struct paca_struct' has no member named 'slb_save_cache_ptr'
>> arch/powerpc/mm/slb.c:216:49: error: 'struct paca_struct' has no member named 'slb_save_cache_ptr'
>>
>> http://kisskb.ozlabs.ibm.com/kisskb/head/219f20e490add009194d94fdeb480da2e385f1c6/
>>
>> cheers
>>
>
> Ouch.. my bad. Will fix it.
>
> Thanks,
> -Mahesh.
>
next prev parent reply other threads:[~2018-08-10 10:49 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 14:15 [PATCH v7 0/9] powerpc/pseries: Machine check handler improvements Mahesh J Salgaonkar
2018-08-07 14:16 ` [PATCH v7 1/9] powerpc/pseries: Avoid using the size greater than RTAS_ERROR_LOG_MAX Mahesh J Salgaonkar
2018-08-07 14:16 ` [PATCH v7 2/9] powerpc/pseries: Defer the logging of rtas error to irq work queue Mahesh J Salgaonkar
2018-08-07 14:16 ` [PATCH v7 3/9] powerpc/pseries: Fix endainness while restoring of r3 in MCE handler Mahesh J Salgaonkar
2018-08-13 11:23 ` [v7, " Michael Ellerman
2018-08-07 14:16 ` [PATCH v7 4/9] powerpc/pseries: Define MCE error event section Mahesh J Salgaonkar
2018-08-08 14:42 ` Michael Ellerman
2018-08-10 10:29 ` Mahesh Jagannath Salgaonkar
2018-08-16 4:14 ` Michael Ellerman
2018-08-16 14:44 ` Segher Boessenkool
2018-08-17 11:22 ` Mahesh Jagannath Salgaonkar
2018-08-07 14:17 ` [PATCH v7 5/9] powerpc/pseries: flush SLB contents on SLB MCE errors Mahesh J Salgaonkar
2018-08-07 16:54 ` Michal Suchánek
2018-08-10 10:30 ` Mahesh Jagannath Salgaonkar
2018-08-08 9:04 ` Nicholas Piggin
2018-08-10 10:30 ` Mahesh Jagannath Salgaonkar
2018-08-07 14:17 ` [PATCH v7 6/9] powerpc/pseries: Display machine check error details Mahesh J Salgaonkar
2018-08-07 14:17 ` [PATCH v7 7/9] powerpc/pseries: Dump the SLB contents on SLB MCE errors Mahesh J Salgaonkar
2018-08-09 1:05 ` Michael Ellerman
2018-08-10 10:32 ` Mahesh Jagannath Salgaonkar
2018-08-10 10:49 ` Mahesh Jagannath Salgaonkar [this message]
2018-08-11 4:33 ` Nicholas Piggin
2018-08-13 4:17 ` Mahesh Jagannath Salgaonkar
2018-08-13 14:27 ` Nicholas Piggin
2018-08-14 10:57 ` Mahesh Jagannath Salgaonkar
2018-08-14 12:47 ` Aneesh Kumar K.V
2018-08-07 14:17 ` [PATCH v7 8/9] powerpc/mce: Add sysctl control for recovery action on MCE Mahesh J Salgaonkar
2018-08-08 14:56 ` Michael Ellerman
2018-08-08 15:37 ` Aneesh Kumar K.V
2018-08-08 16:09 ` Michal Suchánek
2018-08-10 11:04 ` Michael Ellerman
2018-08-09 6:34 ` Michael Ellerman
2018-08-09 8:02 ` Nicholas Piggin
2018-08-09 8:09 ` Ananth N Mavinakayanahalli
2018-08-09 8:33 ` Nicholas Piggin
2018-08-09 10:26 ` Michal Suchánek
2018-08-10 7:31 ` Nicholas Piggin
2018-08-09 1:43 ` Nicholas Piggin
2018-08-07 14:18 ` [PATCH v7 9/9] powernv/pseries: consolidate code for mce early handling Mahesh J Salgaonkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae44bb7a-b713-987e-f9af-bde5d3c3e484@linux.vnet.ibm.com \
--to=mahesh@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).