* [PATCH v2 27/27] sound: ppc: remove unneeded memset after dma_alloc_coherent
@ 2019-06-28 2:50 Fuqian Huang
2019-06-28 8:59 ` Christophe Leroy
0 siblings, 1 reply; 5+ messages in thread
From: Fuqian Huang @ 2019-06-28 2:50 UTC (permalink / raw)
Cc: Rob Herring, alsa-devel, linux-kernel, Greg Kroah-Hartman,
Takashi Iwai, Jaroslav Kysela, Richard Fontana, Paul Mackerras,
Fuqian Huang, Thomas Gleixner, linuxppc-dev, Allison Randal
In commit af7ddd8a627c
("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
sound/ppc/pmac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c
index 1b11e53f6a62..1ab12f4f8631 100644
--- a/sound/ppc/pmac.c
+++ b/sound/ppc/pmac.c
@@ -56,7 +56,6 @@ static int snd_pmac_dbdma_alloc(struct snd_pmac *chip, struct pmac_dbdma *rec, i
if (rec->space == NULL)
return -ENOMEM;
rec->size = size;
- memset(rec->space, 0, rsize);
rec->cmds = (void __iomem *)DBDMA_ALIGN(rec->space);
rec->addr = rec->dma_base + (unsigned long)((char *)rec->cmds - (char *)rec->space);
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2 27/27] sound: ppc: remove unneeded memset after dma_alloc_coherent
2019-06-28 2:50 [PATCH v2 27/27] sound: ppc: remove unneeded memset after dma_alloc_coherent Fuqian Huang
@ 2019-06-28 8:59 ` Christophe Leroy
2019-06-28 9:11 ` Fuqian Huang
0 siblings, 1 reply; 5+ messages in thread
From: Christophe Leroy @ 2019-06-28 8:59 UTC (permalink / raw)
To: Fuqian Huang
Cc: Rob Herring, alsa-devel, Greg Kroah-Hartman, linux-kernel,
Jaroslav Kysela, Richard Fontana, Paul Mackerras,
Thomas Gleixner, linuxppc-dev, Allison Randal
Le 28/06/2019 à 04:50, Fuqian Huang a écrit :
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
You are refering to a merge commit, is that correct ?
I can't see anything related in that commit, can you please pinpoint it ?
As far as I can see, on powerpc the memory has always been zeroized
(since 2005 at least).
Christophe
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> sound/ppc/pmac.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c
> index 1b11e53f6a62..1ab12f4f8631 100644
> --- a/sound/ppc/pmac.c
> +++ b/sound/ppc/pmac.c
> @@ -56,7 +56,6 @@ static int snd_pmac_dbdma_alloc(struct snd_pmac *chip, struct pmac_dbdma *rec, i
> if (rec->space == NULL)
> return -ENOMEM;
> rec->size = size;
> - memset(rec->space, 0, rsize);
> rec->cmds = (void __iomem *)DBDMA_ALIGN(rec->space);
> rec->addr = rec->dma_base + (unsigned long)((char *)rec->cmds - (char *)rec->space);
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 27/27] sound: ppc: remove unneeded memset after dma_alloc_coherent
2019-06-28 8:59 ` Christophe Leroy
@ 2019-06-28 9:11 ` Fuqian Huang
2019-06-28 9:17 ` [alsa-devel] " Takashi Iwai
2019-06-28 9:48 ` Christophe Leroy
0 siblings, 2 replies; 5+ messages in thread
From: Fuqian Huang @ 2019-06-28 9:11 UTC (permalink / raw)
To: Christophe Leroy
Cc: Rob Herring, alsa-devel, Greg Kroah-Hartman, linux-kernel,
Jaroslav Kysela, Richard Fontana, Paul Mackerras,
Thomas Gleixner, linuxppc-dev, Allison Randal
The merge commit log tells (dma-mapping: zero memory returned from
dma_alloc_* and deprecating the dma_zalloc_coherent).
I used this commit just want to say that dma_alloc_coherent has
zeroed the allocated memory.
Sorry for this mistake.
Maybe this commit 518a2f1925c3("dma-mapping: zero memory returned from
dma_alloc_*") is correct.
Christophe Leroy <christophe.leroy@c-s.fr> 於 2019年6月28日週五 下午4:59寫道：
>
>
>
> Le 28/06/2019 à 04:50, Fuqian Huang a écrit :
> > In commit af7ddd8a627c
> > ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> > dma_alloc_coherent has already zeroed the memory.
> > So memset is not needed.
>
> You are refering to a merge commit, is that correct ?
>
> I can't see anything related in that commit, can you please pinpoint it ?
>
> As far as I can see, on powerpc the memory has always been zeroized
> (since 2005 at least).
>
> Christophe
>
> >
> > Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> > ---
> > sound/ppc/pmac.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c
> > index 1b11e53f6a62..1ab12f4f8631 100644
> > --- a/sound/ppc/pmac.c
> > +++ b/sound/ppc/pmac.c
> > @@ -56,7 +56,6 @@ static int snd_pmac_dbdma_alloc(struct snd_pmac *chip, struct pmac_dbdma *rec, i
> > if (rec->space == NULL)
> > return -ENOMEM;
> > rec->size = size;
> > - memset(rec->space, 0, rsize);
> > rec->cmds = (void __iomem *)DBDMA_ALIGN(rec->space);
> > rec->addr = rec->dma_base + (unsigned long)((char *)rec->cmds - (char *)rec->space);
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [alsa-devel] [PATCH v2 27/27] sound: ppc: remove unneeded memset after dma_alloc_coherent
2019-06-28 9:11 ` Fuqian Huang
@ 2019-06-28 9:17 ` Takashi Iwai
2019-06-28 9:48 ` Christophe Leroy
1 sibling, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2019-06-28 9:17 UTC (permalink / raw)
To: Fuqian Huang
Cc: Rob Herring, alsa-devel, Greg Kroah-Hartman, linux-kernel,
Richard Fontana, Paul Mackerras, Thomas Gleixner, linuxppc-dev,
Allison Randal
On Fri, 28 Jun 2019 11:11:08 +0200,
Fuqian Huang wrote:
>
> The merge commit log tells (dma-mapping: zero memory returned from
> dma_alloc_* and deprecating the dma_zalloc_coherent).
> I used this commit just want to say that dma_alloc_coherent has
> zeroed the allocated memory.
> Sorry for this mistake.
>
> Maybe this commit 518a2f1925c3("dma-mapping: zero memory returned from
> dma_alloc_*") is correct.
Are you going to resubmit v3 patchset? If the correction is specific
to this patch, I can correct the description in my side, too...
thanks,
Takashi
>
> Christophe Leroy <christophe.leroy@c-s.fr> 於 2019年6月28日週五 下午4:59寫道：
>
> >
> >
> >
> > Le 28/06/2019 à 04:50, Fuqian Huang a écrit :
> > > In commit af7ddd8a627c
> > > ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> > > dma_alloc_coherent has already zeroed the memory.
> > > So memset is not needed.
> >
> > You are refering to a merge commit, is that correct ?
> >
> > I can't see anything related in that commit, can you please pinpoint it ?
> >
> > As far as I can see, on powerpc the memory has always been zeroized
> > (since 2005 at least).
> >
> > Christophe
> >
> > >
> > > Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> > > ---
> > > sound/ppc/pmac.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c
> > > index 1b11e53f6a62..1ab12f4f8631 100644
> > > --- a/sound/ppc/pmac.c
> > > +++ b/sound/ppc/pmac.c
> > > @@ -56,7 +56,6 @@ static int snd_pmac_dbdma_alloc(struct snd_pmac *chip, struct pmac_dbdma *rec, i
> > > if (rec->space == NULL)
> > > return -ENOMEM;
> > > rec->size = size;
> > > - memset(rec->space, 0, rsize);
> > > rec->cmds = (void __iomem *)DBDMA_ALIGN(rec->space);
> > > rec->addr = rec->dma_base + (unsigned long)((char *)rec->cmds - (char *)rec->space);
> > >
> > >
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 27/27] sound: ppc: remove unneeded memset after dma_alloc_coherent
2019-06-28 9:11 ` Fuqian Huang
2019-06-28 9:17 ` [alsa-devel] " Takashi Iwai
@ 2019-06-28 9:48 ` Christophe Leroy
1 sibling, 0 replies; 5+ messages in thread
From: Christophe Leroy @ 2019-06-28 9:48 UTC (permalink / raw)
To: Fuqian Huang
Cc: Rob Herring, alsa-devel, Greg Kroah-Hartman, linux-kernel,
Jaroslav Kysela, Richard Fontana, Paul Mackerras,
Thomas Gleixner, linuxppc-dev, Allison Randal
Le 28/06/2019 à 11:11, Fuqian Huang a écrit :
> The merge commit log tells (dma-mapping: zero memory returned from
> dma_alloc_* and deprecating the dma_zalloc_coherent).
> I used this commit just want to say that dma_alloc_coherent has
> zeroed the allocated memory.
> Sorry for this mistake.
>
> Maybe this commit 518a2f1925c3("dma-mapping: zero memory returned from
> dma_alloc_*") is correct.
Yes that looks appropriate. And it confirms it was already done on
powerpc, as that patch doesn't include any change in powerpc arch.
Christophe
>
> Christophe Leroy <christophe.leroy@c-s.fr> 於 2019年6月28日週五 下午4:59寫道：
>
>>
>>
>>
>> Le 28/06/2019 à 04:50, Fuqian Huang a écrit :
>>> In commit af7ddd8a627c
>>> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
>>> dma_alloc_coherent has already zeroed the memory.
>>> So memset is not needed.
>>
>> You are refering to a merge commit, is that correct ?
>>
>> I can't see anything related in that commit, can you please pinpoint it ?
>>
>> As far as I can see, on powerpc the memory has always been zeroized
>> (since 2005 at least).
>>
>> Christophe
>>
>>>
>>> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
>>> ---
>>> sound/ppc/pmac.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c
>>> index 1b11e53f6a62..1ab12f4f8631 100644
>>> --- a/sound/ppc/pmac.c
>>> +++ b/sound/ppc/pmac.c
>>> @@ -56,7 +56,6 @@ static int snd_pmac_dbdma_alloc(struct snd_pmac *chip, struct pmac_dbdma *rec, i
>>> if (rec->space == NULL)
>>> return -ENOMEM;
>>> rec->size = size;
>>> - memset(rec->space, 0, rsize);
>>> rec->cmds = (void __iomem *)DBDMA_ALIGN(rec->space);
>>> rec->addr = rec->dma_base + (unsigned long)((char *)rec->cmds - (char *)rec->space);
>>>
>>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-28 9:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-28 2:50 [PATCH v2 27/27] sound: ppc: remove unneeded memset after dma_alloc_coherent Fuqian Huang
2019-06-28 8:59 ` Christophe Leroy
2019-06-28 9:11 ` Fuqian Huang
2019-06-28 9:17 ` [alsa-devel] " Takashi Iwai
2019-06-28 9:48 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).