From: Joe Lawrence <joe.lawrence@redhat.com>
To: shuah <shuah@kernel.org>
Cc: live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [RFC PATCH] selftests/livepatch: only consider supported arches
Date: Fri, 12 Jul 2019 13:58:12 -0400 [thread overview]
Message-ID: <20190712175812.GB15872@redhat.com> (raw)
In-Reply-To: <eec9376b-8c0d-8f09-59cb-e38839b13368@kernel.org>
On Fri, Jul 12, 2019 at 11:43:02AM -0600, shuah wrote:
> Hi Joe,
>
> [ ... snip ... ]
>
> The one thing I am not seeing is Skip handling. Without that users will
> complain livepatch test is failing as opposed to that the test can't
> run due to unmet dependencies and skipped.
>
> Maybe that is all you need? I would recommend going in that direction
> instead of Arch check.
>
Okay, I see that kselftest/runner.sh compares test return code with
skip_rc=4 to determine SKIP status... so perhaps our scripts could
perform a simple "modinfo" on their test modules to determine if they
have been built and installed? If not found, just SKIP to the next
test.
Thanks,
-- Joe
next prev parent reply other threads:[~2019-07-12 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 17:14 [RFC PATCH] selftests/livepatch: only consider supported arches Joe Lawrence
2019-07-12 17:25 ` Joe Lawrence
2019-07-12 17:43 ` shuah
2019-07-12 17:58 ` Joe Lawrence [this message]
2019-07-12 18:14 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712175812.GB15872@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).