From: Petr Mladek <pmladek@suse.com>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: Miroslav Benes <mbenes@suse.cz>,
rostedt@goodmis.org, jikos@kernel.org, jpoimboe@redhat.com,
mingo@redhat.com, linux-kernel@vger.kernel.org,
live-patching@vger.kernel.org
Subject: Re: [PATCH 0/3] ftrace: Introduce PERMANENT ftrace_ops flag
Date: Wed, 9 Oct 2019 13:22:34 +0200 [thread overview]
Message-ID: <20191009112234.bi7lvp4pvmna26vz@pathway.suse.cz> (raw)
In-Reply-To: <20191008193534.GA16675@redhat.com>
On Tue 2019-10-08 15:35:34, Joe Lawrence wrote:
> On Mon, Oct 07, 2019 at 10:17:11AM +0200, Miroslav Benes wrote:
> > Livepatch uses ftrace for redirection to new patched functions. It is
> > thus directly affected by ftrace sysctl knobs such as ftrace_enabled.
> > Setting ftrace_enabled to 0 also disables all live patched functions. It
> > is not a problem per se, because only administrator can set sysctl
> > values, but it still may be surprising.
> >
> > Introduce PERMANENT ftrace_ops flag to amend this. If the
> > FTRACE_OPS_FL_PERMANENT is set, the tracing of the function is not
> > disabled. Such ftrace_ops can still be unregistered in a standard way.
> >
> > The patch set passes ftrace and livepatch kselftests.
> >
> > Miroslav Benes (3):
> > ftrace: Make test_rec_ops_needs_regs() generic
> > ftrace: Introduce PERMANENT ftrace_ops flag
> > livepatch: Use FTRACE_OPS_FL_PERMANENT
> >
> > Documentation/trace/ftrace-uses.rst | 6 ++++
> > Documentation/trace/ftrace.rst | 2 ++
> > include/linux/ftrace.h | 8 +++--
> > kernel/livepatch/patch.c | 3 +-
> > kernel/trace/ftrace.c | 47 ++++++++++++++++++++++++-----
> > 5 files changed, 55 insertions(+), 11 deletions(-)
> >
> > --
> > 2.23.0
> >
>
> Hi Miroslav,
>
> I wonder if the opposite would be more intuitive: when ftrace_enabled is
> not set, don't allow livepatches to register ftrace filters and
> likewise, don't allow ftrace_enabled to be unset if any livepatches are
> already registered. I guess you could make an argument either way, but
> just offering another option. Perhaps livepatches should follow similar
> behavior of other ftrace clients (like perf probes?)
I am not sure that I understand it correctly.
ftrace_enables is a global flag. My expectation is that it can be
manipulated at any time. But it should affect only ftrace handlers
without FTRACE_OPS_FL_PERMANENT flag.
By other words, the handlers with FTRACE_OPS_FL_PERMANENT flag and
only these handlers should ignore the global flag.
To be even more precise. If a function has registered more ftrace
handlers then the global ftrace_enable setting shold affect only
the handlers without the flag.
Is this the plan, please?
Best Regards,
Petr
next prev parent reply other threads:[~2019-10-09 11:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 8:17 [PATCH 0/3] ftrace: Introduce PERMANENT ftrace_ops flag Miroslav Benes
2019-10-07 8:17 ` [PATCH 1/3] ftrace: Make test_rec_ops_needs_regs() generic Miroslav Benes
2019-10-07 8:17 ` [PATCH 2/3] ftrace: Introduce PERMANENT ftrace_ops flag Miroslav Benes
2019-10-07 8:17 ` [PATCH 3/3] livepatch: Use FTRACE_OPS_FL_PERMANENT Miroslav Benes
2019-10-08 19:35 ` [PATCH 0/3] ftrace: Introduce PERMANENT ftrace_ops flag Joe Lawrence
2019-10-08 19:50 ` Steven Rostedt
2019-10-09 10:33 ` Miroslav Benes
2019-10-09 11:22 ` Petr Mladek [this message]
2019-10-09 14:23 ` Joe Lawrence
2019-10-09 14:26 ` Steven Rostedt
2019-10-10 8:50 ` Petr Mladek
2019-10-10 13:14 ` Steven Rostedt
2019-10-10 13:38 ` Miroslav Benes
2019-10-10 13:43 ` Steven Rostedt
2019-10-10 13:44 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009112234.bi7lvp4pvmna26vz@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).