From: Jingoo Han <jg1.han@samsung.com>
To: "'Pavel Machek'" <pavel@ucw.cz>, "'Jenny Tc'" <jenny.tc@intel.com>
Cc: linux-kernel@vger.kernel.org,
"'Dmitry Eremin-Solenikov'" <dbaryshkov@gmail.com>,
"'Anton Vorontsov'" <cbouatmailru@gmail.com>,
"'Anton Vorontsov'" <anton.vorontsov@linaro.org>,
"'Kim Milo'" <Milo.Kim@ti.com>,
"'Lee Jones'" <lee.jones@linaro.org>,
"'Chanwoo Choi'" <cw00.choi@samsung.com>,
"'Sachin Kamat'" <sachin.kamat@linaro.org>,
"'Lars-Peter Clausen'" <lars@metafoo.de>,
"'Pali Rohár'" <pali.rohar@gmail.com>,
"'Rhyland Klein'" <rklein@nvidia.com>,
"'Rafael J. Wysocki'" <rjw@rjwysocki.net>,
"'David Woodhouse'" <dwmw2@infradead.org>,
"'Tony Lindgren'" <tony@atomide.com>,
"'Russell King'" <linux@arm.linux.org.uk>,
"'Sebastian Reichel'" <sre@ring0.de>,
aaro.koskinen@iki.fi,
"'Pallala Ramakrishna'" <ramakrishna.pallala@intel.com>,
freemangordon@abv.bg, linux-omap@vger.kernel.org,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
Date: Thu, 13 Feb 2014 09:51:29 +0900 [thread overview]
Message-ID: <002301cf2855$bb121790$313646b0$%han@samsung.com> (raw)
In-Reply-To: <20140212110005.GF25706@amd.pavel.ucw.cz>
On Wednesday, February 12, 2014 8:00 PM, Pavel Machek wrote:
> On Wed 2014-02-05 13:44:58, Jenny Tc wrote:
> > On Tue, Feb 04, 2014 at 12:36:30PM +0100, Pavel Machek wrote:
> > > > +struct psy_charger_context {
> > > > + bool is_usb_cable_evt_reg;
> > > > + int psyc_cnt;
> > > > + int batt_status;
> > > > + /*cache battery and charger properties */
> > >
> > > Comment coding style. Please run you patches through checkpatch.
> >
> > checkpatch doesn't throw any error/warning. /* ... */ not allowed for single line
> > comments? (will fix missing space after /*)
>
> I meant the space after /*. Maybe checkpatch does not report anything
> here, but I guess there are other places where it will comment :-).
Yes, right.
+ /*cache battery and charger properties */
^
'one space' is necessary between '/*' and 'cache'.
This can be fixed as below.
+ /* cache battery and charger properties */
Best regards,
Jingoo Han
next prev parent reply other threads:[~2014-02-13 0:51 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 5:12 [PATCH v5 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-02-04 5:12 ` [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Jenny TC
2014-02-04 5:12 ` [PATCH 2/4] power_supply: Introduce generic psy charging driver Jenny TC
2014-02-04 11:36 ` Pavel Machek
2014-02-05 8:14 ` Jenny Tc
2014-02-12 11:00 ` Pavel Machek
2014-02-13 0:51 ` Jingoo Han [this message]
2014-02-04 5:12 ` [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Jenny TC
2014-02-04 11:36 ` Pavel Machek
2014-02-20 5:16 ` Jenny Tc
2014-02-21 14:45 ` Pavel Machek
2014-02-26 2:54 ` Jenny Tc
2014-02-27 19:47 ` Linus Walleij
2014-02-28 2:52 ` Jenny Tc
2014-02-27 20:46 ` Pavel Machek
2014-02-27 20:18 ` Linus Walleij
2014-02-28 3:07 ` Jenny Tc
2014-02-28 10:08 ` Pavel Machek
2014-03-03 3:11 ` Jenny Tc
2014-03-03 10:42 ` Pavel Machek
2014-03-07 3:34 ` Linus Walleij
2014-03-07 3:43 ` Jenny Tc
2014-02-04 5:13 ` [PATCH 4/4] power_supply: bq24261 charger driver Jenny TC
2014-02-04 11:36 ` Pavel Machek
2014-02-20 5:03 ` Jenny Tc
2014-02-21 14:44 ` Pavel Machek
2014-02-25 11:51 ` Jenny Tc
-- strict thread matches above, loose matches on Subject: below --
2014-07-08 6:04 [PATCHv11 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-07-08 6:04 ` [PATCH 2/4] power_supply: Introduce generic psy " Jenny TC
2014-07-14 13:34 ` Pavel Machek
2014-07-18 2:18 ` Sebastian Reichel
2014-07-18 3:38 ` Tc, Jenny
2014-07-18 7:52 ` Pavel Machek
2014-06-30 9:55 [PATCHv10 0/4] power_supply: Introduce power supply " Jenny TC
2014-06-30 9:55 ` [PATCH 2/4] power_supply: Introduce generic psy " Jenny TC
2014-06-19 14:02 [PATCHv9 0/4] power_supply: Introduce power supply " Jenny TC
2014-06-19 14:02 ` [PATCH 2/4] power_supply: Introduce generic psy " Jenny TC
2014-02-20 5:53 [PATCH v6 0/4] power_supply: Introduce power supply " Jenny TC
2014-02-20 5:53 ` [PATCH 2/4] power_supply: Introduce generic psy " Jenny TC
2014-02-27 20:08 ` Linus Walleij
2014-02-28 4:27 ` Jenny Tc
2014-03-07 3:03 ` Linus Walleij
2014-03-07 3:49 ` Jenny Tc
2014-03-07 20:09 ` Pavel Machek
2014-02-28 10:01 ` Pavel Machek
2014-03-07 3:04 ` Linus Walleij
2014-03-07 20:10 ` Pavel Machek
2014-03-12 14:37 ` Linus Walleij
2014-03-13 9:12 ` Pavel Machek
2014-03-14 10:36 ` Linus Walleij
2014-03-14 19:25 ` Mark Brown
2014-01-30 17:30 [PATCH v4 0/4] power_supply: Introduce power supply " Jenny TC
2014-01-30 17:30 ` [PATCH 2/4] power_supply: Introduce generic psy " Jenny TC
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002301cf2855$bb121790$313646b0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=Milo.Kim@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=anton.vorontsov@linaro.org \
--cc=cbouatmailru@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=freemangordon@abv.bg \
--cc=jenny.tc@intel.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=ramakrishna.pallala@intel.com \
--cc=rjw@rjwysocki.net \
--cc=rklein@nvidia.com \
--cc=sachin.kamat@linaro.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).