From: Jenny Tc <jenny.tc@intel.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"Anton Vorontsov" <cbouatmailru@gmail.com>,
"Anton Vorontsov" <anton.vorontsov@linaro.org>,
"Kim Milo" <Milo.Kim@ti.com>, "Lee Jones" <lee.jones@linaro.org>,
"Jingoo Han" <jg1.han@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Sachin Kamat" <sachin.kamat@linaro.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Rhyland Klein" <rklein@nvidia.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"David Woodhouse" <dwmw2@infradead.org>,
"Tony Lindgren" <tony@atomide.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Sebastian Reichel" <sre@ring0.de>,
aaro.koskinen@iki.fi,
"Pallala Ramakrishna" <ramakrishna.pallala@intel.com>,
freemangordon@abv.bg, linux-omap@vger.kernel.org
Subject: Re: [PATCH 4/4] power_supply: bq24261 charger driver
Date: Tue, 25 Feb 2014 17:21:47 +0530 [thread overview]
Message-ID: <20140225115147.GB20856@jenny-desktop> (raw)
In-Reply-To: <20140221144400.GA5238@amd.pavel.ucw.cz>
On Fri, Feb 21, 2014 at 03:44:00PM +0100, Pavel Machek wrote:
> Hi!
>
> > > > +static inline int bq24261_set_cv(struct bq24261_charger *chip, int cv)
> > > > +{
> > > > + int bat_volt;
> > > > + int ret;
> > > > + u8 reg_val;
> > > > + u8 vindpm_val = 0x0;
> > > > +
> > > > + /*
> > > > + * Setting VINDPM value as per the battery voltage
> > > > + * VBatt Vindpm Register Setting
> > > > + * < 3.7v 4.2v 0x0 (default)
> > > > + * 3.71v - 3.96v 4.36v 0x2
> > > > + * > 3.96v 4.6v 0x5
> > > > + */
> > > > + ret = get_battery_voltage(&bat_volt);
> > > > + if (ret) {
> > > > + dev_err(&chip->client->dev,
> > > > + "Error getting battery voltage!!\n");
> > > > + } else {
> > >
> > > You forget the error value and continue anyway.
> >
> > On error, throw the error and program default VINDPM value.
>
> Is it good idea to attempt charging when we can't read battery
> voltage?
This function decides the VINDPM setting and doesn't enable charging.
VINDPM setting is used to ensure minimum input voltage and thereby allow to
charge with low power charging source. If the voltage read fails, then the
default VINDPM value 0x0 will be programmed and the input voltage may go down
as low as 4.2V. The charging/not charging decision is taken by power supply
charger driver and not by the chip driver. The worst case impact would be that
charging may happen with a low charge current at high battery voltages,
but doesn't compromise safety at all.
-Jenny
next prev parent reply other threads:[~2014-02-25 11:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 5:12 [PATCH v5 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-02-04 5:12 ` [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Jenny TC
2014-02-04 5:12 ` [PATCH 2/4] power_supply: Introduce generic psy charging driver Jenny TC
2014-02-04 11:36 ` Pavel Machek
2014-02-05 8:14 ` Jenny Tc
2014-02-12 11:00 ` Pavel Machek
2014-02-13 0:51 ` Jingoo Han
2014-02-04 5:12 ` [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Jenny TC
2014-02-04 11:36 ` Pavel Machek
2014-02-20 5:16 ` Jenny Tc
2014-02-21 14:45 ` Pavel Machek
2014-02-26 2:54 ` Jenny Tc
2014-02-27 19:47 ` Linus Walleij
2014-02-28 2:52 ` Jenny Tc
2014-02-27 20:46 ` Pavel Machek
2014-02-27 20:18 ` Linus Walleij
2014-02-28 3:07 ` Jenny Tc
2014-02-28 10:08 ` Pavel Machek
2014-03-03 3:11 ` Jenny Tc
2014-03-03 10:42 ` Pavel Machek
2014-03-07 3:34 ` Linus Walleij
2014-03-07 3:43 ` Jenny Tc
2014-02-04 5:13 ` [PATCH 4/4] power_supply: bq24261 charger driver Jenny TC
2014-02-04 11:36 ` Pavel Machek
2014-02-20 5:03 ` Jenny Tc
2014-02-21 14:44 ` Pavel Machek
2014-02-25 11:51 ` Jenny Tc [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-08 6:04 [PATCHv11 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-07-08 6:04 ` [PATCH 4/4] power_supply: bq24261 charger driver Jenny TC
2014-06-30 9:55 [PATCHv10 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-06-30 9:55 ` [PATCH 4/4] power_supply: bq24261 charger driver Jenny TC
2014-07-03 15:25 ` Sebastian Reichel
2014-06-19 14:02 [PATCHv9 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-06-19 14:02 ` [PATCH 4/4] power_supply: bq24261 charger driver Jenny TC
2014-02-20 5:53 [PATCH v6 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-02-20 5:54 ` [PATCH 4/4] power_supply: bq24261 charger driver Jenny TC
2014-01-30 17:30 [PATCH v4 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-01-30 17:30 ` [PATCH 4/4] power_supply: bq24261 charger driver Jenny TC
2014-01-30 17:01 ` Pavel Machek
2014-01-31 4:05 ` Jenny Tc
2014-01-22 17:19 [PATCH v3 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-01-22 17:19 ` [PATCH 4/4] power_supply: bq24261 charger driver Jenny TC
2014-01-23 8:58 ` Jingoo Han
2014-01-25 22:30 ` Pavel Machek
2014-01-28 14:14 ` Pavel Machek
2014-01-29 13:23 ` Jenny Tc
2014-01-29 7:26 ` Jingoo Han
2014-01-29 9:36 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225115147.GB20856@jenny-desktop \
--to=jenny.tc@intel.com \
--cc=Milo.Kim@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=anton.vorontsov@linaro.org \
--cc=cbouatmailru@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=freemangordon@abv.bg \
--cc=jg1.han@samsung.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=ramakrishna.pallala@intel.com \
--cc=rjw@rjwysocki.net \
--cc=rklein@nvidia.com \
--cc=sachin.kamat@linaro.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).