* [PATCH] powercap: Remove reassignment
@ 2017-11-11 17:47 Arvind Yadav
2017-12-13 1:03 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-11-11 17:47 UTC (permalink / raw)
To: rjw; +Cc: linux-kernel, linux-pm
It is not necessary to reassignment of 'result'.
Here, result is being initialized zero and then updated with
seed_constraint_attributes().
class_register is enough to return successful and error value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/powercap/powercap_sys.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
index 5b10b50..64b2b25 100644
--- a/drivers/powercap/powercap_sys.c
+++ b/drivers/powercap/powercap_sys.c
@@ -673,15 +673,13 @@ EXPORT_SYMBOL_GPL(powercap_unregister_control_type);
static int __init powercap_init(void)
{
- int result = 0;
+ int result;
result = seed_constraint_attributes();
if (result)
return result;
- result = class_register(&powercap_class);
-
- return result;
+ return class_register(&powercap_class);
}
device_initcall(powercap_init);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powercap: Remove reassignment
2017-11-11 17:47 [PATCH] powercap: Remove reassignment Arvind Yadav
@ 2017-12-13 1:03 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2017-12-13 1:03 UTC (permalink / raw)
To: Arvind Yadav; +Cc: linux-kernel, linux-pm
On Saturday, November 11, 2017 6:47:26 PM CET Arvind Yadav wrote:
> It is not necessary to reassignment of 'result'.
> Here, result is being initialized zero and then updated with
> seed_constraint_attributes().
> class_register is enough to return successful and error value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/powercap/powercap_sys.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
> index 5b10b50..64b2b25 100644
> --- a/drivers/powercap/powercap_sys.c
> +++ b/drivers/powercap/powercap_sys.c
> @@ -673,15 +673,13 @@ EXPORT_SYMBOL_GPL(powercap_unregister_control_type);
>
> static int __init powercap_init(void)
> {
> - int result = 0;
> + int result;
>
> result = seed_constraint_attributes();
> if (result)
> return result;
>
> - result = class_register(&powercap_class);
> -
> - return result;
> + return class_register(&powercap_class);
> }
>
> device_initcall(powercap_init);
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-13 1:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-11 17:47 [PATCH] powercap: Remove reassignment Arvind Yadav
2017-12-13 1:03 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).