From: Pavel Fedin <p.fedin@samsung.com>
To: "'Krzysztof Kozlowski'" <k.kozlowski@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: k.kozlowski.k@gmail.com, "'Rob Herring'" <robh+dt@kernel.org>,
"'Pawel Moll'" <pawel.moll@arm.com>,
"'Mark Rutland'" <mark.rutland@arm.com>,
"'Ian Campbell'" <ijc+devicetree@hellion.org.uk>,
"'Kumar Gala'" <galak@codeaurora.org>,
"'Kukjin Kim'" <kgene@kernel.org>
Subject: RE: [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410
Date: Thu, 05 Nov 2015 14:36:36 +0300 [thread overview]
Message-ID: <005001d117be$3b5709c0$b2051d40$@samsung.com> (raw)
In-Reply-To: <563B3D15.2070700@samsung.com>
Hello!
> >>> + ethernet@3 {
> >>> + compatible = "smsc,lan9115";
> >>> + reg = <3 0 0x10000>;
> >>> + phy-mode = "mii";
> >>> + interrupt-parent = <&gpx0>;
> >>> + interrupts = <5 8>;
> >>
> >> s/8/IRQ_TYPE_LEVEL_LOW/
> >> (is this really level low interrupt?)
> >
> > Yes, according to: https://github.com/AndreiLux/Perseus-S3/blob/master/arch/arm/mach-
> exynos/mach-smdk5250.c#L133
>
> Although this is different board, but okay.
I am curious too, so i examined SMSC datasheet. The IRQ is fully programmable on
chip's side too, and our driver indeed defaults to active-low. You can switch it
to active-high by addint smsc,irq-active-high property. But i just copied
settings from those old Android kernels, and it just works.
So, cleaning up and posting v6.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-11-05 11:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 9:16 [PATCH v5 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Pavel Fedin
2015-11-03 9:16 ` [PATCH v5 1/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin
2015-11-04 8:09 ` Krzysztof Kozlowski
2015-11-03 9:16 ` [PATCH v5 2/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin
2015-11-04 8:12 ` Krzysztof Kozlowski
2015-11-03 9:16 ` [PATCH v5 3/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin
2015-11-04 8:20 ` Krzysztof Kozlowski
2015-11-05 10:40 ` Pavel Fedin
2015-11-05 11:09 ` Krzysztof Kozlowski
2015-11-03 9:16 ` [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin
2015-11-04 8:28 ` Krzysztof Kozlowski
2015-11-05 11:14 ` Pavel Fedin
2015-11-05 11:27 ` Krzysztof Kozlowski
2015-11-05 11:36 ` Pavel Fedin [this message]
2015-11-04 7:36 ` [PATCH v5 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Krzysztof Kozlowski
2015-11-05 7:59 ` Pavel Fedin
2015-11-05 8:07 ` Krzysztof Kozlowski
2015-11-05 8:44 ` Pavel Fedin
2015-11-05 8:51 ` Krzysztof Kozlowski
2015-11-05 9:00 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005001d117be$3b5709c0$b2051d40$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=k.kozlowski.k@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).