From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Pavel Fedin <p.fedin@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: k.kozlowski.k@gmail.com, "'Rob Herring'" <robh+dt@kernel.org>,
"'Pawel Moll'" <pawel.moll@arm.com>,
"'Mark Rutland'" <mark.rutland@arm.com>,
"'Ian Campbell'" <ijc+devicetree@hellion.org.uk>,
"'Kumar Gala'" <galak@codeaurora.org>,
"'Kukjin Kim'" <kgene@kernel.org>
Subject: Re: [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410
Date: Thu, 5 Nov 2015 20:27:17 +0900 [thread overview]
Message-ID: <563B3D15.2070700@samsung.com> (raw)
In-Reply-To: <004f01d117bb$1e4fbb40$5aef31c0$@samsung.com>
W dniu 05.11.2015 o 20:14, Pavel Fedin pisze:
> Hello!
>
>>> + ethernet@3 {
>>> + compatible = "smsc,lan9115";
>>> + reg = <3 0 0x10000>;
>>> + phy-mode = "mii";
>>> + interrupt-parent = <&gpx0>;
>>> + interrupts = <5 8>;
>>
>> s/8/IRQ_TYPE_LEVEL_LOW/
>> (is this really level low interrupt?)
>
> Yes, according to: https://github.com/AndreiLux/Perseus-S3/blob/master/arch/arm/mach-exynos/mach-smdk5250.c#L133
Although this is different board, but okay.
>
>> Some other DTS include regulators: vddvario-supply and vdd33a-supply. It
>> seems that they are not described in SMSC911x bindings but in
>> GPMC-eth... but the smsc911x driver is requesting them. Could you
>> investigate that? I think these regulators should be provided (and
>> SMSC911x bindings should be updated).
>
> Sorry, i cannot. The board has lots of jumpers, which choose between fixed voltage and regulators for different components,
> according to board's manual, but the manual is very poor IMHO, and i don't understand how to use them. And i use default,
> fixed-voltage configuration.
> One of my colleagues tried to get it working, but failed. It actually requires more time, and IIRC you need to bring up i2c before
> you can drive regulators.
> So can we leave it as it is for now? At least it works, and this is much better than no ethernet support at all.
Ok, that is sufficient explanation.
>> I don't have the board schematics so I couldn't verify the GPIOs.
>
> Me neither, i wrote GPIO settings according to chip datasheet i have. They are actually chip-specific, but i wrote them in board
> file because on different boards you may use different banks, and therefore different pins. Or, if you don't use SROMc at all, you
> can configure all pins to do something else.
>
Makes sense.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-11-05 11:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 9:16 [PATCH v5 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Pavel Fedin
2015-11-03 9:16 ` [PATCH v5 1/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin
2015-11-04 8:09 ` Krzysztof Kozlowski
2015-11-03 9:16 ` [PATCH v5 2/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin
2015-11-04 8:12 ` Krzysztof Kozlowski
2015-11-03 9:16 ` [PATCH v5 3/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin
2015-11-04 8:20 ` Krzysztof Kozlowski
2015-11-05 10:40 ` Pavel Fedin
2015-11-05 11:09 ` Krzysztof Kozlowski
2015-11-03 9:16 ` [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin
2015-11-04 8:28 ` Krzysztof Kozlowski
2015-11-05 11:14 ` Pavel Fedin
2015-11-05 11:27 ` Krzysztof Kozlowski [this message]
2015-11-05 11:36 ` Pavel Fedin
2015-11-04 7:36 ` [PATCH v5 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Krzysztof Kozlowski
2015-11-05 7:59 ` Pavel Fedin
2015-11-05 8:07 ` Krzysztof Kozlowski
2015-11-05 8:44 ` Pavel Fedin
2015-11-05 8:51 ` Krzysztof Kozlowski
2015-11-05 9:00 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563B3D15.2070700@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=k.kozlowski.k@gmail.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=p.fedin@samsung.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).