From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Pavel Fedin <p.fedin@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Kukjin Kim <kgene@kernel.org>
Subject: Re: [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410
Date: Wed, 04 Nov 2015 17:28:21 +0900 [thread overview]
Message-ID: <5639C1A5.1040708@samsung.com> (raw)
In-Reply-To: <4568ad982f0af1846994119961cbb798edff311c.1446542020.git.p.fedin@samsung.com>
On 03.11.2015 18:16, Pavel Fedin wrote:
> The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO
> initialization is required.
>
> Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
> ---
> arch/arm/boot/dts/exynos5410-smdk5410.dts | 40 +++++++++++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5410-smdk5410.dts b/arch/arm/boot/dts/exynos5410-smdk5410.dts
> index cebeaab..f41952f 100644
> --- a/arch/arm/boot/dts/exynos5410-smdk5410.dts
> +++ b/arch/arm/boot/dts/exynos5410-smdk5410.dts
> @@ -61,6 +61,27 @@
> disable-wp;
> };
>
> +&pinctrl_0 {
> + srom_ctl: srom-ctl {
> + samsung,pins = "gpy0-3", "gpy0-4", "gpy0-5",
> + "gpy1-0", "gpy1-1", "gpy1-2", "gpy1-3";
> + samsung,pin-function = <2>;
> + samsung,pin-drv = <0>;
> + };
> +
> + srom_ebi: srom-ebi {
> + samsung,pins = "gpy3-0", "gpy3-1", "gpy3-2", "gpy3-3",
> + "gpy3-4", "gpy3-5", "gpy3-6", "gpy3-7",
> + "gpy5-0", "gpy5-1", "gpy5-2", "gpy5-3",
> + "gpy5-4", "gpy5-5", "gpy5-6", "gpy5-7",
> + "gpy6-0", "gpy6-1", "gpy6-2", "gpy6-3",
> + "gpy6-4", "gpy6-5", "gpy6-6", "gpy6-7";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <3>;
> + samsung,pin-drv = <0>;
> + };
> +};
> +
> &uart0 {
> status = "okay";
> };
> @@ -72,3 +93,22 @@
> &uart2 {
> status = "okay";
> };
> +
> +&sromc {
Put sromc in alphabetical order.
> + pinctrl-names = "default";
> + pinctrl-0 = <&srom_ctl>, <&srom_ebi>;
> +
> + ethernet@3 {
> + compatible = "smsc,lan9115";
> + reg = <3 0 0x10000>;
> + phy-mode = "mii";
> + interrupt-parent = <&gpx0>;
> + interrupts = <5 8>;
s/8/IRQ_TYPE_LEVEL_LOW/
(is this really level low interrupt?)
> + reg-io-width = <2>;
> + smsc,irq-push-pull;
> + smsc,force-internal-phy;
> +
> + samsung,srom-page-mode = <1>;
> + samsung,srom-timing = <9 12 1 9 1 1>;
Some other DTS include regulators: vddvario-supply and vdd33a-supply. It
seems that they are not described in SMSC911x bindings but in
GPMC-eth... but the smsc911x driver is requesting them. Could you
investigate that? I think these regulators should be provided (and
SMSC911x bindings should be updated).
> + };
> +};
I don't have the board schematics so I couldn't verify the GPIOs.
Overall looks good.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-11-04 8:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 9:16 [PATCH v5 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Pavel Fedin
2015-11-03 9:16 ` [PATCH v5 1/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin
2015-11-04 8:09 ` Krzysztof Kozlowski
2015-11-03 9:16 ` [PATCH v5 2/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin
2015-11-04 8:12 ` Krzysztof Kozlowski
2015-11-03 9:16 ` [PATCH v5 3/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin
2015-11-04 8:20 ` Krzysztof Kozlowski
2015-11-05 10:40 ` Pavel Fedin
2015-11-05 11:09 ` Krzysztof Kozlowski
2015-11-03 9:16 ` [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin
2015-11-04 8:28 ` Krzysztof Kozlowski [this message]
2015-11-05 11:14 ` Pavel Fedin
2015-11-05 11:27 ` Krzysztof Kozlowski
2015-11-05 11:36 ` Pavel Fedin
2015-11-04 7:36 ` [PATCH v5 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Krzysztof Kozlowski
2015-11-05 7:59 ` Pavel Fedin
2015-11-05 8:07 ` Krzysztof Kozlowski
2015-11-05 8:44 ` Pavel Fedin
2015-11-05 8:51 ` Krzysztof Kozlowski
2015-11-05 9:00 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5639C1A5.1040708@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=p.fedin@samsung.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).