[PATCH net] net: stmmac: Fixed link does not need MDIO Bus

linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
@ 2020-01-07 12:35 ` Jose Abreu
  2020-01-07 12:51   ` Sriram Dash
                     ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Jose Abreu @ 2020-01-07 12:35 UTC (permalink / raw)
  To: netdev
  Cc: Joao Pinto, Jose Abreu, Giuseppe Cavallaro, Alexandre Torgue,
	Jose Abreu, David S. Miller, Maxime Coquelin, linux-stm32,
	linux-arm-kernel, linux-kernel, Heiko Stuebner,
	kernelci . org bot, Florian Fainelli, Sriram Dash

When using fixed link we don't need the MDIO bus support.

Reported-by: Heiko Stuebner <heiko@sntech.de>
Reported-by: kernelci.org bot <bot@kernelci.org>
Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms without PHY")
Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>

---
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Jose Abreu <joabreu@synopsys.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: netdev@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: kernelci.org bot <bot@kernelci.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Sriram Dash <sriram.dash@samsung.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index cc8d7e7bf9ac..4775f49d7f3b 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device *pdev,
 static int stmmac_dt_phy(struct plat_stmmacenet_data *plat,
 			 struct device_node *np, struct device *dev)
 {
-	bool mdio = false;
+	bool mdio = !of_phy_is_fixed_link(np);
 	static const struct of_device_id need_mdio_ids[] = {
 		{ .compatible = "snps,dwc-qos-ethernet-4.10" },
 		{},
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* RE: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
  2020-01-07 12:35 ` [PATCH net] net: stmmac: Fixed link does not need MDIO Bus Jose Abreu
@ 2020-01-07 12:51   ` Sriram Dash
  2020-01-07 13:30     ` [Linux-stm32] " Patrice CHOTARD
  2020-01-07 14:10   ` Heiko Stübner
                     ` (3 subsequent siblings)
  4 siblings, 1 reply; 8+ messages in thread
From: Sriram Dash @ 2020-01-07 12:51 UTC (permalink / raw)
  To: 'Jose Abreu', netdev
  Cc: 'Joao Pinto', 'Giuseppe Cavallaro',
	'Alexandre Torgue', 'David S. Miller',
	'Maxime Coquelin',
	linux-stm32, linux-arm-kernel, linux-kernel,
	'Heiko Stuebner', 'kernelci . org bot',
	'Florian Fainelli'

> From: Jose Abreu <Jose.Abreu@synopsys.com>
> Subject: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
> 
> When using fixed link we don't need the MDIO bus support.
> 
> Reported-by: Heiko Stuebner <heiko@sntech.de>
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms
> without PHY")
> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>

Acked-by: Sriram Dash <Sriram.dash@samsung.com>

> 
> ---
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Jose Abreu <joabreu@synopsys.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: kernelci.org bot <bot@kernelci.org>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Sriram Dash <sriram.dash@samsung.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index cc8d7e7bf9ac..4775f49d7f3b 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device
> *pdev,  static int stmmac_dt_phy(struct plat_stmmacenet_data *plat,
>  			 struct device_node *np, struct device *dev)  {
> -	bool mdio = false;
> +	bool mdio = !of_phy_is_fixed_link(np);
>  	static const struct of_device_id need_mdio_ids[] = {
>  		{ .compatible = "snps,dwc-qos-ethernet-4.10" },
>  		{},
> --
> 2.7.4



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Linux-stm32] [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
  2020-01-07 12:51   ` Sriram Dash
@ 2020-01-07 13:30     ` Patrice CHOTARD
  0 siblings, 0 replies; 8+ messages in thread
From: Patrice CHOTARD @ 2020-01-07 13:30 UTC (permalink / raw)
  To: Sriram Dash, 'Jose Abreu', netdev
  Cc: 'Joao Pinto', 'kernelci . org bot',
	linux-kernel, 'David S. Miller',
	'Florian Fainelli', 'Maxime Coquelin',
	Peppe CAVALLARO, linux-stm32, linux-arm-kernel,
	'Heiko Stuebner'

Hi All

On 1/7/20 1:51 PM, Sriram Dash wrote:
>> From: Jose Abreu <Jose.Abreu@synopsys.com>
>> Subject: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
>>
>> When using fixed link we don't need the MDIO bus support.
>>
>> Reported-by: Heiko Stuebner <heiko@sntech.de>
>> Reported-by: kernelci.org bot <bot@kernelci.org>
>> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms
>> without PHY")
>> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>
> Acked-by: Sriram Dash <Sriram.dash@samsung.com>

Tested on STiH410-B2260 board

Tested-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

>> ---
>> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> Cc: Alexandre Torgue <alexandre.torgue@st.com>
>> Cc: Jose Abreu <joabreu@synopsys.com>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>> Cc: netdev@vger.kernel.org
>> Cc: linux-stm32@st-md-mailman.stormreply.com
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: Heiko Stuebner <heiko@sntech.de>
>> Cc: kernelci.org bot <bot@kernelci.org>
>> Cc: Florian Fainelli <f.fainelli@gmail.com>
>> Cc: Sriram Dash <sriram.dash@samsung.com>
>> ---
>>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> index cc8d7e7bf9ac..4775f49d7f3b 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device
>> *pdev,  static int stmmac_dt_phy(struct plat_stmmacenet_data *plat,
>>  			 struct device_node *np, struct device *dev)  {
>> -	bool mdio = false;
>> +	bool mdio = !of_phy_is_fixed_link(np);
>>  	static const struct of_device_id need_mdio_ids[] = {
>>  		{ .compatible = "snps,dwc-qos-ethernet-4.10" },
>>  		{},
>> --
>> 2.7.4
>
> _______________________________________________
> Linux-stm32 mailing list
> Linux-stm32@st-md-mailman.stormreply.com
> https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
  2020-01-07 12:35 ` [PATCH net] net: stmmac: Fixed link does not need MDIO Bus Jose Abreu
  2020-01-07 12:51   ` Sriram Dash
@ 2020-01-07 14:10   ` Heiko Stübner
  2020-01-07 14:23   ` Neil Armstrong
                     ` (2 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Heiko Stübner @ 2020-01-07 14:10 UTC (permalink / raw)
  To: Jose Abreu
  Cc: netdev, Joao Pinto, Giuseppe Cavallaro, Alexandre Torgue,
	David S. Miller, Maxime Coquelin, linux-stm32, linux-arm-kernel,
	linux-kernel, kernelci . org bot, Florian Fainelli, Sriram Dash

Am Dienstag, 7. Januar 2020, 13:35:42 CET schrieb Jose Abreu:
> When using fixed link we don't need the MDIO bus support.
> 
> Reported-by: Heiko Stuebner <heiko@sntech.de>
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms without PHY")
> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>

On px30
Tested-by: Heiko Stuebner <heiko@sntech.de>



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
  2020-01-07 12:35 ` [PATCH net] net: stmmac: Fixed link does not need MDIO Bus Jose Abreu
  2020-01-07 12:51   ` Sriram Dash
  2020-01-07 14:10   ` Heiko Stübner
@ 2020-01-07 14:23   ` Neil Armstrong
  2020-01-07 19:05   ` Florian Fainelli
  2020-01-07 21:41   ` David Miller
  4 siblings, 0 replies; 8+ messages in thread
From: Neil Armstrong @ 2020-01-07 14:23 UTC (permalink / raw)
  To: Jose Abreu, netdev
  Cc: Joao Pinto, Alexandre Torgue, kernelci . org bot, Sriram Dash,
	linux-kernel, linux-stm32, Florian Fainelli, Maxime Coquelin,
	Giuseppe Cavallaro, David S. Miller, linux-arm-kernel,
	Heiko Stuebner

On 07/01/2020 13:35, Jose Abreu wrote:
> When using fixed link we don't need the MDIO bus support.
> 
> Reported-by: Heiko Stuebner <heiko@sntech.de>
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms without PHY")
> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>
> 
> ---
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Jose Abreu <joabreu@synopsys.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: kernelci.org bot <bot@kernelci.org>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Sriram Dash <sriram.dash@samsung.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index cc8d7e7bf9ac..4775f49d7f3b 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device *pdev,
>  static int stmmac_dt_phy(struct plat_stmmacenet_data *plat,
>  			 struct device_node *np, struct device *dev)
>  {
> -	bool mdio = false;
> +	bool mdio = !of_phy_is_fixed_link(np);
>  	static const struct of_device_id need_mdio_ids[] = {
>  		{ .compatible = "snps,dwc-qos-ethernet-4.10" },
>  		{},
> 

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
  2020-01-07 12:35 ` [PATCH net] net: stmmac: Fixed link does not need MDIO Bus Jose Abreu
                     ` (2 preceding siblings ...)
  2020-01-07 14:23   ` Neil Armstrong
@ 2020-01-07 19:05   ` Florian Fainelli
  2020-01-07 21:42     ` David Miller
  2020-01-07 21:41   ` David Miller
  4 siblings, 1 reply; 8+ messages in thread
From: Florian Fainelli @ 2020-01-07 19:05 UTC (permalink / raw)
  To: Jose Abreu, netdev
  Cc: Joao Pinto, Giuseppe Cavallaro, Alexandre Torgue,
	David S. Miller, Maxime Coquelin, linux-stm32, linux-arm-kernel,
	linux-kernel, Heiko Stuebner, kernelci . org bot, Sriram Dash

On 1/7/20 4:35 AM, Jose Abreu wrote:
> When using fixed link we don't need the MDIO bus support.
> 
> Reported-by: Heiko Stuebner <heiko@sntech.de>
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms without PHY")
> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Florian Fainelli <f.fainelli@gmail> # Lamobo R1 (fixed-link +
MDIO sub node for roboswitch).
-- 
Florian

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
  2020-01-07 19:05   ` Florian Fainelli
@ 2020-01-07 21:42     ` David Miller
  0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2020-01-07 21:42 UTC (permalink / raw)
  To: f.fainelli
  Cc: Jose.Abreu, netdev, Joao.Pinto, peppe.cavallaro,
	alexandre.torgue, mcoquelin.stm32, linux-stm32, linux-arm-kernel,
	linux-kernel, heiko, bot, sriram.dash

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 7 Jan 2020 11:05:07 -0800

> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> Tested-by: Florian Fainelli <f.fainelli@gmail> # Lamobo R1 (fixed-link +
> MDIO sub node for roboswitch).

Florian please be careful not to let individual tags split into
multiple lines, I had to hand edit the second part of the Tested-by:
tag into the commit message.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
  2020-01-07 12:35 ` [PATCH net] net: stmmac: Fixed link does not need MDIO Bus Jose Abreu
                     ` (3 preceding siblings ...)
  2020-01-07 19:05   ` Florian Fainelli
@ 2020-01-07 21:41   ` David Miller
  4 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2020-01-07 21:41 UTC (permalink / raw)
  To: Jose.Abreu
  Cc: netdev, Joao.Pinto, peppe.cavallaro, alexandre.torgue,
	mcoquelin.stm32, linux-stm32, linux-arm-kernel, linux-kernel,
	heiko, bot, f.fainelli, sriram.dash

From: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Tue,  7 Jan 2020 13:35:42 +0100

> When using fixed link we don't need the MDIO bus support.
> 
> Reported-by: Heiko Stuebner <heiko@sntech.de>
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms without PHY")
> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>

Applied.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-01-07 21:42 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20200107123550epcas5p2d1914646e71e0ff0095b4a14eb5e1551@epcas5p2.samsung.com>
2020-01-07 12:35 ` [PATCH net] net: stmmac: Fixed link does not need MDIO Bus Jose Abreu
2020-01-07 12:51   ` Sriram Dash
2020-01-07 13:30     ` [Linux-stm32] " Patrice CHOTARD
2020-01-07 14:10   ` Heiko Stübner
2020-01-07 14:23   ` Neil Armstrong
2020-01-07 19:05   ` Florian Fainelli
2020-01-07 21:42     ` David Miller
2020-01-07 21:41   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).