* RE: [NFS] Re: [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions)
@ 2005-09-22 14:11 Lever, Charles
2005-09-22 19:31 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Lever, Charles @ 2005-09-22 14:11 UTC (permalink / raw)
To: Steve Dickson, akpm; +Cc: NFS, linux-kernel
> -----Original Message-----
> From: Steve Dickson [mailto:SteveD@redhat.com]
> Sent: Thursday, September 22, 2005 10:02 AM
> To: linux-kernel
> Cc: NFS@lists.sourceforge.net
> Subject: [NFS] Re: [PATCH] repair nfsd/sunrpc in
> 2.6.14-rc2-mm1 (and other -mm versions)
>
> Max Kellermann wrote:
> > Your -mm patches make the sunrpc client connect to the
> portmapper with
> > a non-privileged source port. This is due to a change in
> > net/sunrpc/pmap_clnt.c, which manually resets the xprt->resvport
> > field. My tiny patch removes this line. I have no idea
> why the line
> > was added in the first place, does somebody know better?
> Yes this is a bug, since most Linux portmapper will not
> allow ports to be set or unset using non-privilege ports.
> But non-privilege ports can be used to get ports information.
> So I would suggest the following patch that stops the
> use of privileges ports on only get port requests.
this was my patch (idea was steve's). i've already sent a fix to
andrew. andrew please let me know if you haven't received it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [NFS] Re: [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions)
2005-09-22 14:11 [NFS] Re: [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions) Lever, Charles
@ 2005-09-22 19:31 ` Andrew Morton
2005-09-22 19:46 ` Peter Staubach
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2005-09-22 19:31 UTC (permalink / raw)
To: Lever, Charles; +Cc: SteveD, NFS, linux-kernel, Trond Myklebust
"Lever, Charles" <Charles.Lever@netapp.com> wrote:
>
> > -----Original Message-----
> > From: Steve Dickson [mailto:SteveD@redhat.com]
> > Sent: Thursday, September 22, 2005 10:02 AM
> > To: linux-kernel
> > Cc: NFS@lists.sourceforge.net
> > Subject: [NFS] Re: [PATCH] repair nfsd/sunrpc in
> > 2.6.14-rc2-mm1 (and other -mm versions)
> >
> > Max Kellermann wrote:
> > > Your -mm patches make the sunrpc client connect to the
> > portmapper with
> > > a non-privileged source port. This is due to a change in
> > > net/sunrpc/pmap_clnt.c, which manually resets the xprt->resvport
> > > field. My tiny patch removes this line. I have no idea
> > why the line
> > > was added in the first place, does somebody know better?
> > Yes this is a bug, since most Linux portmapper will not
> > allow ports to be set or unset using non-privilege ports.
> > But non-privilege ports can be used to get ports information.
> > So I would suggest the following patch that stops the
> > use of privileges ports on only get port requests.
>
> this was my patch (idea was steve's). i've already sent a fix to
> andrew. andrew please let me know if you haven't received it.
Ah, good. Please resend?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [NFS] Re: [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions)
2005-09-22 19:31 ` Andrew Morton
@ 2005-09-22 19:46 ` Peter Staubach
0 siblings, 0 replies; 5+ messages in thread
From: Peter Staubach @ 2005-09-22 19:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: Lever, Charles, SteveD, NFS, linux-kernel, Trond Myklebust
Andrew Morton wrote:
>"Lever, Charles" <Charles.Lever@netapp.com> wrote:
>
>
>>>-----Original Message-----
>>>
>>>
>> > From: Steve Dickson [mailto:SteveD@redhat.com]
>> > Sent: Thursday, September 22, 2005 10:02 AM
>> > To: linux-kernel
>> > Cc: NFS@lists.sourceforge.net
>> > Subject: [NFS] Re: [PATCH] repair nfsd/sunrpc in
>> > 2.6.14-rc2-mm1 (and other -mm versions)
>> >
>> > Max Kellermann wrote:
>> > > Your -mm patches make the sunrpc client connect to the
>> > portmapper with
>> > > a non-privileged source port. This is due to a change in
>> > > net/sunrpc/pmap_clnt.c, which manually resets the xprt->resvport
>> > > field. My tiny patch removes this line. I have no idea
>> > why the line
>> > > was added in the first place, does somebody know better?
>> > Yes this is a bug, since most Linux portmapper will not
>> > allow ports to be set or unset using non-privilege ports.
>> > But non-privilege ports can be used to get ports information.
>> > So I would suggest the following patch that stops the
>> > use of privileges ports on only get port requests.
>>
>> this was my patch (idea was steve's). i've already sent a fix to
>> andrew. andrew please let me know if you haven't received it.
>>
>>
>
>Ah, good. Please resend?
>
Actually, Chuck's patch and Steve's aren't quite the same. Both patches
fix the problem that the portmap daemon requires a request to set something
to come from a reserved port. In addition to this, Steve's patch reduces
the number of reserved ports that the kernel requires. This is the problem
that resulted in pmap_create() being incorrectly modified in the first
place.
Steve's patch correctly puts the support in rpc_getport() where it belongs.
Thanx...
ps
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [NFS] Re: [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions)
2005-09-22 19:53 Lever, Charles
@ 2005-09-22 20:08 ` Peter Staubach
0 siblings, 0 replies; 5+ messages in thread
From: Peter Staubach @ 2005-09-22 20:08 UTC (permalink / raw)
To: Lever, Charles; +Cc: Andrew Morton, SteveD, NFS, linux-kernel, Trond Myklebust
Lever, Charles wrote:
>>Actually, Chuck's patch and Steve's aren't quite the same.
>>Both patches
>>fix the problem that the portmap daemon requires a request to
>>set something
>>to come from a reserved port. In addition to this, Steve's
>>patch reduces
>>the number of reserved ports that the kernel requires. This
>>is the problem
>>that resulted in pmap_create() being incorrectly modified in
>>the first
>>place.
>>Steve's patch correctly puts the support in rpc_getport()
>>where it belongs.
>>
>>
>
>mine does too. pmap_create() is used for both GET and SET, and i added
>a parm to allow pmap_create()'s caller to request a reserved port when
>needed.
>
Hmmm. That's not the patch that Andrew Morton included in his email to
linux-kernel then. That patch just removed the line to set xprt->resvport
to 0. That one fixed problem but not the other.
Thanx...
ps
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [NFS] Re: [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions)
@ 2005-09-22 19:53 Lever, Charles
2005-09-22 20:08 ` Peter Staubach
0 siblings, 1 reply; 5+ messages in thread
From: Lever, Charles @ 2005-09-22 19:53 UTC (permalink / raw)
To: Peter Staubach, Andrew Morton; +Cc: SteveD, NFS, linux-kernel, Trond Myklebust
> Actually, Chuck's patch and Steve's aren't quite the same.
> Both patches
> fix the problem that the portmap daemon requires a request to
> set something
> to come from a reserved port. In addition to this, Steve's
> patch reduces
> the number of reserved ports that the kernel requires. This
> is the problem
> that resulted in pmap_create() being incorrectly modified in
> the first
> place.
> Steve's patch correctly puts the support in rpc_getport()
> where it belongs.
mine does too. pmap_create() is used for both GET and SET, and i added
a parm to allow pmap_create()'s caller to request a reserved port when
needed.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-09-22 20:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-09-22 14:11 [NFS] Re: [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions) Lever, Charles
2005-09-22 19:31 ` Andrew Morton
2005-09-22 19:46 ` Peter Staubach
2005-09-22 19:53 Lever, Charles
2005-09-22 20:08 ` Peter Staubach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).