From: CK Hu <ck.hu@mediatek.com>
To: Bo-Chen Chen <rex-bc.chen@mediatek.com>,
<chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
<daniel@ffwll.ch>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <matthias.bgg@gmail.com>, <deller@gmx.de>,
<airlied@linux.ie>
Cc: <msp@baylibre.com>, <granquet@baylibre.com>,
<jitao.shi@mediatek.com>, <wenst@chromium.org>,
<angelogioacchino.delregno@collabora.com>,
<liangxu.xu@mediatek.com>, <dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-fbdev@vger.kernel.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v14 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver
Date: Wed, 13 Jul 2022 16:03:19 +0800 [thread overview]
Message-ID: <0457d6f70457447e639ba06f24fc39fb5e467724.camel@mediatek.com> (raw)
In-Reply-To: <20220712111223.13080-6-rex-bc.chen@mediatek.com>
Hi, Bo-Chen:
On Tue, 2022-07-12 at 19:12 +0800, Bo-Chen Chen wrote:
> From: Markus Schneider-Pargmann <msp@baylibre.com>
>
> This patch adds a embedded displayport driver for the MediaTek mt8195
> SoC.
>
> It supports the MT8195, the embedded DisplayPort units. It offers
> DisplayPort 1.4 with up to 4 lanes.
>
> The driver creates a child device for the phy. The child device will
> never exist without the parent being active. As they are sharing a
> register range, the parent passes a regmap pointer to the child so
> that
> both can work with the same register range. The phy driver sets
> device
> data that is read by the parent to get the phy device that can be
> used
> to control the phy properties.
>
> This driver is based on an initial version by
> Jitao shi <jitao.shi@mediatek.com>
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> ---
[snip]
> +
> +static irqreturn_t mtk_dp_hpd_event_thread(int hpd, void *dev)
> +{
> + struct mtk_dp *mtk_dp = dev;
> +
> + if (mtk_dp->train_info.cable_state_change) {
> + mtk_dp->train_info.cable_state_change = false;
> +
> + mtk_dp_update_bits(mtk_dp, MTK_DP_TOP_PWR_STATE,
> + DP_PWR_STATE_BANDGAP_TPLL_LANE,
> + DP_PWR_STATE_MASK);
You set cable_state_change to true in isr handler just to update a
register in isr thread. I think you could just update this register in
isr handler and drop cable_state_change.
Regards,
CK
> + }
> +
> + if (mtk_dp->train_info.irq_sta.hpd_inerrupt) {
> + dev_dbg(mtk_dp->dev, "MTK_DP_HPD_INTERRUPT\n");
> + mtk_dp->train_info.irq_sta.hpd_inerrupt = false;
> + mtk_dp_hpd_sink_event(mtk_dp);
> + }
> +
> + return IRQ_HANDLED;
> +}
> +
next prev parent reply other threads:[~2022-07-13 8:03 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 11:12 [PATCH v14 00/10] drm/mediatek: Add MT8195 DisplayPort driver Bo-Chen Chen
2022-07-12 11:12 ` [PATCH v14 01/10] dt-bindings: mediatek,dp: Add Display Port binding Bo-Chen Chen
2022-07-13 7:56 ` CK Hu
2022-07-26 6:18 ` Rex-BC Chen
2022-07-26 8:46 ` CK Hu
2022-07-18 20:21 ` Rob Herring
2022-07-12 11:12 ` [PATCH v14 02/10] drm/edid: Convert cea_sad helper struct to kernelDoc Bo-Chen Chen
2022-07-12 11:12 ` [PATCH v14 03/10] drm/edid: Add cea_sad helpers for freq/length Bo-Chen Chen
2022-07-14 11:12 ` AngeloGioacchino Del Regno
2022-07-14 11:19 ` Rex-BC Chen
2022-07-12 11:12 ` [PATCH v14 04/10] video/hdmi: Add audio_infoframe packing for DP Bo-Chen Chen
2022-07-14 11:26 ` AngeloGioacchino Del Regno
2022-07-12 11:12 ` [PATCH v14 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver Bo-Chen Chen
2022-07-13 8:03 ` CK Hu [this message]
2022-07-13 8:10 ` CK Hu
2022-07-14 8:24 ` Rex-BC Chen
2022-07-14 10:21 ` CK Hu
2022-07-13 8:22 ` CK Hu
2022-07-13 8:30 ` CK Hu
2022-07-13 9:12 ` CK Hu
2022-07-13 9:31 ` CK Hu
2022-07-14 8:52 ` Rex-BC Chen
2022-07-13 9:33 ` CK Hu
2022-07-14 8:57 ` Rex-BC Chen
2022-07-13 9:45 ` CK Hu
2022-07-14 6:51 ` CK Hu
2022-07-14 9:09 ` Rex-BC Chen
2022-07-14 10:34 ` CK Hu
2022-07-14 7:06 ` CK Hu
2022-07-15 8:51 ` CK Hu
2022-07-21 2:38 ` Rex-BC Chen
2022-07-21 6:24 ` CK Hu
2022-07-15 9:13 ` CK Hu
2022-07-15 9:14 ` CK Hu
2022-07-15 9:37 ` CK Hu
2022-07-15 18:01 ` kernel test robot
2022-07-25 9:16 ` CK Hu
2022-07-26 6:42 ` Rex-BC Chen
2022-07-26 9:34 ` CK Hu
2022-07-26 10:06 ` Rex-BC Chen
2022-07-25 9:23 ` CK Hu
2022-07-26 3:30 ` Rex-BC Chen
2022-07-26 8:37 ` CK Hu
2022-07-12 11:12 ` [PATCH v14 06/10] drm/mediatek: Add MT8195 External DisplayPort support Bo-Chen Chen
2022-07-25 9:51 ` CK Hu
2022-07-12 11:12 ` [PATCH v14 07/10] drm/mediatek: add hpd debounce Bo-Chen Chen
2022-07-12 11:12 ` [PATCH v14 08/10] drm/mediatek: set monitor to DP_SET_POWER_D3 to avoid garbage Bo-Chen Chen
2022-07-12 11:12 ` [PATCH v14 09/10] drm/mediatek: DP audio support for MT8195 Bo-Chen Chen
2022-07-14 11:43 ` AngeloGioacchino Del Regno
2022-07-12 11:12 ` [PATCH v14 10/10] drm/mediatek: Use cached audio config when changing resolution Bo-Chen Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0457d6f70457447e639ba06f24fc39fb5e467724.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liangxu.xu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).