From: CK Hu <ck.hu@mediatek.com>
To: Rex-BC Chen <rex-bc.chen@mediatek.com>, <chunkuang.hu@kernel.org>,
<p.zabel@pengutronix.de>, <daniel@ffwll.ch>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <matthias.bgg@gmail.com>, <deller@gmx.de>,
<airlied@linux.ie>
Cc: <msp@baylibre.com>, <granquet@baylibre.com>,
<jitao.shi@mediatek.com>, <wenst@chromium.org>,
<angelogioacchino.delregno@collabora.com>,
<liangxu.xu@mediatek.com>, <dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-fbdev@vger.kernel.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v14 01/10] dt-bindings: mediatek,dp: Add Display Port binding
Date: Tue, 26 Jul 2022 16:46:40 +0800 [thread overview]
Message-ID: <38f785af2815e45d175f02d9970e3401e700a645.camel@mediatek.com> (raw)
In-Reply-To: <ef407d8767d12d240280f1c9d9fdd8ba9d3e5632.camel@mediatek.com>
On Tue, 2022-07-26 at 14:18 +0800, Rex-BC Chen wrote:
> On Wed, 2022-07-13 at 15:56 +0800, CK Hu wrote:
> > Hi, Bo-Chen:
> >
> > On Tue, 2022-07-12 at 19:12 +0800, Bo-Chen Chen wrote:
> > > From: Markus Schneider-Pargmann <msp@baylibre.com>
> > >
> > > This controller is present on several mediatek hardware.
> > > Currently
> > > mt8195 and mt8395 have this controller without a functional
> > > difference,
> > > so only one compatible field is added.
> > >
> > > The controller can have two forms, as a normal display port and
> > > as
> > > an
> > > embedded display port.
> > >
> > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> > > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> > > ---
> > > .../display/mediatek/mediatek,dp.yaml | 115
> > > ++++++++++++++++++
> > > 1 file changed, 115 insertions(+)
> > > create mode 100644
> > > Documentation/devicetree/bindings/display/mediatek/mediatek,dp.ya
> > > ml
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.
> > > ya
> > > ml
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.
> > > ya
> > > ml
> > > new file mode 100644
> > > index 000000000000..e2d6cb314297
> > > --- /dev/null
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.
> > > ya
> > > ml
> > > @@ -0,0 +1,115 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id:
> > > http://devicetree.org/schemas/display/mediatek/mediatek,dp.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: MediaTek Display Port Controller
> > > +
> > > +maintainers:
> > > + - Chun-Kuang Hu <chunkuang.hu@kernel.org>
> > > + - Jitao shi <jitao.shi@mediatek.com>
> > > +
> > > +description: |
> > > + Device tree bindings for the MediaTek display port TX (DP) and
> > > + embedded display port TX (eDP) controller present on some
> > > MediaTek
> > > SoCs.
> > > + MediaTek DP and eDP are different hardwares and they have
> > > different
> > > + base address for registers, so we need two different
> > > compatibles
> > > to
> > > + separate them.
> > > +
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + - mediatek,mt8195-dp-tx
> > > + - mediatek,mt8195-edp-tx
> > > +
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + nvmem-cells:
> > > + maxItems: 1
> > > + description: efuse data for display port calibration
> > > +
> > > + nvmem-cell-names:
> > > + const: dp_calibration_data
> > > +
> > > + power-domains:
> > > + maxItems: 1
> > > +
> > > + interrupts:
> > > + maxItems: 1
> > > +
> > > + ports:
> > > + $ref: /schemas/graph.yaml#/properties/ports
> > > + properties:
> > > + port@0:
> > > + $ref: /schemas/graph.yaml#/properties/port
> > > + description: Input endpoint of the controller, usually
> > > dp_intf
> > > +
> > > + port@1:
> > > + $ref: /schemas/graph.yaml#/$defs/port-base
> > > + unevaluatedProperties: false
> > > + description: Output endpoint of the controller
> > > + properties:
> > > + endpoint:
> > > + $ref: /schemas/media/video-interfaces.yaml#
> > > + unevaluatedProperties: false
> > > + properties:
> > > + data-lanes:
> > > + description: |
> > > + number of lanes supported by the hardware.
> > > + The possible values:
> > > + 0 - For 1 lane enabled in IP.
> > > + 0 1 - For 2 lanes enabled in IP.
> > > + 0 1 2 3 - For 4 lanes enabled in IP.
> > > + minItems: 1
> > > + maxItems: 4
> > > + required:
> > > + - data-lanes
> > > +
> > > + required:
> > > + - port@0
> > > + - port@1
> > > +
> > > + max-linkrate-mhz:
> > > + enum: [ 1620, 2700, 5400, 8100 ]
> > > + description: maximum link rate supported by the hardware.
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - interrupts
> > > + - ports
> > > + - max-linkrate-mhz
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > + - |
> > > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > > + #include <dt-bindings/power/mt8195-power.h>
> > > + dp_tx@1c600000 {
> > > + compatible = "mediatek,mt8195-dp-tx";
> > > + reg = <0x1c600000 0x8000>;
> > > + power-domains = <&spm MT8195_POWER_DOMAIN_DP_TX>;
> > > + interrupts = <GIC_SPI 458 IRQ_TYPE_LEVEL_HIGH 0>;
> > > + max-linkrate-mhz = <8100>;
> >
> > Why dp-tx has no clock property? I think this device should work
> > with
> > a
> > clock.
> >
> > Regards,
> > CK
> >
>
> Hello CK,
>
> We just need to enable the power domain of dp.
> The clock of dp is generated by itself and we are not using the
> global
> pll to generate clocks.
Add this to description because this is not trivial.
Regards,
CK
>
> BRs,
> Bo-Chen
>
> > > +
> > > + ports {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + port@0 {
> > > + reg = <0>;
> > > + dptx_in: endpoint {
> > > + remote-endpoint = <&dp_intf0_out>;
> > > + };
> > > + };
> > > + port@1 {
> > > + reg = <1>;
> > > + dptx_out: endpoint {
> > > + data-lanes = <0 1 2 3>;
> > > + };
> > > + };
> > > + };
> > > + };
> >
> >
>
>
next prev parent reply other threads:[~2022-07-26 8:46 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 11:12 [PATCH v14 00/10] drm/mediatek: Add MT8195 DisplayPort driver Bo-Chen Chen
2022-07-12 11:12 ` [PATCH v14 01/10] dt-bindings: mediatek,dp: Add Display Port binding Bo-Chen Chen
2022-07-13 7:56 ` CK Hu
2022-07-26 6:18 ` Rex-BC Chen
2022-07-26 8:46 ` CK Hu [this message]
2022-07-18 20:21 ` Rob Herring
2022-07-12 11:12 ` [PATCH v14 02/10] drm/edid: Convert cea_sad helper struct to kernelDoc Bo-Chen Chen
2022-07-12 11:12 ` [PATCH v14 03/10] drm/edid: Add cea_sad helpers for freq/length Bo-Chen Chen
2022-07-14 11:12 ` AngeloGioacchino Del Regno
2022-07-14 11:19 ` Rex-BC Chen
2022-07-12 11:12 ` [PATCH v14 04/10] video/hdmi: Add audio_infoframe packing for DP Bo-Chen Chen
2022-07-14 11:26 ` AngeloGioacchino Del Regno
2022-07-12 11:12 ` [PATCH v14 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver Bo-Chen Chen
2022-07-13 8:03 ` CK Hu
2022-07-13 8:10 ` CK Hu
2022-07-14 8:24 ` Rex-BC Chen
2022-07-14 10:21 ` CK Hu
2022-07-13 8:22 ` CK Hu
2022-07-13 8:30 ` CK Hu
2022-07-13 9:12 ` CK Hu
2022-07-13 9:31 ` CK Hu
2022-07-14 8:52 ` Rex-BC Chen
2022-07-13 9:33 ` CK Hu
2022-07-14 8:57 ` Rex-BC Chen
2022-07-13 9:45 ` CK Hu
2022-07-14 6:51 ` CK Hu
2022-07-14 9:09 ` Rex-BC Chen
2022-07-14 10:34 ` CK Hu
2022-07-14 7:06 ` CK Hu
2022-07-15 8:51 ` CK Hu
2022-07-21 2:38 ` Rex-BC Chen
2022-07-21 6:24 ` CK Hu
2022-07-15 9:13 ` CK Hu
2022-07-15 9:14 ` CK Hu
2022-07-15 9:37 ` CK Hu
2022-07-15 18:01 ` kernel test robot
2022-07-25 9:16 ` CK Hu
2022-07-26 6:42 ` Rex-BC Chen
2022-07-26 9:34 ` CK Hu
2022-07-26 10:06 ` Rex-BC Chen
2022-07-25 9:23 ` CK Hu
2022-07-26 3:30 ` Rex-BC Chen
2022-07-26 8:37 ` CK Hu
2022-07-12 11:12 ` [PATCH v14 06/10] drm/mediatek: Add MT8195 External DisplayPort support Bo-Chen Chen
2022-07-25 9:51 ` CK Hu
2022-07-12 11:12 ` [PATCH v14 07/10] drm/mediatek: add hpd debounce Bo-Chen Chen
2022-07-12 11:12 ` [PATCH v14 08/10] drm/mediatek: set monitor to DP_SET_POWER_D3 to avoid garbage Bo-Chen Chen
2022-07-12 11:12 ` [PATCH v14 09/10] drm/mediatek: DP audio support for MT8195 Bo-Chen Chen
2022-07-14 11:43 ` AngeloGioacchino Del Regno
2022-07-12 11:12 ` [PATCH v14 10/10] drm/mediatek: Use cached audio config when changing resolution Bo-Chen Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38f785af2815e45d175f02d9970e3401e700a645.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liangxu.xu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).