* [PATCH] platform/x86: asus-wmi: Add keymap entry for lid flip action on Asus UX360
@ 2018-08-10 20:07 Aleh Filipovich
2018-08-15 10:15 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Aleh Filipovich @ 2018-08-10 20:07 UTC (permalink / raw)
Cc: Corentin Chary, Darren Hart, Andy Shevchenko,
platform-driver-x86, acpi4asus-user, linux-kernel
Add entry to WMI keymap for lid flip event on Asus UX360.
On Asus Zenbook ux360 flipping lid from/to tablet mode triggers
keyscan code 0xfa which cannot be handled and results in kernel
log message "Unknown key fa pressed".
Signed-off-by: Aleh Filipovich<aleh@appnexus.com>
---
drivers/platform/x86/asus-nb-wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 136ff2b4cce5..db2af09067db 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -496,6 +496,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
{ KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
{ KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
{ KE_IGNORE, 0xC6, }, /* Ambient Light Sensor notification */
+ { KE_KEY, 0xFA, { KEY_PROG2 } }, /* Lid flip action */
{ KE_END, 0},
};
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] platform/x86: asus-wmi: Add keymap entry for lid flip action on Asus UX360
2018-08-10 20:07 [PATCH] platform/x86: asus-wmi: Add keymap entry for lid flip action on Asus UX360 Aleh Filipovich
@ 2018-08-15 10:15 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2018-08-15 10:15 UTC (permalink / raw)
To: Aleh Filipovich
Cc: Corentin Chary, Darren Hart, Andy Shevchenko, Platform Driver,
acpi4asus-user, Linux Kernel Mailing List
On Fri, Aug 10, 2018 at 11:07 PM, Aleh Filipovich <aleh@vaolix.com> wrote:
> Add entry to WMI keymap for lid flip event on Asus UX360.
>
> On Asus Zenbook ux360 flipping lid from/to tablet mode triggers
> keyscan code 0xfa which cannot be handled and results in kernel
> log message "Unknown key fa pressed".
>
>
Pushed to my review and testing queue, thanks!
P.S. your patch is mangled, please, pay attention to the format next time.
> Signed-off-by: Aleh Filipovich<aleh@appnexus.com>
> ---
> drivers/platform/x86/asus-nb-wmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c
> b/drivers/platform/x86/asus-nb-wmi.c
> index 136ff2b4cce5..db2af09067db 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -496,6 +496,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
> { KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
> { KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
> { KE_IGNORE, 0xC6, }, /* Ambient Light Sensor notification */
> + { KE_KEY, 0xFA, { KEY_PROG2 } }, /* Lid flip action */
> { KE_END, 0},
> };
>
> --
> 2.18.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-15 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-10 20:07 [PATCH] platform/x86: asus-wmi: Add keymap entry for lid flip action on Asus UX360 Aleh Filipovich
2018-08-15 10:15 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).