From: Joe Perches <joe@perches.com>
To: Daniel West <daniel.west.dev@gmail.com>, gregkh@linuxfoundation.org
Cc: hverkuil-cisco@xs4all.nl, mchehab+huawei@kernel.org,
christian.gromm@microchip.com, masahiroy@kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most: video: fixed a parentheses coding style issue.
Date: Thu, 17 Dec 2020 15:58:16 -0800 [thread overview]
Message-ID: <04c331f6bfce57c253cb86208ebd28f6363e04c0.camel@perches.com> (raw)
In-Reply-To: <20201217234501.351725-1-daniel.west.dev@gmail.com>
On Thu, 2020-12-17 at 15:45 -0800, Daniel West wrote:
> Fixed a coding style issue.
It may pass checkpatch without warning, but it's uncommon kernel coding style.
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
[]
> @@ -365,8 +365,8 @@ static const struct video_device comp_videodev_template = {
>
>
> /**************************************************************************/
>
>
> -static struct most_video_dev *get_comp_dev(
> - struct most_interface *iface, int channel_idx)
> +static struct most_video_dev *get_comp_dev
> + (struct most_interface *iface, int channel_idx)
This would be better using any of:
(most common)
static struct most_video_dev *get_comp_dev(struct most_interface *iface,
int channel_idx)
or (less common)
static struct most_video_dev *
get_comp_dev(struct most_interface *iface, int channel_idx)
or (> 80 columns)
static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)
next prev parent reply other threads:[~2020-12-17 23:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 23:45 [PATCH] staging: most: video: fixed a parentheses coding style issue Daniel West
2020-12-17 23:58 ` Joe Perches [this message]
2020-12-18 9:49 ` David Laight
2020-12-18 10:08 ` Joe Perches
2020-12-18 10:38 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04c331f6bfce57c253cb86208ebd28f6363e04c0.camel@perches.com \
--to=joe@perches.com \
--cc=christian.gromm@microchip.com \
--cc=daniel.west.dev@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).