From: David Laight <David.Laight@ACULAB.COM>
To: 'Joe Perches' <joe@perches.com>,
Daniel West <daniel.west.dev@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
"christian.gromm@microchip.com" <christian.gromm@microchip.com>,
"masahiroy@kernel.org" <masahiroy@kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] staging: most: video: fixed a parentheses coding style issue.
Date: Fri, 18 Dec 2020 10:38:35 +0000 [thread overview]
Message-ID: <934cbebcb57a49fd8761cc8b3aaffbfa@AcuMS.aculab.com> (raw)
In-Reply-To: <c09401d003360cff41c949ccaea8ae9dc7b2c733.camel@perches.com>
From: Joe Perches
> Sent: 18 December 2020 10:09
> On Fri, 2020-12-18 at 09:49 +0000, David Laight wrote:
> > From: Joe Perches
> > checkpatch probably shouldn't complain about lines that end in (
> > if they are function definitions.
>
> Opinons vary.
>
> Very few function declaration/definitions in the linux kernel use the
> one line per argument style (gnu indent -bfde)
>
> type function(
> type argument1,
> type argument2,
> ...
> )
> {
> ...
> }
>
> It probably shouldn't be encouraged.
The only excuse for anything like that is if there are comments for
each parameter that are used to generate the interface documentation.
Using that style for function calls just wastes vertical space.
At least that doesn't happen in the kernel.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2020-12-18 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 23:45 [PATCH] staging: most: video: fixed a parentheses coding style issue Daniel West
2020-12-17 23:58 ` Joe Perches
2020-12-18 9:49 ` David Laight
2020-12-18 10:08 ` Joe Perches
2020-12-18 10:38 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=934cbebcb57a49fd8761cc8b3aaffbfa@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=christian.gromm@microchip.com \
--cc=daniel.west.dev@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).