* [PATCH net-next] net: core: Remove extra spaces
@ 2021-02-04 3:06 Zheng Yongjun
2021-02-05 3:04 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Zheng Yongjun @ 2021-02-04 3:06 UTC (permalink / raw)
To: davem, kuba, netdev, linux-kernel; +Cc: Zheng Yongjun
Do codingstyle clean up to remove extra spaces.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
net/core/neighbour.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 9500d28a43b0..72ea94ec8c4a 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1618,7 +1618,7 @@ struct neigh_parms *neigh_parms_alloc(struct net_device *dev,
p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL);
if (p) {
- p->tbl = tbl;
+ p->tbl = tbl;
refcount_set(&p->refcnt, 1);
p->reachable_time =
neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: core: Remove extra spaces
2021-02-04 3:06 [PATCH net-next] net: core: Remove extra spaces Zheng Yongjun
@ 2021-02-05 3:04 ` Jakub Kicinski
2021-02-05 3:13 ` 答复: " zhengyongjun
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2021-02-05 3:04 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: davem, netdev, linux-kernel
On Thu, 4 Feb 2021 11:06:39 +0800 Zheng Yongjun wrote:
> Do codingstyle clean up to remove extra spaces.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> net/core/neighbour.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index 9500d28a43b0..72ea94ec8c4a 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -1618,7 +1618,7 @@ struct neigh_parms *neigh_parms_alloc(struct net_device *dev,
>
> p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL);
> if (p) {
> - p->tbl = tbl;
> + p->tbl = tbl;
> refcount_set(&p->refcnt, 1);
> p->reachable_time =
^
It's aligned with the assignment to reachable_time.
I don't find this particularly offensive, there are worse style issues
in this function.
> neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));
^ permalink raw reply [flat|nested] 3+ messages in thread
* 答复: [PATCH net-next] net: core: Remove extra spaces
2021-02-05 3:04 ` Jakub Kicinski
@ 2021-02-05 3:13 ` zhengyongjun
0 siblings, 0 replies; 3+ messages in thread
From: zhengyongjun @ 2021-02-05 3:13 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, linux-kernel
Thank you, I will do this code style cleanup in ` net/core/neighbour.c` to fix the worse style issues you said :)
-----邮件原件-----
发件人: Jakub Kicinski [mailto:kuba@kernel.org]
发送时间: 2021年2月5日 11:05
收件人: zhengyongjun <zhengyongjun3@huawei.com>
抄送: davem@davemloft.net; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH net-next] net: core: Remove extra spaces
On Thu, 4 Feb 2021 11:06:39 +0800 Zheng Yongjun wrote:
> Do codingstyle clean up to remove extra spaces.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> net/core/neighbour.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c index
> 9500d28a43b0..72ea94ec8c4a 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -1618,7 +1618,7 @@ struct neigh_parms *neigh_parms_alloc(struct
> net_device *dev,
>
> p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL);
> if (p) {
> - p->tbl = tbl;
> + p->tbl = tbl;
> refcount_set(&p->refcnt, 1);
> p->reachable_time =
^
It's aligned with the assignment to reachable_time.
I don't find this particularly offensive, there are worse style issues in this function.
> neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-05 3:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 3:06 [PATCH net-next] net: core: Remove extra spaces Zheng Yongjun
2021-02-05 3:04 ` Jakub Kicinski
2021-02-05 3:13 ` 答复: " zhengyongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).