From: Aswath Govindraju <a-govindraju@ti.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-phy@lists.infradead.org>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, <linux-can@vger.kernel.org>,
<netdev@vger.kernel.org>, Vignesh Raghavendra <vigneshr@ti.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers
Date: Thu, 15 Apr 2021 14:41:57 +0530 [thread overview]
Message-ID: <072648d4-a747-bc5f-a525-25dd055905ee@ti.com> (raw)
In-Reply-To: <20210415073810.nwoi2hx57hdg4ima@pengutronix.de>
Hi Marc,
On 15/04/21 1:08 pm, Marc Kleine-Budde wrote:
> On 15.04.2021 11:57:20, Aswath Govindraju wrote:
>> Hi Marc,
>>
>> On 14/04/21 9:03 pm, Marc Kleine-Budde wrote:
>>> On 14.04.2021 19:35:18, Aswath Govindraju wrote:
>>>> Add binding documentation for TI TCAN104x CAN transceivers.
>>>>
>>>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>>>> ---
>>>> .../bindings/phy/ti,tcan104x-can.yaml | 56 +++++++++++++++++++
>>>> MAINTAINERS | 1 +
>>>> 2 files changed, 57 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>>>> new file mode 100644
>>>> index 000000000000..4abfc30a97d0
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>>>> @@ -0,0 +1,56 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: "http://devicetree.org/schemas/phy/ti,tcan104x-can.yaml#"
>>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>>>> +
>>>> +title: TCAN104x CAN TRANSCEIVER PHY
>>>> +
>>>> +maintainers:
>>>> + - Aswath Govindraju <a-govindraju@ti.com>
>
> Can you create a maintainers entry for this file with your address?
I don't see this being done for other phy yamls in the
Documentation/devicetree/bindings/phy folder. Also,
scripts/get_maintainer.pl is giving the names of maintainers after
reading the yaml files too.
Thanks,
Aswath
>
>>>> +
>>>> +properties:
>>>> + $nodename:
>>>> + pattern: "^tcan104x-phy"
>>>> +
>>>> + compatible:
>>>> + enum:
>>>> + - ti,tcan1042
>>>> + - ti,tcan1043
>>>
>>> Can you ensure that the 1042 has only the standby gpio and the 1043 has both?
>>>
>>
>> In the driver, it is the way the flags have been set for ti,tcan1042 and
>> ti,tcan1043.
>
> I was wondering if we would enforce in the DT the 1042 has exactly one
> the standby GPIO and the 1043 has exactly the standby and the enable
> GPIO.
>
> On the other hand the HW might have pulled one or the other pin high or
> low and only one of the pins is connected to a GPIO.
>
>>>> +
>>>> + '#phy-cells':
>>>> + const: 0
>>>> +
>>>> + standby-gpios:
>>>> + description:
>>>> + gpio node to toggle standby signal on transceiver
>>>> + maxItems: 1
>>>> +
>>>> + enable-gpios:
>>>> + description:
>>>> + gpio node to toggle enable signal on transceiver
>>>> + maxItems: 1
>>>> +
>>>> + max-bitrate:
>>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>>> + description:
>>>> + max bit rate supported in bps
>>>> + minimum: 1
>>>> +
>>>> +required:
>>>> + - compatible
>>>> + - '#phy-cells'
>>>> +
>>>> +additionalProperties: false
>>>> +
>>>> +examples:
>>>> + - |
>>>> + #include <dt-bindings/gpio/gpio.h>
>>>> +
>>>> + transceiver1: tcan104x-phy {
>>>> + compatible = "ti,tcan1043";
>>>> + #phy-cells = <0>;
>>>> + max-bitrate = <5000000>;
>>>> + standby-gpios = <&wakeup_gpio1 16 GPIO_ACTIVE_LOW>;
>>>> + enable-gpios = <&main_gpio1 67 GPIO_ACTIVE_LOW>;
>>>
>>> AFAICS the enable gpio is active high.
>>>
>>
>> I will correct this in the respin.
>
> Marc
>
next prev parent reply other threads:[~2021-04-15 9:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 14:05 [PATCH v2 0/6] CAN TRANSCEIVER: Add support for CAN transceivers Aswath Govindraju
2021-04-14 14:05 ` [PATCH v2 1/6] phy: core: Reword the comment specifying the units of max_link_rate to be Mbps Aswath Govindraju
2021-04-14 14:05 ` [PATCH v2 2/6] phy: Add API for devm_of_phy_optional_get_by_index Aswath Govindraju
2021-04-14 14:05 ` [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers Aswath Govindraju
2021-04-14 15:33 ` Marc Kleine-Budde
2021-04-15 6:27 ` Aswath Govindraju
2021-04-15 7:38 ` Marc Kleine-Budde
2021-04-15 9:11 ` Aswath Govindraju [this message]
2021-04-15 9:15 ` Marc Kleine-Budde
2021-04-14 14:05 ` [PATCH v2 4/6] phy: phy-can-transceiver: Add support for generic CAN transceiver driver Aswath Govindraju
2021-04-14 15:39 ` Marc Kleine-Budde
2021-04-14 15:40 ` Marc Kleine-Budde
2021-04-15 7:44 ` kernel test robot
2021-04-15 9:12 ` kernel test robot
2021-04-14 14:05 ` [PATCH v2 5/6] dt-bindings: net: can: Document transceiver implementation as phy Aswath Govindraju
2021-04-14 14:05 ` [PATCH v2 6/6] can: m_can: Add support for transceiver " Aswath Govindraju
2021-04-14 15:15 ` Marc Kleine-Budde
2021-04-14 15:43 ` [PATCH v2 0/6] CAN TRANSCEIVER: Add support for CAN transceivers Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=072648d4-a747-bc5f-a525-25dd055905ee@ti.com \
--to=a-govindraju@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=kishon@ti.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lokeshvutla@ti.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).