Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-phy@lists.infradead.org,
	Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
	Wolfgang Grandegger <wg@grandegger.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Lokesh Vutla <lokeshvutla@ti.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers
Date: Thu, 15 Apr 2021 09:38:10 +0200	[thread overview]
Message-ID: <20210415073810.nwoi2hx57hdg4ima@pengutronix.de> (raw)
In-Reply-To: <9a9a3b8b-f345-faae-b9bc-3961518e3d29@ti.com>

[-- Attachment #1: Type: text/plain, Size: 3356 bytes --]

On 15.04.2021 11:57:20, Aswath Govindraju wrote:
> Hi Marc,
> 
> On 14/04/21 9:03 pm, Marc Kleine-Budde wrote:
> > On 14.04.2021 19:35:18, Aswath Govindraju wrote:
> >> Add binding documentation for TI TCAN104x CAN transceivers.
> >>
> >> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> >> ---
> >>  .../bindings/phy/ti,tcan104x-can.yaml         | 56 +++++++++++++++++++
> >>  MAINTAINERS                                   |  1 +
> >>  2 files changed, 57 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> >> new file mode 100644
> >> index 000000000000..4abfc30a97d0
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> >> @@ -0,0 +1,56 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: "http://devicetree.org/schemas/phy/ti,tcan104x-can.yaml#"
> >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> >> +
> >> +title: TCAN104x CAN TRANSCEIVER PHY
> >> +
> >> +maintainers:
> >> +  - Aswath Govindraju <a-govindraju@ti.com>

Can you create a maintainers entry for this file with your address?

> >> +
> >> +properties:
> >> +  $nodename:
> >> +    pattern: "^tcan104x-phy"
> >> +
> >> +  compatible:
> >> +    enum:
> >> +      - ti,tcan1042
> >> +      - ti,tcan1043
> > 
> > Can you ensure that the 1042 has only the standby gpio and the 1043 has both?
> > 
> 
> In the driver, it is the way the flags have been set for ti,tcan1042 and
> ti,tcan1043.

I was wondering if we would enforce in the DT the 1042 has exactly one
the standby GPIO and the 1043 has exactly the standby and the enable
GPIO.

On the other hand the HW might have pulled one or the other pin high or
low and only one of the pins is connected to a GPIO.

> >> +
> >> +  '#phy-cells':
> >> +    const: 0
> >> +
> >> +  standby-gpios:
> >> +    description:
> >> +      gpio node to toggle standby signal on transceiver
> >> +    maxItems: 1
> >> +
> >> +  enable-gpios:
> >> +    description:
> >> +      gpio node to toggle enable signal on transceiver
> >> +    maxItems: 1
> >> +
> >> +  max-bitrate:
> >> +    $ref: /schemas/types.yaml#/definitions/uint32
> >> +    description:
> >> +      max bit rate supported in bps
> >> +    minimum: 1
> >> +
> >> +required:
> >> +  - compatible
> >> +  - '#phy-cells'
> >> +
> >> +additionalProperties: false
> >> +
> >> +examples:
> >> +  - |
> >> +    #include <dt-bindings/gpio/gpio.h>
> >> +
> >> +    transceiver1: tcan104x-phy {
> >> +      compatible = "ti,tcan1043";
> >> +      #phy-cells = <0>;
> >> +      max-bitrate = <5000000>;
> >> +      standby-gpios = <&wakeup_gpio1 16 GPIO_ACTIVE_LOW>;
> >> +      enable-gpios = <&main_gpio1 67 GPIO_ACTIVE_LOW>;
> > 
> > AFAICS the enable gpio is active high.
> > 
> 
> I will correct this in the respin.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]