From: Hayes Wang <hayeswang@realtek.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
nic_swsd <nic_swsd@realtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Oliver Neukum <oliver@neukum.org>
Subject: RE: [PATCH net-next 0/3] r8152: configuration setting
Date: Thu, 8 Sep 2016 02:44:21 +0000 [thread overview]
Message-ID: <0835B3720019904CB8F7AA43166CEEB2010259B5@RTITMBSV03.realtek.com.tw> (raw)
In-Reply-To: <87h99rizsi.fsf@miraculix.mork.no>
Bjørn Mork [mailto:bjorn@mork.no]
> Sent: Wednesday, September 07, 2016 9:51 PM
[...]
> So this adds a lot of code to work around the issues you introduced by
> unnecessarily blacklisting the CDC ECM configuration earlier, and still
> makes the r8152 driver handle the device even in ECM mode.
I suggest to use vendor mode only, but some people ask me to
submit such patches. If these patches are rejected, I have
enough reasons to tell them it is unacceptable rather than
I don't do it.
> Just remove the completely unnecessary blacklist, and let the cdc_ether
> driver handle the device if the user selects the ECM configuration.
> That't how the USB system works. There is no need for any code in r8152
> to do that.
The pure cdc_ether driver couldn't change the speed of the
ethernet, because it doesn't know how to access the PHY of
the device. Therefore, I add relative code in r8152 driver.
Best Regards,
Hayes
next prev parent reply other threads:[~2016-09-08 2:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 8:12 [PATCH net-next 0/3] r8152: configuration setting Hayes Wang
2016-09-07 8:12 ` [PATCH net-next 1/3] r8152: check hw version first Hayes Wang
2016-09-07 8:12 ` [PATCH net-next 2/3] r8152: support ECM mode Hayes Wang
2016-09-18 18:37 ` kbuild test robot
2016-09-19 0:43 ` kbuild test robot
2016-09-07 8:12 ` [PATCH net-next 3/3] r8152: add CONFIG_RTL8152_CONFIG_VALUE Hayes Wang
2016-09-07 13:51 ` [PATCH net-next 0/3] r8152: configuration setting Bjørn Mork
2016-09-08 2:44 ` Hayes Wang [this message]
2016-09-08 7:54 ` Bjørn Mork
2016-09-08 13:02 ` Hayes Wang
2016-09-08 13:08 ` Oliver Neukum
2016-09-08 13:16 ` Bjørn Mork
2016-09-08 0:37 ` David Miller
2016-09-08 3:00 ` Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0835B3720019904CB8F7AA43166CEEB2010259B5@RTITMBSV03.realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=bjorn@mork.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).